095 Home Stretch

☆ A M B ☆
24,524 Posts

sottwell Reply #31, 20 years ago

I only complained about this two or three time; I do try not to nag grin

You get an error every time you mouseover and mouseout of a menu item with no submenu. It can rack up an amazing number of errors in the FireBug FF extension!

Studying MODX in the desert - http://sottwell.com
Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
Join the Slack Community - http://modx.org

7,075 Posts

davidm Reply #32, 20 years ago

Why not fix it then tongue

?

Anyway, right now my main concern is the language file : has anyone had the same problem (Document tree not loading) with the new language file ?

.: COO - Commerce Guys - Community Driven Innovation :.

MODx est l'outil id

☆ A M B ☆
24,524 Posts

sottwell Reply #33, 20 years ago

I tried, but I’m not experienced enough at javascript to be able to figure out the code.

Studying MODX in the desert - http://sottwell.com
Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
Join the Slack Community - http://modx.org

1,097 Posts

PaulGregory Reply #34, 20 years ago

That English file works fine for me in 1533 and 1557, on a Linux box viewed on Windows Firefox. Works in UTF-8 and iso-8859-1. MODxLight theme.

I should point out that I have had the doc tree disappear on me in 1533 but I’ve not been able to figure out what made it do that. But I’ve not had any situation where everything loads but the doc tree.

David, can you supply your ’fixed’ French file so I can see if it works on my setup?

I really want to find out how to sort this. I *can* create a bunch of lang files now to send to people, but I’m concerned that something is going wrong.

(Actually, I’m half minded to knock together a web/db-based lang file editor, but that’ll probably wait for 0.9.7)

No, I don't know what OpenGeek's saying half the time either.
MODx Documentation: The Wiki | My Wiki contributions | Main MODx Documentation
Forum: Where to post threads about add-ons | Forum Rules
Like MODx? donate (and/or share your resources)
Like me? See my Amazon wishlist
MODx "Most Promising CMS" - so appropriate!

MODX Staff
1,535 Posts

Garry Nutting Reply #35, 20 years ago

Quote from: davidm at Oct 01, 2006, 12:13 AM

I just came accross a post from a french user reporting javascript errors with the MODxHost template.

snip

Should this be added to default content and made available for the next release ?

Tested the fix and it does get rid of the debug errors, so I’ve submitted the fix to my personal branch in SVN, just needs merging with the main trunk.

As for the languange files, I’ve had no problems (so far) with running the Paul’s language files and I haven’t had any issues yet with the tree not displaying. Strange problem though - has this only been happening with the new lang files or was it there before?

Garry Nutting
Senior Developer
MODX, LLC

Email: [email protected]
Twitter: @garryn
Web: modx.com

☆ A M B ☆
24,524 Posts

sottwell Reply #36, 20 years ago

Every now and then, in all versions, if I start clicking on things while still in the middle of saving a document, the tree won’t load and I have to force a reload. It’s not consistant enough for me to figure out just what it is I do that chokes it. I don’t know if this is at all related, though.

Studying MODX in the desert - http://sottwell.com
Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
Join the Slack Community - http://modx.org

1,198 Posts

Nicola (Banzai) Reply #37, 20 years ago

Quote from: rthrash at Sep 29, 2006, 12:48 AM

......
[*] Table styles need to look congruent with the rest of the Light theme.
[*] Button icons for Light theme are a mis-mash of styles right now. Banzai, can you get a consistent set of them done (save.gif jumps out as an example)? I think the tree menu and menu-header look fine.
.....
[*] Synchronize the other two themes with all the manager changes.

-updated Light Manager (changed a lot of icons, fixed some background colours in tables)
-updated MODxGreen and MODx

- (optional) updated LightBlue theme

Free MODx Graphic resources and Templates www.tattoocms.it
-----------------------------------------------------

MODx IT www.modx.it
-----------------------------------------------------

bubuna.com - Web & Multimedia Design

7,075 Posts

davidm Reply #38, 20 years ago

Quote from: PaulGregory at Oct 01, 2006, 07:38 AM

That English file works fine for me in 1533 and 1557, on a Linux box viewed on Windows Firefox. Works in UTF-8 and iso-8859-1. MODxLight theme. I should point out that I have had the doc tree disappear on me in 1533 but I’ve not been able to figure out what made it do that. But I’ve not had any situation where everything loads but the doc tree. David, can you supply your ’fixed’ French file so I can see if it works on my setup? I really want to find out how to sort this.

Okay I’d rather it be me, as I said I am running an "old" rev1417 which was an updated 0.9.2.1 install to begin with, thus it might not be consistent... I am currently upgrading to rev1557 (beta4), to check if it solves it.

In the meantime, here are both utf-8 and ISO Latin1 version of the french language file.

@Banzai : thanks for the upgraded themes !
And by the way : awesome job on the Light and LightBlue theme
It’s blazing fast now !

I just spotted a small thing in The LightBlue theme: In Reports > Manager Actions the result of search is still styled with the MODxLight colors.

Edit : OK, I have upgraded to rev1557, it’s definitely not the english file but mine who’s causing trouble. I still can’t load the tree when I switch to french language file, I’ll do a comparison between the english and french file right now to sort this out. Probably something is wreaking havoc in there with the Document Tree.

Edit 2 : Did a quick check of System Events to get to the bottom of french language file issue, getting this error :

PHP error debug
  Error: 	filename: /home/nodeo/www/manager/includes/lang/francais.inc.php, exec_fname: /home/nodeo/www/assets/modules/quick_edit/output.class.inc.php, filepath: /home/nodeo/www/assets/modules/quick_edit//home/nodeo/www/manager/includes/lang/francais.inc.php	 
  Error type/ Nr.: 	Warning - 2	 
  File: 	/home/nodeo/www/assets/modules/quick_edit/output.class.inc.php	 
  Line: 	58	 
  Line 58 source: 	if(!$lang_set) { include_once($manager_lang_path); }

Anyone has an idea where I should start looking ?
It seems like a path issue with the QuickEdit include, am I wrong ?

~~I mean filepath sure shouldn’t be :~~
/home/nodeo/www/assets/modules/quick_edit//home/nodeo/www/manager/includes/lang/francais.inc.php

~~(Seems it get inserted twice...).~~

But why oh why should this happen with the french language file and not the english one ?
Would it be because of this line in the language file :

include_once(dirname(__FILE__).'/english.inc.php'); // fall back to English defaults if needed

Edit 3 : Forget about this, I think I found the culprit.
I examined the scripter.php file in manager/frames and as it turns out, my changing the simple quotes ( ’ ) for double quotes ( " ) to avoid having to escape single quote had the scripter no find the $_lang[’show_tree’] language variable since it’s $_lang["show_tree"] in my file.

I did not verify this yet but I am pretty sure that’s it.... I’ll revert to single quotes and post the appropriate language file

.: COO - Commerce Guys - Community Driven Innovation :.

MODx est l'outil id

7,075 Posts

davidm Reply #39, 20 years ago

My theory was correct, you can’t use double quotes in language files without wreaking havoc with the system...

I re-escaped all single quotes inside the language strings, removed the double quotes and it worked flawlessly, both in Latin1 and utf-8 version of the french file.

Before I post the definite file, I’ll submit the file to french beta testers to ensure nothing has been forgotten or badly translated tongue

Edit : Thanks to Aour found that the DocManager Module wasn’t translated.
There is a lang.en.php file in assets/modules/docmanager/lang, but it says

* IMPORTANT: By default, the module uses the MODx global language file.
* This file is included for reference, if you wish to use this file, then uncomment
* the language file include in the main Doc Manager module code.

The thing is, I didn’t find the DocManager language strings in the language file.
What do I do : create a lang.fr.php file in the assets/modules/docmanager/lang folder or add the strings to the language file ?

.: COO - Commerce Guys - Community Driven Innovation :.

MODx est l'outil id

1,097 Posts

PaulGregory Reply #40, 20 years ago

They *were* in the MODx global lang file, OpenGeek thought that was wrong, so now they’re not.
Please do create a lang.fr.php file.

I’m pleased that there’s now a working French file. Can you confirm that I’m safe getting people to use files like the one I supplied earlier (because issues can be fixed before they go into MODx) or should I change something in the way that they are generated before people do the translating?

No, I don't know what OpenGeek's saying half the time either.
MODx Documentation: The Wiki | My Wiki contributions | Main MODx Documentation
Forum: Where to post threads about add-ons | Forum Rules
Like MODx? donate (and/or share your resources)
Like me? See my Amazon wishlist
MODx "Most Promising CMS" - so appropriate!