We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
MODX Community Forums Archive

095 Home Stretch

    • 10487 MODX Staff
    • 1,535 Posts
    Garry Nutting Reply #41, 20 years ago
    The thing is, I didn’t find the DocManager language strings in the language file.
    What do I do : create a lang.fr.php file in the assets/modules/docmanager/lang folder or add the strings to the language file ?
    I did post a bit further up in the thread about this but I think it got lost in the discussions with the main language files - I’d be extremely grateful if you could do a french language file for the DocManager. smiley

    From revision 1578 of the MODx trunk in SVN, I have standardised the way that DocManager language files are named (they are now named the same as the main MODx language files) - this allows for the correct language file to be loaded automatically based on the user or system configuration settings.
      Garry Nutting
      Senior Developer
      MODX, LLC

      Email: [email protected]
      Twitter: @garryn
      Web: modx.com
      • 6726
      • 7,075 Posts
      davidm Reply #42, 20 years ago
      Quote from: PaulGregory at Oct 02, 2006, 04:35 AM
      They *were* in the MODx global lang file, OpenGeek thought that was wrong, so now they’re not. Please do create a lang.fr.php file. I’m pleased that there’s now a working French file. Can you confirm that I’m safe getting people to use files like the one I supplied earlier (because issues can be fixed before they go into MODx) or should I change something in the way that they are generated before people do the translating?

      No your file was not faulty, it really was me switching single quotes to double quotes that caused it all embarrassed
      The only thing we could gain out of this is, tell translators not to do the same thing I did...

      Quote from: garryn at Oct 02, 2006, 04:45 AM
      I did post a bit further up in the thread about this but I think it got lost in the discussions with the main language files - I’d be extremely grateful if you could do a french language file for the DocManager. smiley

      From revision 1578 of the MODx trunk in SVN, I have standardised the way that DocManager language files are named (they are now named the same as the main MODx language files) - this allows for the correct language file to be loaded automatically based on the user or system configuration settings.

      Ok thanks Garry for the infos. I’ll get the 1578 rev then and start from the updated language file to get down to work on the lang.fr.php file smiley DocManager is a pretty essential part of MODx now, I wouldn’t want french users left behind tongue


        .: COO - Commerce Guys - Community Driven Innovation :.

        MODx est l'outil id
        • 25663 MODX Staff
        • 12,272 Posts
        Ryan Thrash Reply #43, 19 years, 11 months ago
        I think we’re pretty safe to go public with the beta 4. Here’s a test build of the most recent stuff:

        http://modxcms.com/testbuilds/beta4-rev1588.zip

        The only thing that seems obvious to me is the missing icons in the lightblue (now plain old "MODx") theme, the fact that upgrades from 0921 don’t force-switch the manager theme to MODxLight and QE seems to have a fixed height on the dropdowns now.

        It’s time to button up that content at modx.it, which means updating Jot and the language files. Then we’ll be ready for our official RC stage (hopefully short lived).
          Ryan Thrash, MODX Co-Founder
          Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
          • 25663 MODX Staff
          • 12,272 Posts
          Ryan Thrash Reply #44, 19 years, 11 months ago
          Paul, David, et al,

          Please take a quick peek at this post (http://modxcms.com/forums/index.php/topic,7474.msg53428.html#msg53428) as it references some language files that should probably be added to the language files... it’s you folks call as to how to handle it (though I can’t really come up with an argument for NOT doing it).
            Ryan Thrash, MODX Co-Founder
            Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
            • 6726
            • 7,075 Posts
            davidm Reply #45, 19 years, 11 months ago
            Okay Ryan, duly noted. I’ll let Paul handle the english file, still have the DocManager module to translate.

            One thing I’ll do is hunt for remaining hardcoded strings here and there, easier to spot when switched to another language smiley
              .: COO - Commerce Guys - Community Driven Innovation :.

              MODx est l'outil id
              • 22815
              • 1,097 Posts
              PaulGregory Reply #46, 19 years, 11 months ago
              I have a reason not to include two of them - we already have
              $_lang['files_editfile'] = "Edit file";
$_lang['files_viewfile'] = "View file";

              and I’d rather reuse them instead of $_lang[’files_edit_file’] and $_lang[’files_view_file’].
              Delete file and Deleter folder are sensible additions though, and I’ll bung them in now.

              Can whoever is merging jaroslav’s changes in please use the existing langs, ie:
              $_lang["files_viewfile"] NOT $_lang[’file_view_file’]
              $_lang["files_editfile"] NOT $_lang[’file_edit_file’]
              $_lang["file_delete_file"] IS OK
              $_lang["file_delete_folder"] IS OK
                No, I don't know what OpenGeek's saying half the time either.
                MODx Documentation: The Wiki | My Wiki contributions | Main MODx Documentation
                Forum: Where to post threads about add-ons | Forum Rules
                Like MODx? donate (and/or share your resources)
                Like me? See my Amazon wishlist
                MODx "Most Promising CMS" - so appropriate!
                • 25663 MODX Staff
                • 12,272 Posts
                Ryan Thrash Reply #47, 19 years, 11 months ago
                What if we decide at a later date that we want to use different verbiage for those options though. Or we need a translation where the different contexts require subtly different words?
                  Ryan Thrash, MODX Co-Founder
                  Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
                  • 25663 MODX Staff
                  • 12,272 Posts
                  Ryan Thrash Reply #48, 19 years, 11 months ago
                  Other than minor inevitable tweaks, the only major outstanding issues are the default content and language files (I think). Anyone aware of other things that need to be addressed before our next public release, be it beta, rc or final?
                    Ryan Thrash, MODX Co-Founder
                    Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
                    • 22815
                    • 1,097 Posts
                    PaulGregory Reply #49, 19 years, 11 months ago
                    Quote from: rthrash at Oct 02, 2006, 05:18 PM

                    What if we decide at a later date that we want to use different verbiage for those options though.
                    Simple rule if you change verbiage at a later date, either you add a new lang file definition and retire the old one, or (as I’m having to do with this) you list the English that has changed between versions and ask the translators to review. I prefer the first option, as it caters better for the text being used elsewhere in the code, or in third-party modules. As I’ve said elsewhere, I’d like there to be a number of basic will-not-change sentences that can be used by all authors to greatly speed up usage in other languages.
                    Quote from: rthrash at Oct 02, 2006, 05:18 PM
                    Or we need a translation where the different contexts require subtly different words?
                    I can see that there may be places where the same English text has multiple meanings which would require multiple definitions in another language. Indeed, I hope that our translators can point these out where we miss them. But I don’t see how "Edit file" and "View file" meet that criteria. I don’t see why the headings of the pages are not valid text for the alt text of the button that gets you there. After all, it’s still an improvement on the current hardwired English!
                      No, I don't know what OpenGeek's saying half the time either.
                      MODx Documentation: The Wiki | My Wiki contributions | Main MODx Documentation
                      Forum: Where to post threads about add-ons | Forum Rules
                      Like MODx? donate (and/or share your resources)
                      Like me? See my Amazon wishlist
                      MODx "Most Promising CMS" - so appropriate!
                      • 15987
                      • 786 Posts
                      kjaebker Reply #50, 19 years, 11 months ago
                      I just commited the following:

                      Added ability to specify plugin run order. Incorporates a new screen similar to ajaxmenu index for determining the plugin run order per event. Added column priority to table site_plugin_events for this to work. I added one item to the language file as well.

                      If you want to include it in the next beta, everything is working. The only thing I haven’t resolved is how to get rid of the working message on the manager screen. I had to use a custom header due to some js conflicts not allowing the drag and drop to work, and so the working message never disappears.

                      But other than that everything seems to be functioning perfectly.

                      This discussion is closed to further replies. Keep calm and carry on.