095 Home Stretch

MODX Staff
12,272 Posts

Ryan Thrash Reply #21, 20 years ago

Decision: Band-Aid time.

I just commented out the mystery Sync functions/calls and removed the default content in the Loading/Working DIVs and now it works better. Safari gets a mysteriously blank topbar on initial load, but the other stuff works well. Safari users will have to live with a blank topbar on intial load for now.

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

MODX Staff
12,272 Posts

Ryan Thrash Reply #22, 20 years ago

’nother test build: http://modxcms.com/testbuilds/beta4-rev1557.zip

Fixes:
[*] addresses a corner case with databases with no passwords (local test environments)
[*] fix stuck "loading.../working..." messages on logging in in topbar
[*] nuke references to non-existant Javascript "Sync" function
[*] remove message count from topbar (accessible from home page)
[*] Fix JS warnings with modules accessed directly from modules menu

Known issues:
[*] Safari bug = blank topbar ONLY on initial login; go to another page or manual reload to fix it
[*] Needs a cleaned up/matching save.gif icon to match the others for Light theme
[*] Needs table styling finished for Light theme.
[*] Fixing the Modules JS warnings killed the Doc Manager... it’s getting double headers/html and body tags now.

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

MODX Staff
12,272 Posts

Ryan Thrash Reply #23, 20 years ago

I’ll be out Friday to mid-day Sunday so don’t expect much more from me during that time. In the interim, if someone could get a few things incorporated/cleaned up for the manager/content that’d be incredible (and committed/merged to trunk, too). Related to this, Tobyl just released eForm 1.3 with some really cool new features (it’s in the repository). I think we should invite him to update the default content contact form at http://modx.it/. Feel free to invite him to do so...

Will someone please get the following wrapped up, and install and run through in FF and in IE6? Hopefully all will be well and we can post another new public beta Sunday evening or Monday AM (GMT -600). This will hopefully be our last beta before posting RCs (which basically means content and translations are integrated with the installer):
[*] ~~Doc Manager needs repairing (sorry Garry!).~~
[*] ~~The manager pages are full of goofy-looking double-headlines. Someone please nuke the topmost ones where appropriate.~~
[*] ~~Table styles need to look congruent with the rest of the Light theme.~~
[*] ~~Button icons for Light theme are a mis-mash of styles right now. Banzai, can you get a consistent set of them done (save.gif jumps out as an example)? I think the tree menu and menu-header look fine.~~
[*] Make Quickedit module page use the selected Manager Theme styles.
[*] ~~Synchronize the other two themes with all the manager changes.~~

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

7,075 Posts

davidm Reply #24, 20 years ago

Quote from: PaulGregory at Sep 28, 2006, 09:18 PM

I can generate lang files now, and English is 20% smaller, but I can’t get the French encoding to work. I don’t know what I’m doing wrong but I’ll have to call it a night and look at it again in the morning. If someone could tell me exactly what encoding & charset that is supposed to be? Also, what setting do I need to have in MODx manager? Attached: working English and non-working French files.

I’ll give this a look ASAP. French has been encoded as ISO-8859-1 so far, but I’d like to have it use utf-8.

@Paul : Indeed there is a problem with the file encoding which is driving me nuts... I used TextWrangler to specify UTF-8 (with the No BOM option, TextMate doesn’t have it, that’s why I used TextWrangler) and UNIX line endings... but it gives me a blank screen... I have contacted Guillaume, who had posted a valid utf-8 french language file a while ago, to see if he could help me there.

The only thing no so good is using ’ instead of " since in french we have a lot of d’ and t’ and s’ which then have to be escaped with a backslash (not good, because you forget a backslash and bam, nothing works...). Would you have something against reverting to " ?

Anyway, I’ll get down to work on the strings not translated yet.
And I’ll test the translation on a 0.9.5 install and report.

Edit: translation is Work In Progress.

Fixed errors :
- fixed all instance of ModX -> MODx (Nicolas had it wrong, never noticed it...)

Some things are still way outdated in there :
- forums point toward vertexworks instead of current url ( $_lang["help_msg"] ) : fixed it in the french file

Some I wonder about :
- $_lang["credits_everaldo"] : will we still use those Crystal icons, if we drop the Eto theme in favor of LightBlue ?

- $_lang["php_version_check"] : we state requirement is PHP 4.0.3 or above... should that be updated ? I mean, isn’t this a typo... PHP 4.3.0 is the requirement, isn’t it ?

- $_lang["resolve_hostnames_message"]
$_lang["resolve_hostnames_title"]

Those are related to the now dropped built-in stats... should it remain here ?

-> Should those remain in the language file since we drop the stats ?

Other things :
- many instance of tags, I know we don’t care about validating the backend, but it’s not hard to run a search & replace to have those turned into strong tags. Same goes for instead of

.: COO - Commerce Guys - Community Driven Innovation :.

MODx est l'outil id

MODX Staff
1,535 Posts

Garry Nutting Reply #25, 20 years ago

The manager pages are full of goofy-looking double-headlines. Someone please nuke the topmost ones where appropriate.

I have the DocManager tweaks just about wrapped up so I’ll take this task if nobody else has already started on this.

Garry Nutting
Senior Developer
MODX, LLC

Email: [email protected]
Twitter: @garryn
Web: modx.com

1,097 Posts

PaulGregory Reply #26, 20 years ago

I’m not bothered whether it is = ’ or = ", and I’m hazy on the best practice there.

I agree that the Credits stuff needs changing. Frankly I think most credits should be hardwired in English. The headings should be translated, eg "Credits", "Theme Credits", "Translation Credits". And it’s neat to have the translation team credit in the lang file.

But if you reduce the main credits down to:

Icons: Jackie Wilson
Theme: Fred Elliot

with links etc, there’s not actually a big benefit in translating those parts. Better to make sure the credits are right.

And the hostnames bits must still be referenced somewhere. Basically I take out the lang files and extract out all the lang references in a particular build. The method I use does mean that if a reference is commented out, it’s still counted.

I could replace with if anyone really cares.

No, I don't know what OpenGeek's saying half the time either.
MODx Documentation: The Wiki | My Wiki contributions | Main MODx Documentation
Forum: Where to post threads about add-ons | Forum Rules
Like MODx? donate (and/or share your resources)
Like me? See my Amazon wishlist
MODx "Most Promising CMS" - so appropriate!

7,075 Posts

davidm Reply #27, 20 years ago

About the language file, I have tried all I know solving the problem with the french language file but there must be something in there which causes the blank page I get when I upload it. I contacted Guillaume, sent him the language file (which is done, by the way). He has some skills in that departement...

.: COO - Commerce Guys - Community Driven Innovation :.

MODx est l'outil id

MODX Staff
1,535 Posts

Garry Nutting Reply #28, 20 years ago

Just a quickie for all the translators we have in the team who may be working on MODx language file, would you be able to give the DocManager language file a glance over as well? It’d be great to have a set of language files distributable for the module as well.

On another note, I’ve put changes into SVN for the following items:

# Doc Manager needs repairing (sorry Garry!).
# The manager pages are full of goofy-looking double-headlines. Someone please nuke the topmost ones where appropriate.

Garry Nutting
Senior Developer
MODX, LLC

Email: [email protected]
Twitter: @garryn
Web: modx.com

7,075 Posts

davidm Reply #29, 20 years ago

OK guys, I have partially fixed the problem with the language file (thanks to TextMate for the syntax validation and php debug tools

)

I am saying partially because I no longer get a blank page, but a strange thing happens : when I upload the language file, the document tree doesn’t load anymore, it just hangs in there (? ? ?). I have tested this on a live rev1417 install (did not get a chance to upgrade it, maybe it explains...).

This also happens with Paul’s new english language file (can you confirm this ?).
I don’t know why it should happen, but if confirmed, this is not good huh

.: COO - Commerce Guys - Community Driven Innovation :.

MODx est l'outil id

7,075 Posts

davidm Reply #30, 20 years ago

I just came accross a post from a french user reporting javascript errors with the MODxHost template.

He spoted two js alert @line 58 and 64. He says when there is no submenu, the [tt]submenu[/tt] variable is not defined.

He suggest modifying the drop_down_menu.js code, more specifically the expand and collapse function :

 expand: function(event) {
  var submenu = this.findSubmenu(Event.element(event));
  if (submenu) {
   submenu.effect.clearTimer();
   submenu.effect.custom(submenu.effect.now, submenu.originalHeight);
  }
 },

 collapse: function(event) {
  var submenu = this.findSubmenu(Event.element(event));
  if (submenu) {
   submenu.effect.clearTimer();
   submenu.effect.custom(submenu.effect.now, 0);
  }
 }

Should this be added to default content and made available for the next release ?

.: COO - Commerce Guys - Community Driven Innovation :.

MODx est l'outil id