095 Home Stretch

7,075 Posts

davidm Reply #11, 20 years ago

Thanks Ryan

I should update the bug report, setlocale example there should be

setlocale(LC_TIME, ’fr’, ’fr_FR’, ’fr_FR.ISO8859-1’);

not

setlocale (LC_ALL, ’fr_FR’);

as stated earlier in this thread...

.: COO - Commerce Guys - Community Driven Innovation :.

MODx est l'outil id

MODX Staff
1,535 Posts

Garry Nutting Reply #12, 20 years ago

Did a fresh install of Beta 4 - looking good apart from a couple of issues with the top frames in the manager:

1. In FF (for mac), if the webelm scripter doesn’t clear itself properly, I lose the other the top frame (logout link etc.) - clicking around a few tabs etc. generally clears the problem and all is well again. Bit of a sporadic issue with that one.

2. In Safari, I can’t see any of the top frames (scripter and topbar), there is just a white space where they should be. (means I can’t logout)

3. Top menu shows with bold text in Safari, but in FF, it only shows bold on first load/refresh and clicking any of the tabs renders the text without bold being applied after that.

Garry Nutting
Senior Developer
MODX, LLC

Email: [email protected]
Twitter: @garryn
Web: modx.com

1,611 Posts

ZAP Reply #13, 20 years ago

If y’all don’t already have a team working on the Spanish language file I can help out with that.

If you’re trying to lighten the JavaScript load and are still considering tweaks to the new Light theme, then I might have a useful technique to share. I find that instead of using JavaScript to deal with applying the IE-specific filter to transparent background PNGs that a PHP-scripted CSS file works better. That way it’s all handled on the server-side and each browser gets just what they need.

This technique is only useful for transparent PNGs used as background images in CSS files, and I haven’t looked closely at the theme’s CSS to know if that’s a factor...

"Things are not what they appear to be; nor are they otherwise." - Buddha

"Well, gee, Buddha - that wasn't very helpful..." - ZAP

Useful MODx links: documentation | wiki | forum guidelines | bugs & requests | info you should include with your post | commercial support options

1,097 Posts

PaulGregory Reply #14, 20 years ago

I’m running through the language stuff based on rev 1553. Some oddities - two core modules have lang files as well has having lang definitions in the global MODx file:
assets/modules/docmanager/lang/lang.en.php
- this states that the module uses the MODx global language file unless something is commented out, so this is largely pointless. I can understand it being included with a Repo version, but not with it being included in the default MODx install.

assets/modules/quick_edit/lang/lang.en.php
- the first 9 definitions are in the MODx global lang file, but the following are not:

$_lang['document_opt_hide_menu'] = 'Hide in menu';
$_lang['revert'] = 'Revert';
$_lang['apply'] = 'Apply';
$_lang['revert_prompt'] = 'Undo ALL of your edits?';
$_lang['QE_no_edit_rights'] = 'No edit rights';
$_lang['ok'] = 'OK';
$_lang['setting'] = 'Settings';
$_lang['go'] = 'Go';

Should I move these too to the global file? (Part of that process is changing everything to $_lang[", incidentally).

Other than that, I reckon I’ll have the base files for translators in about an hour.

Included with the new language files will be a list of the strings that have been redefined between 0.9.2.1’s lang file and the current one, so that our international friends can retranslate them.

No, I don't know what OpenGeek's saying half the time either.
MODx Documentation: The Wiki | My Wiki contributions | Main MODx Documentation
Forum: Where to post threads about add-ons | Forum Rules
Like MODx? donate (and/or share your resources)
Like me? See my Amazon wishlist
MODx "Most Promising CMS" - so appropriate!

MODX Staff
10,725 Posts

opengeek Reply #15, 20 years ago

IMO, strings for translation that only apply to a module or plugin, or any add-on, should not be in the global language file. If people remove a module or plugin, why would we want them to have the overhead of loading unneeded translations?

Jason Coward
Chief Architect @ MODX
http://www.jasoncoward.com | http://twitter.com/drumshaman | https://github.com/opengeek

MODX Staff
1,535 Posts

Garry Nutting Reply #16, 20 years ago

2. In Safari, I can’t see any of the top frames (scripter and topbar), there is just a white space where they should be. (means I can’t logout)

Just further info on this one, it seems only happen when first logging in and hitting the refresh button 9 times out of 10 brings the frames back into the picture. After that, it seems to run the same as FF. (Latest Webkit build doesn’t suffer from the problem at all, anybody aware of any quirks in Safari that may cause this behaviour?)

IMO, strings for translation that only apply to a module or plugin, or any add-on, should not be in the global language file.

I see your point, I’ll change the DocManager module to use it’s own language file.

@Paul - Can you remove the language strings from the english lang file and I’ll update the DocManager code, seems pointless for me to update the english lang file as you’ll be updating it anyway.

Just on the DocManager module, there a few minor bugs that I’m working on that were picked up in the public beta thread. I should be able to get these committed tomorrow afternoon/evening.

Garry Nutting
Senior Developer
MODX, LLC

Email: [email protected]
Twitter: @garryn
Web: modx.com

1,097 Posts

PaulGregory Reply #17, 20 years ago

IMO, strings for translation that only apply to a module or plugin, or any add-on, should not be in the global language file.

Indeed, and those that apply to the core and to modules and plugins should be referencing the global language file.

I’d like to see a bunch of common phrases in the global language, and to have modules use them where possible. Things like "OK", "Apply", "Save", "Updated", "Delete". Then modules can leverage the fact that we have a bunch of people translating things.

Anyway, an update on the progress: There are more missing English definitions than I expected, and I need to sort out the UTF-8 issues, but I’m slogging away on it.

No, I don't know what OpenGeek's saying half the time either.
MODx Documentation: The Wiki | My Wiki contributions | Main MODx Documentation
Forum: Where to post threads about add-ons | Forum Rules
Like MODx? donate (and/or share your resources)
Like me? See my Amazon wishlist
MODx "Most Promising CMS" - so appropriate!

MODX Staff
12,272 Posts

Ryan Thrash Reply #18, 20 years ago

I’m gonna figure out and squish that blank page bug when initially logging in in Safari...

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

1,097 Posts

PaulGregory Reply #19, 20 years ago

I can generate lang files now, and English is 20% smaller, but I can’t get the French encoding to work. I don’t know what I’m doing wrong but I’ll have to call it a night and look at it again in the morning. If someone could tell me exactly what encoding & charset that is supposed to be? Also, what setting do I need to have in MODx manager?

Attached: working English and non-working French files.

No, I don't know what OpenGeek's saying half the time either.
MODx Documentation: The Wiki | My Wiki contributions | Main MODx Documentation
Forum: Where to post threads about add-ons | Forum Rules
Like MODx? donate (and/or share your resources)
Like me? See my Amazon wishlist
MODx "Most Promising CMS" - so appropriate!

MODX Staff
12,272 Posts

Ryan Thrash Reply #20, 20 years ago

Update on the stuck "working..." / "loading..." (aka, Uh Houston, we have a problem. ):

header.inc.php calls a non-existant JS function in the menu frame called Sync. I assumed it was supposed to refresh the tree, so I tried to make it do that by making a Sync function in the topbar that does just that in the scripter frame.

What happened next was a nightmare of cascading infinite loops on line 308 of webelm.js. I’m at a complete loss quite frankly. This is a major roadblock.

The "bug" of the missing Sync function is sadly what kept the manage working this entire time.

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me