0.9.5 Public Beta 3 support

1,611 Posts

ZAP Reply #41, 20 years ago

Quote from: rthrash at Sep 28, 2006, 10:42 AM

Quote from: ZAP at Sep 28, 2006, 10:41 AM

Question: When did the themplate creator/editor begin using the RTE? That seems kind of a bad idea to me. I had to turn off the RTE altogether in order to be able to edit everything in my template that wasn’t between the <body> tags (switching the editor below the content window to "None" only shows you that portion of the template code).

Fix was already committed for that last night.

Y’all work fast! I was worried that some people actually LIKED it this way. I was trying to figure out how the RTE might be useful there, but I hadn’t thought of anything.

I’m still not convinced by TinyMCE either. I’ll keep using it for a while before I make a final judgement, but so far I prefer FCK. I recently switched two old sites that were working fine with Etomite over to MODx 0.9.2.1 just to switch them to FCK (well... and in case they need more work later).

I know that some folks complain that FCK messes up their code, but I don’t think it’s so bad. It definitely massacres inline style declarations (and makes them upper-case, for no good reason), but that just reminds me to put those styles in the stylesheet. And sometimes it’s not very nice to JavaScript, but that should be in a chunk anyway.

It is by far the friendliest editor, which is something that my clients really appreciate. I set the toolbar to the limited buttons that they should be using and give it a preview stylesheet and everyone’s happy. On balance, I’ve always felt that FCK’s flaws were minor and would probably be improved over time (or perhaps if I cared enough to investigate how to correct them), whereas TinyMCE just seems more clunky to me.

But like I said, I am gonna use it some more before I decide to abandon it...

"Things are not what they appear to be; nor are they otherwise." - Buddha

"Well, gee, Buddha - that wasn't very helpful..." - ZAP

Useful MODx links: documentation | wiki | forum guidelines | bugs & requests | info you should include with your post | commercial support options

30 Posts

StainlessSteelRat Reply #42, 20 years ago

Quote from: jaroslav at Sep 28, 2006, 10:48 AM

@StainlessSteelRat: what version of Internet Explorer and Firefox you are using (IE 6.0, IE 6.1, IE6.?, IE7.?, FF 1.5, FF 1.?)?

EDIT: I got an idea on your problem. Screenshots are from some site with custom CSS, not the default one from installation of "simple content" of 0.9.5 beta’s. So, check your site’s CSS, possibly it redefines some of instructions in fixed QuickEdit’s toolbar.css file.

jaroslav... that’s FF 1.5.07 and IE 6.0.2900. I’ll look into whether my site’s CSS is stepping on the toolbar’s CSS. Unlikely, though, since the toolbar.css is loaded after my site CSS. If anything, it would screw up my site, not the other way around. Isn’t that true? (Hence the ’C’ in CSS, unless I’m totally wrong. Which is often the case. undecided

)

59 Posts

milicicd Reply #43, 20 years ago

In beta2 (rev. 1417), disabling QuickEdit module in Module Manager produces no result - QuickEdit still appears on public if I am logged into Manager.
Can someone check this in Beta3?

1,611 Posts

ZAP Reply #44, 20 years ago

Quote from: milicicd at Sep 28, 2006, 11:17 AM

In beta2 (rev. 1417), disabling QuickEdit module in Module Manager produces no result - QuickEdit still appears on public if I am logged into Manager.
Can someone check this in Beta3?

I believe you also need to disable the QE Plugin. That’s the code that creates the front-end menus. I have always disabled both of those (or just not installed QuickEdit at all).

"Things are not what they appear to be; nor are they otherwise." - Buddha

"Well, gee, Buddha - that wasn't very helpful..." - ZAP

Useful MODx links: documentation | wiki | forum guidelines | bugs & requests | info you should include with your post | commercial support options

31 Posts

jaroslav Reply #45, 20 years ago

@StainlessSteelRat:

I do not have your version of IE (my IE is 6.0.2600.0000), but my FF is 1.5.07, and it performs with fix OK. So I don’t think it is a browser specific issue, it is definitely some CSS conflict. I agree, that sounds strange if QuickEdit’s CSS is included after others, but "change the minus to underscore, and it will work" also is very strange bug fix wink

238 Posts

Si Reply #46, 20 years ago

I have a problem with the manager.

If I go to templates in resorces and try to edit them the tinyMCE appears!... this is a step back the the production of MODx!... The reason go to edit the templates is to edit the raw HTML!

I tried clicking the HTML button on the TinyMCE but the window that opens just shows a few lines of strange code.

Please show the template editting window as raw code again!

Web Development, Web Hosting & Search Engine Marketing by:

Vitalized | UK
w. www.vitalized.co.uk

Website Design | Search Engine Marketing (SEM) | UK MODx web hosting, secure, fast & 100% MODx compatible

Vitalized | Australia
w. www.vitalized-australia.com.au

Website Design | Search Engine Marketing (SEM) | Australian MODx web hosting, secure, fast & 100% MODx compatible

MODX Staff
1,535 Posts

Garry Nutting Reply #47, 20 years ago

If I go to templates in resorces and try to edit them the tinyMCE appears!... this is a step back the the production of MODx!... The reason go to edit the templates is to edit the raw HTML!

This issue has already been fixed in the SVN. The RTE code has been completely removed from the templates section.

Garry Nutting
Senior Developer
MODX, LLC

Email: [email protected]
Twitter: @garryn
Web: modx.com

238 Posts

Si Reply #48, 20 years ago

Quote from: garryn at Sep 29, 2006, 04:16 AM

If I go to templates in resorces and try to edit them the tinyMCE appears!... this is a step back the the production of MODx!... The reason go to edit the templates is to edit the raw HTML!
This issue has already been fixed in the SVN. The RTE code has been completely removed from the templates section.

What do you mean by SVN!!!!... I’m currently using Beta 3 (rev 1533) 27-9-06 version... It’s the lasest version isn’t it?

Web Development, Web Hosting & Search Engine Marketing by:

Vitalized | UK
w. www.vitalized.co.uk

Website Design | Search Engine Marketing (SEM) | UK MODx web hosting, secure, fast & 100% MODx compatible

Vitalized | Australia
w. www.vitalized-australia.com.au

Website Design | Search Engine Marketing (SEM) | Australian MODx web hosting, secure, fast & 100% MODx compatible

MODX Staff
1,535 Posts

Garry Nutting Reply #49, 20 years ago

SVN is our version control system that manages the team’s additions to the core code - if you grab yourself a SVN client (TurtoiseSVN for example) then you can check out the latest code changes (see this thread for Public SVN Access instructions.)

There will also be another beta out soon as well.

Garry Nutting
Senior Developer
MODX, LLC

Email: [email protected]
Twitter: @garryn
Web: modx.com

31 Posts

jaroslav Reply #50, 20 years ago

Hi guys!

I got recently from SVN 0.9.5 beta 4 (rev 1557), it contains now my QuickEdit fixes for IE 6.0.
But ... fixes in SVN does not work! shocked

First, the QuickEdit.js file is only "partly" fixed. As I wrote in some previous post, for working "Edit content" buttons one need to change the "minus" characters to underscores "_" in one javascript function. But in the file commited to SVN only first of two "minuses" is changed. IE 6.0 will be happy only if both "minuses" in that javascript function will be changed! wink

Attachment to this post contains QuickEdit.js taken from rev 1557 and properly changed, so it may be merged to SVN securely. I ask developers team to merge it.

Secondly, I also attached toolbar.css taken from rev 1557 and slightly modified by me. My changes are mostly cosmetic to improve visually the QuickEdit toolbar in IE 6.0. Other browsers will not be affected, so I ask developers team to merge this slightly modified version in SVN also.