0.9.5 Public Beta 3 support

• • 
  • 31 Posts
  jaroslav Reply #31, 20 years ago

  Hi all!
  
  I found fix for QuickEdit toolbar problem in IE 6.0
  
  In 0.9.5 beta’s (all) javascript and css for browser-based QuickEdit controls are significantly different from 0.9.2. Also significantly different is XHTML code generated by PHP libraries. JS code now is massively based on prototype.js and moo.fx.js libraries, and it is more clean and object-oriented than in 0.9.2. And the XHTML code is more clean and better. So I decided to fix only CSS if it will be possible. It seems to be possible 
  
  Attached file is fixed toolbar.css from assets/modules/quick_edit/styles/ folder. It is tested by me in IE 6.0 and Firefox 1.5.1. I propose someone to test this fix in other browsers (Mozilla, Safari, etc.) - if the things will be OK, I ask MODx developers to add the fix in SVN.
  
  P.S. To fix a problem with non-functioning "Edit content" buttons, read my previous post: Quote from: jaroslav at Sep 27, 2006, 09:36 AM

  
  In assets/modules/quick_edit/javascript/QuickEdit.js "name" parameter of "open" method of "QuickEdit" class is constructed as

  var name = 'QuickEditor-'+this.pageID+'-'+contentID;

  Change "minus" characters to "_" (underscore), and it will work.
  
• • 
  • 31 Posts
  jaroslav Reply #32, 20 years ago

  Quote from: jaroslav at Sep 28, 2006, 09:07 AM

  
  I found fix for QuickEdit toolbar problem in IE 6.0
  <...>
  It is tested by me in IE 6.0 and Firefox 1.5.1.
  

  
  Now I tested it on Opera 9.0.1 in "Identify as Internet Explorer" mode: QuickEdit toolbar with fixed CSS performs OK.
  
  But TinyMCE does not... So I ask if someone know any WYSIWYG DHTML editor that works in Opera (possibly in IE compatibility mode)?
• • 
  • 30 Posts
  StainlessSteelRat Reply #33, 20 years ago

  I’m getting the same problem, with the blank QE toolbar and the missing dropdowns in both IE6 and FF. (I’ve attached screenies from both.) The’s the toolbar in the upper-right, just below the search box.
  
  Everything else on the (front-end) site seems unchanged, with the exception of a considerably shorter loading times.
• • 
  • 31 Posts
  jaroslav Reply #34, 20 years ago

  Quote from: StainlessSteelRat at Sep 28, 2006, 10:19 AM

  
  I’m getting the same problem, with the blank QE toolbar and the missing dropdowns in both IE6 and FF.
  

  
  Do you replaced toolbar.css with my fixed version or not? And if the CSS is from my post, got you the same problem earlier, before applying the fix?
  
  Also, what version of "IE6" and Firefox you are using (IE 6.0, IE 6.1, ..?, FF 1.5, FF 1.?)
• • MODX Staff
  • 12,272 Posts
  Ryan Thrash Reply #35, 20 years ago

  jaroslav,
  
  Thanks for digging into the QE issue. I’ve been testing and tweaking a bit and I think it’s just about right on; expect a committ soon. Great work!
  Ryan Thrash, MODX Co-Founder
  Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
• • 
  • 30 Posts
  StainlessSteelRat Reply #36, 20 years ago

  I forgot to mention that! Yes, I used the new toolbar.css file and made the ’underscore’ change to the QuickEdit.js file BEFORE those screenshots. (And cleared the cache.)
• • 
  • 1,611 Posts
  ZAP Reply #37, 20 years ago

  Question: When did the template creator/editor begin using the RTE? That seems kind of a bad idea to me. I had to turn off the RTE altogether in order to be able to edit everything in my template that wasn’t between the <body> tags (switching the editor below the content window to "None" only shows you that portion of the template code).
  "Things are not what they appear to be; nor are they otherwise." - Buddha
  
  "Well, gee, Buddha - that wasn&#39;t very helpful..." - ZAP
  
  Useful MODx links: documentation | wiki | forum guidelines | bugs & requests | info you should include with your post | commercial support options
• • 
  • 30 Posts
  StainlessSteelRat Reply #38, 20 years ago

  In case I wasn’t clear... the new toolbar.css and QuickEdit.js changes didn’t seem to do anything. Same result before and after...
• • MODX Staff
  • 12,272 Posts
  Ryan Thrash Reply #39, 20 years ago

  Quote from: ZAP at Sep 28, 2006, 10:41 AM

  
  Question: When did the themplate creator/editor begin using the RTE? That seems kind of a bad idea to me. I had to turn off the RTE altogether in order to be able to edit everything in my template that wasn’t between the <body> tags (switching the editor below the content window to "None" only shows you that portion of the template code).
  

  Fix was already committed for that last night.
  Ryan Thrash, MODX Co-Founder
  Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
• • 
  • 31 Posts
  jaroslav Reply #40, 20 years ago

  @StainlessSteelRat: what version of Internet Explorer and Firefox you are using (IE 6.0, IE 6.1, IE6.?, IE7.?, FF 1.5, FF 1.?)?
  
  EDIT: I got an idea on your problem. Screenshots are from some site with custom CSS, not the default one from installation of "simple content" of 0.9.5 beta’s. So, check your site’s CSS, possibly it redefines some of instructions in fixed QuickEdit’s toolbar.css file.

This discussion is closed to further replies. Keep calm and carry on.