WebLoginPE v1.3.1 Bugfix (Released August 5th!)

Quote from: rthrash at Jun 25, 2008, 03:10 PM

You’d need to assign a CSS class to each error container, but I don’t think the if/case would generate much overhead.

Basically, I would have an if/elseif/else that would add the CSS class "success", "error", or "message".

Looking at it again, I might be able to switch it from $wlpe_lang to $error, $success, and $message, and edit the class file accordingly...I’ll have to tinker with it when I have more time.

Quote from: Soshite at Jun 25, 2008, 07:30 AM

x_x...Sorry I haven’t been able to fix the "bugs" lately...life’s been hectic lately.

I dunno if I’ll have time for this for the v1.3.1 release, or if it’ll have to be done in a v1.3.2 release, but I thought of a great idea last night...

Currently, all of the WLPE "messages" can be styled, but since they all come from one lang file, you can’t style an error message differently from a success or just your average, normal message. I was thinking of splitting the lang file into three different files --- one for errors (red), one for successes (green), and one for normal messages (gray?). I would also implement some PHP checking to output the "coloring" of the message, depending on it’s status.

What do you guys think? I think this could help differentiate the errors the users get more easily, since they can see at a glance what kind of message it was.

Hi Soshite,

I think there’s one more useful addition that would make sense for a 1.3.1 official release and we can just wrap up what’s been done to date and call it a release. The addition of pagination to the user list just makes too much sense to me right now for larger installs. Search/filtering would be great as well but that gets more involved (1.3.2 maybe?). Would you like some assistance in implementing this into the current 1.3.1 codebase? (see http://modxcms.com/forums/index.php/topic,20396.0.html for more reference on the pagination).

It’d also be cool to see a fresh updated list of enhancements and bugfixes for WLPE that might make sense for future releases if you’ve got a log available, as well as a full list of fixes/patches applied.

Quote from: rthrash at Jul 08, 2008, 08:44 AM

It’d also be cool to see a fresh updated list of enhancements and bugfixes for WLPE that might make sense for future releases if you’ve got a log available, as well as a full list of fixes/patches applied.

The first post has the list of the bug fixes from the first two betas, IIRC. Beta 3 just fixed that one issue and implemented the user avatar resizing, IIRC.

I did that on purpose so in case one of the fixes messed something up, I had a reference to find it. And with the tons of fixes, it’s a necessity.

Getting a parse error when updating a profile.

PHP error debug
Error: htmlentities() [function.htmlentities]: charset `"UTF-8"’ not supported, assuming iso-8859-1
Error type/ Nr.: Warning - 2
File: /var/www/web74/web/assets/snippets/webloginpe/webloginpe.class.php
Line: 947
Line 947 source: $extendedFieldValues[$field] = $modx->db->escape(stripslashes(htmlentities(trim($_POST[$field]), ENT_QUOTES,$charset)));

Hmmmm...

Quote from: danielw at Jul 14, 2008, 04:58 AM

Getting a parse error when updating a profile.

PHP error debug
Error: htmlentities() [function.htmlentities]: charset `"UTF-8"’ not supported, assuming iso-8859-1
Error type/ Nr.: Warning - 2
File: /var/www/web74/web/assets/snippets/webloginpe/webloginpe.class.php
Line: 947
Line 947 source: $extendedFieldValues[$field] = $modx->db->escape(stripslashes(htmlentities(trim($_POST[$field]), ENT_QUOTES,$charset)));

Hmmmm...

I bet that’s one of the UTF-8 fixes I made...x_x

What version of PHP was that? It’s supposed to support UTF-8 since 4.3
http://www.php.net/htmlentities

PHP 5.x

That should not be a problem, right?

The trouble is in bracers. Must be UTF-8, not "UTF-8"

Here

$charset=’"’.$modx->config[’modx_charset’].’"’;
$extendedFieldValues[$field] = $modx->db->escape(stripslashes(htmlentities(trim($_POST[$field]), ENT_QUOTES,$charset)));

must be simply

$extendedFieldValues[$field] = $modx->db->escape(stripslashes(htmlentities(trim($_POST[$field]), ENT_QUOTES,$modx->config[’modx_charset’])));

or change this:
$charset=’"’.$modx->config[’modx_charset’].’"’;
to this:
$charset=$modx->config[’modx_charset’];

BETA 4 has been released! 

This includes all of the recent bugfixes, as well as vhollo’s image resizing fix. This will be the RTM if no show-stopping bugs are found. Note this doesn’t include the pagenation hack --- that’s for v1.3.2.