WebLoginPE v1.3.1 Bugfix (Released August 5th!)

Gah...

I’ll do a quick search for these double values. Notepad++ has been acting up on the latest versions, but I didn’t know it was doing that. x_x

I’ll get an updated version up in a few minutes.

EDIT: And now it should be updated.

BTW, for those that have better PHP knowledge, there’s a few bug fixes that I didn’t know how to implement, so if you guys could help me out on that, I’d be grateful. It should be documented as to which bugs are still outstanding.

In function ViewAllUsers, line 1306:

and function PlaceHolders, line 1840:


Shouldn’t the ’%m-%d-%Y’ have been changed to $this->DateFormat in order to format the date the way users set it to?
Of course in this case it’s better set the &dateFormat to something rather than to let the snippet use the default value of ’%A %B %d, %Y at %I:%M %p’ since a birth date with Hours:Minutes:Seconds look stupid...

IIRC, I swore I remember seeing Scotty talk about why that was like that in the v1.3.x releases. Maybe due to how he coded that part of the script.

Although that might be a good idea to look into that as a small fix for a v1.3.2 release (since v1.3.1 is purely bugfix-only, unless something new is essential to include).

BTW, I’m going to run this on my website. Hopefully things will go well.

« MODx Parse Error »MODx encountered the following error while attempting to parse the requested resource:
« PHP Parse Error »

PHP error debug
  Error: move_uploaded_file(/hsphere/local/home/symphoni/symphonicheaven.com/wilhelm.png): failed to open stream: Permission denied
  Error type/ Nr.: Warning - 2
  File: /hsphere/local/home/symphoni/symphonicheaven.com/assets/snippets/webloginpe/webloginpe.class.php
  Line: 2525
  Line 2525 source: if (!move_uploaded_file($_FILES[’photo’][’tmp_name’], $userImage))

Parser timing
  MySQL: 0.0246 s (27 Requests)
  PHP: 0.4049 s
  Total: 0.4295 s

I got that error when trying to upload a avatar. For some reason, it’s messing up the path. Was this a bug I missed, or a goof I made?

EDIT: I also noticed a quirk on some servers (namely mine). When including the lang file, it seems include_once doesn’t work, and I had to rename it to include. Is there an issue there?

Quote from: vhollo at May 22, 2008, 12:26 PM

In function ViewAllUsers, line 1306:

$value = strftime('%m-%d-%Y', $value);

and function PlaceHolders, line 1840:

$value==0?'':$modx->setPlaceholder('user.'.$key, strftime('%m-%d-%Y', $value));

Shouldn’t the ’%m-%d-%Y’ have been changed to $this->DateFormat in order to format the date the way users set it to?
Of course in this case it’s better set the &dateFormat to something rather than to let the snippet use the default value of ’%A %B %d, %Y at %I:%M %p’ since a birth date with Hours:Minutes:Seconds look stupid...

Quote from: Soshite at May 22, 2008, 12:41 PM

IIRC, I swore I remember seeing Scotty talk about why that was like that in the v1.3.x releases. Maybe due to how he coded that part of the script.

Although that might be a good idea to look into that as a small fix for a v1.3.2 release (since v1.3.1 is purely bugfix-only, unless something new is essential to include).

BTW, I’m going to run this on my website. Hopefully things will go well.

You might be right: in cases the displayed date is being posted again that’s right to show it in the original ’%m-%d-%Y’ format as it’s going to be parsed by the snippet and will be saved. In cases the date will only be showed, ’$this->DateFormat’ will be OK.
So one would check each appearance in the class.
One I found must leave is line 1353:
$modx->setPlaceholder(’view.dob’, strftime(’%m-%d-%Y’, $viewUser[’dob’]));
because this one is showing on the edit form of manager mode.

Nice work, Wil was looking foorward for this
We will test and report back

Bug found: path to user photo is deleted when saving profile.

In webloginpe.class.php near


need to add {} bracers

I bet that was what was causing the issues I encountered before.

BTW, does something with more PHP knowledge know why the "default" user fields get deleted, even if they aren’t included.

I have special WLPE calls in the "consoles" pages of my website, which adds a game to the user’s collection/wishlist (obviously, extended WLPE fields). I had to pass the "default" fields (username, etc.) via type="hidden" fields to get it to not overwrite the data...

BETA 3 has been released. This fixes the user avatar issue, and applies a new method to cropping user avatars, instead of changing their dimensions.

For some reason on my edit details page and logged in screen, the default avatar image is showing up as a missing image.... but works if you upload an image on registration. Also after signing up and try to save any updates via the profile update I get this error.



I have downloaded the latest versions on loginPE

Thanks