WebLoginPE v1.3.1 Bugfix (Released August 5th!)

925 Posts

Soshite Reply #21, 18 years, 3 months ago

I have a feeling this was due to the (partial) UTF-8 fixes I applied. I’m busy ATM, but if no one else finds it, I’ll try to track down the issue. wink

My Snippets
-> PopUpChunk v1.0

206 Posts

vhollo Reply #22, 18 years, 3 months ago

Quote from: Soshite at May 27, 2008, 09:56 AM

BETA 3 has been released. This fixes the user avatar issue, and applies a new method to cropping user avatars, instead of changing their dimensions.

Hi!
The new method for image resize is working good for cropping.
I show an other solution that is working better than the 1.30’s code for resizing. From line 1554::

		$wm = $width / $new_width;
		$hm = $height / $new_height;
		if ($wm > 1 || $hm > 1) // (don't magnify a smaller image)
		{
			if ($wm > $hm) $new_height = $height / $wm;
			else $new_width = $width / $hm;
		}
		else { $new_width = $width; $new_height = $height; } // (must set the original size)

This new code will resize the image only in case it exceeds either the horizontal or vertical limit.
And as opposed to the 1.30’s code, this will not distort it, but only scale.

1,215 Posts

Metaller Reply #23, 18 years, 3 months ago

It was my idea about cropping images and my code. I’ll test it again.

DirectResize 0.9 beta. PHPThumb, sets of configurations, configuration, binded to specific path. No backward compatibility. | DirectResize 0.9. PHPThumb, наборы параметров, параметры, привязанные к определенным путям. Без обратной совместимости.

Unfortunately, DirectResize project is closed. If you want to continue development, PM me for access to project page on Google Code. К сожалению, проект DirectResize закрыт. Если вы желаете продолжить разработки, обращайтесь через ПМ для получения доступа к репозиторию на Google Code.

[PLUGIN] DirectResize - as Maxigallery but for single images :: Download :: [url=http://modxcms.com/forums/index.php/topic,21490]

206 Posts

vhollo Reply #24, 18 years, 3 months ago

Yes, I’m sorry, Metaller! Your code really does the job. I’m gonna edit my last post...
Anyway yours is a strange but working solution. grin

MODX Staff
1,535 Posts

Garry Nutting Reply #25, 18 years, 3 months ago

I found an issue with IE6 and the way that WebLoginPE does the header redirect refreshes. In the snippet code, the refreshes in a few places are done like this (using a relative URI):

$url = $modx->makeURL($regSuccessId);
header('Refresh: '.$regSuccessPause.';'.$url);

This causes IE6 to not correctly redirect the page, the fix is to use the absolute URI in the redirect:

$url = rtrim($modx->config['site_url'], '/').$modx->makeURL($regSuccessId);
header('Refresh: '.$regSuccessPause.';URL='.$url);

I’ve spotted a couple of places in the snippet where this will need patching up.

Garry Nutting
Senior Developer
MODX, LLC

Email: [email protected]
Twitter: @garryn
Web: modx.com

925 Posts

Soshite Reply #26, 18 years, 3 months ago

If someone wants to patch it and attach it to one of your posts, I’ll apply that to my "master" file and reupload it to the first post.

I’m having to do a huge server move on my website, so I can’t do it ATM.

My Snippets
-> PopUpChunk v1.0

925 Posts

Soshite Reply #27, 18 years, 3 months ago

x_x...Sorry I haven’t been able to fix the "bugs" lately...life’s been hectic lately.

I dunno if I’ll have time for this for the v1.3.1 release, or if it’ll have to be done in a v1.3.2 release, but I thought of a great idea last night...

Currently, all of the WLPE "messages" can be styled, but since they all come from one lang file, you can’t style an error message differently from a success or just your average, normal message. I was thinking of splitting the lang file into three different files --- one for errors (red), one for successes (green), and one for normal messages (gray?). I would also implement some PHP checking to output the "coloring" of the message, depending on it’s status.

What do you guys think? I think this could help differentiate the errors the users get more easily, since they can see at a glance what kind of message it was.

My Snippets
-> PopUpChunk v1.0

MODX Staff
12,272 Posts

Ryan Thrash Reply #28, 18 years, 3 months ago

What about just using a default message class for each type of message, and hang the styling off of that, rather than splitting all the languages up? You could override the classes with a parameter in your call/config of course.

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

925 Posts

Soshite Reply #29, 18 years, 3 months ago

Quote from: rthrash at Jun 25, 2008, 08:42 AM

What about just using a default message class for each type of message, and hang the styling off of that, rather than splitting all the languages up? You could override the classes with a parameter in your call/config of course.

But wouldn’t that require having class calls for every single error that could come up (adding a lot of extra stuff to the WLPE call)?

Maybe I’m not understanding your post correctly...

My Snippets
-> PopUpChunk v1.0

MODX Staff
12,272 Posts

Ryan Thrash Reply #30, 18 years, 3 months ago

You’d need to assign a CSS class to each error container, but I don’t think the if/case would generate much overhead.

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me