WebLoginPE v1.3.1 Bugfix (Released August 5th!)

925 Posts

Soshite Reply #1, 18 years, 4 months ago

http://modxcms.com/WebLoginPE-1.3.1-2142.html

IT’S RELEASED! laugh

My Snippets
-> PopUpChunk v1.0

MODX Staff
12,272 Posts

Ryan Thrash Reply #2, 18 years, 4 months ago

Thank you Soshite ... we’ll start testing soon on this end ... wow what a log of updates!

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

925 Posts

Soshite Reply #3, 18 years, 4 months ago

Quote from: rthrash at May 21, 2008, 09:47 AM

Thank you Soshite ... we’ll start testing soon on this end ... wow what a log of updates!

Most of these were mainly misspellings, or unforeseen issues like the rare UTF-8 stuff. Only a few were critical ones (basically the ones pixelchutes posted xd). tongue

Thank goodness there wasn’t nothing that completely brought down the script (well, save that user corrupting issue, if you happened to have a user put specific stuff in there). wink

EDIT: I forgot to mention that I am planning on using that JS IE fix pixelchutes posted in the Bug Reports topic in the final v1.3.1 release. IIRC, that was solely an IE fix, so I’ll need to make up documentation to apply it just for that browser. The "normal" JS file was fine for other browsers, right, or was pixel’s JS for every browser?

Also, I’ll be adding documentation on a rare absolute lang path issue (where the user needs to direct WLPE to the the file directly, instead of through MODx) that will stop the lang strings from appear at all, as well as a workaround to get checkboxes to control images (until v1.4.0 is released, where Scotty will add HTML capability for form fields) --- this is useful in getting badges, achievements, etc. for your WLPE install. Lastly, I’ll have documentation reminding people about which form fields needs to passed in when you have a "minimal" form (such as just a checkbox for certain data, outside of the normal profile editor) --- else WLPE "nukes" everything --- although I think pixelchutes might have fixed this bug, so I’ll have to test and see if that’s still the case. wink

My Snippets
-> PopUpChunk v1.0

358 Posts

Uncle68 Reply #4, 18 years, 4 months ago

Wow, there must be a lot of work fixing all that! Would almost been easier to write a completely new snippet! tongue

That "rare UTF-8 stuff" is very important if using a non-english language as many of us do.

I’ll set up e fresh install and start testing it asap!

:)

154 Posts

SimonMW Reply #5, 18 years, 4 months ago

Thanks Soshite! I’ll upload this one to my site in progress and give it a go cool

It is a shame that Scotty isn’t actively developing this any more though. sad

Of all the Modx snippets this one had the most potential to help make very social networking style Modx websites out of the box so to speak.

154 Posts

SimonMW Reply #6, 18 years, 4 months ago

Okay, first issue I have found.

When I log in using the snippet I get a parser error

« MODx Parse Error »

MODx encountered the following error while attempting to parse the requested resource:
« PHP Parse Error »

PHP error debug
Error: Object of class DocumentParser could not be converted to string
Error type/ Nr.: - 4096
File: /homepages/37/d150733502/htdocs/coolactiv/assets/snippets/webloginpe/webloginpe.class.php
Line: 2147
Line 2147 source: $$modx->sendRedirect($url,0,’REDIRECT_HEADER’); // CREDIT: Guillaume to redirect directely

Parser timing
MySQL: 0.1080 s (19 Requests)
PHP: 0.3706 s
Total: 0.4786 s

When I click the ’back’ button in the browser after seeing this message I find that I have been logged in. But if I click to log out I get that parser error again.

70 Posts

mbrinson Reply #7, 18 years, 4 months ago

Probably the extra ’$’ in $$modx->.... No?

Line 2147 source:    $$modx->sendRedirect($url,0,'REDIRECT_HEADER'); // CREDIT: Guillaume to redirect directely

925 Posts

Soshite Reply #8, 18 years, 4 months ago

Quote from: mbrinson at May 21, 2008, 12:29 PM

Probably the extra ’$’ in $$modx->.... No?

Line 2147 source:    $$modx->sendRedirect($url,0,'REDIRECT_HEADER'); // CREDIT: Guillaume to redirect directely

Gah...stupid copy & paste. tongue

I bet that’s likely it. I don’t have the time ATM, but I’ll reupload a "fixed" version if that was the case.

My Snippets
-> PopUpChunk v1.0

70 Posts

jacobkball Reply #9, 18 years, 4 months ago

Actually, this whole section needs to be fixed, as far as I can see:

		if (!empty($this->liHomeId))
		{
			if (is_array($this->liHomeId))
			{
				foreach($this->liHomeId as $id)
				{
		            $id = trim($id);
		            if ($modx->getPageInfo($id))
						{
							$url = $modx->makeURL($id);
					        $$modx->sendRedirect($url,0,'REDIRECT_HEADER'); // CREDIT: Guillaume to redirect directely
					        return;
						}
		        }
			}
			else 
			{
				$url = $modx->makeURL($this->loHomeId);
		        $$modx->sendRedirect($url,0,'REDIRECT_HEADER'); // CREDIT: Guillaume to redirect directely
		        return;
			}
		}
		else
		{
			$url = $modx->makeURL($modx->documentIdentifier);
	        $$modx->sendRedirect($url,0,'REDIRECT_HEADER'); // CREDIT: Guillaume to redirect directely
		}

as there are three instances of the $$ - mine crashed on Line 2162.

70 Posts

jacobkball Reply #10, 18 years, 4 months ago

Oh, and in the next function down LogoutHomePage:

		if (!empty($this->loHomeId))
		{
			$url = $modx->makeURL($this->loHomeId);
	 		$$modx->sendRedirect($url,0,'REDIRECT_HEADER'); // CREDIT: Guillaume to redirect directely
	        return;
		}
		else
		{
			$url = $modx->makeURL($modx->documentIdentifier);
	        	$$modx->sendRedirect($url,0,'REDIRECT_HEADER'); // CREDIT: Guillaume to redirect directely
		}