[Template Manager] MODxGreen

OK, here are the results for the MODxBlack-beta2 theme.
The server log says this:

File does not exist: modx/manager/media/style/MODxBlack/images/tree/page.gif
File does not exist: modx/manager/media/style/MODxBlack/images/sort.gif
File does not exist: modx/manager/media/style/MODxBlack/coolButtons2.css
File does not exist: modx/manager/media/style/.MODxBlack./images/icons/save.gif
File does not exist: modx/manager/media/style/MODxBlack/images/srch_bg.gif

Also, the nice logon button doesn’t show up anymore on the logon page. Just
a standard gray form pushbutton. But the server log doesn’t complain about it.
So I guess you removed it. I’m going to move the default MODx install files back
into place and remove all the modified (new) theme files out. So I can start
again with a fresh MODx environment. After everything is synced out with the
default install files. I’ll retry your MOD’s again and see if there is any difference
(just in case something got mis-placed). It won’t take me long, so I’ll report back
shortly.

Thanks for all your hard work.

--Chris H.

EDIT
I had to break from this to create a .htaccess installer I obligated
myself to create for MODx. While I was working on it. It gave me a momment to
reflect on your management theme. It seems that it would be easier and less
prone to file anomolies if it were made with just 2 images and you simply use
absolute positioning. It would also make it much easier to maintain and
upgrade. What do you think?
Well, I’ve been up for just shy of 3 days w/o sleep (huge work load combined with
the MODx projects) so I’m going to have get back to this after getting a bit of
sleep.

Best wishes.
/EDIT

Chris, you’re definitely on track with where we’d like to go on the admin themes... sprite-based (?) graphics packs. Would make for very nice graphics kits for developers and theme authors indeed.

Updated :

092ManagerTweak
ModxGreen
MODxRed
MODxBlack

Thanks again for help.

Like Ryan saids manager themes are only little step to the great 1.0 release manager changes and improvements..

Quote from: banzai at May 23, 2006, 11:25 AM

Updated :

092ManagerTweak
ModxGreen
MODxRed
MODxBlack

Thanks again for help.

Glad to be of assistance. Thanks for the (more) attractive manager.
Quote from: banzai at May 23, 2006, 11:25 AM

Like Ryan saids manager themes are only little step to the great 1.0 release manager changes and improvements..

Understood. I impliment a 1 or two image style for a coule of my clients, and it
makes life so much easier. I can style 150+ images using only one or two
images. This also makes a smaller footprint on the web server - it takes alot less
space to store one or two images, than 150.

I was going to give more detailed dirscriptions (and causes) on the last set of
themes you provided. But I guess I’ll wait to see what your updates reveal.

OH, it just occured to me; would you like an account on the server I’m testing it
on? That might provide you with more insight. Just let me know.

--Chris H.

Hello!
Well I just downloaded and installed the new themes and the updated 92tweak.
Here are my initial findings:
ERRORS reported:
File does not exist: /manager/media/style/MODxBlack/coolButtons2.css
PHP Warning: Missing argument 4 for makehtml() in /manager/frames/3ldr.php on line 60

I haven’t looked at the files in question yet. But from my last investigation; the only
files that you provide that have coolButtons.css in it is: l0mnu.php
But I just now looked and see you have removed it. I’ll have to look deeper.
I should run a find | sed | (e)grep on the MODx tree and find every instance of
that call.


Note; these are using the new MODxBlack theme. I’ll report on the red theme if there
are any differences/ additions.

Keep up the great work.

--Chris out...

Here’s what the Red theme presents:

File does not exist: /manager/media/style/MODxRed/coolButtons2.css
File does not exist: /manager/media/style/MODxRed/images/bg/tabs.gif
PHP Warning: Missing argument 4 for makehtml() in /manager/frames/3ldr.php on line 60

I’ll now take a look in the file tree for the offending coolButton2.css file
and report back with what I discover.

--Chris out...

Quote from: banzai at May 21, 2006, 12:47 PM

coolButtons2.css does not exist anymore, must be in any not fixed frame file..

Ahh... the powerful tools UNIX provides:

5:45pm
Tue, 23 ns1# find ./ -exec grep -nw "coolButtons2.css" ’{}’ \; -print
19: <link rel="stylesheet" type="text/css" href="media/style/<?php echo $manager_theme ? "$manager_theme/":""; ?>coolButtons2.css<?php echo "?$theme_refresher";?>>" />
./includes/header.inc.php
15:<link rel="stylesheet" type="text/css" href="media/style/<?php echo $manager_theme ? "$manager_theme/":""; ?>coolButtons2.css<?php echo "?$theme_refresher";?>" />
./includes/interfacecontrol.inc.php
Binary file ./media/style matches
./media/style
Binary file ./media/style/MODx matches
./media/style/MODx
Binary file ./media/style/.MODx matches
./media/style/.MODx
So, we can see that manager/includes/header.inc.php calls it on line 19
and so does manager/includes/interfacecontrol.inc.php on line 15

I’ll return with those files in your mod’s that call these (if any). But my guess is
that it’s not yours, but the manager/index.php (and friends).

--Chris out...

I’m back.
YUP. it’s in manager/index.php on line 229
include_once "header.inc.php";

I’ll keep searching...


...and again on line 238
include_once "header.inc.php";
and on line 247
include_once "header.inc.php";
and lines: 253,259,277,298,314,320,334,
340,350,367,373,390,396,417,
423,444,450,471,480,496,502,
508,530,539,545,580,588,593,
611,627,643,659,675,705,714,
723,732,741,750,767,772,777,
785,793,804,832,841,850,856,
878,884,898.
OK. This is really easy to resolve. I’ll just convert it to a conditional
and that will resolve it. I’ll report back with the results.

--Chris out...

coolButtons2.css problem resolved:
in manager/includes/interfacecontrol.inc.php
simply replace line 15 with:

<link rel="stylesheet" type="text/css" href="media/style/<?php echo $manager_theme ? "$manager_theme/":""; ?>style.css<?php echo "?$theme_refresher";?>" />

and in manager/includes/header.inc.php
simply replace line 19 with:

<link rel="stylesheet" type="text/css" href="media/style/<?php echo $manager_theme ? "$manager_theme/":""; ?>style.css<?php echo "?$theme_refresher";?>" />

done!
So there is only one image file missing in the red theme:
manager/media/style/MODxRed/images/bg/tabs.gif
and both the red and black theme complain about:

PHP Warning: Missing argument 4 for makehtml() in /manager/frames/3ldr.php on line 60
I haven’t yet looked into that. I’ll get back with the cause and a solution.

--Chris out...

Greetings,
There’s another issue I just noticed that needs to be addressed. It is the fact that
when changing from either red or balck theme and choosing save, does not refresh
the entire screen. Only the window with the settings in it (the window with save in it).
So a force reload in the browser is required to get MODx to display the new default
theme. I haven’t yet had the opportunity to source the cause. So I thought I should
mention it.

--Chris out...

Hello,
I’ve resolved the ERROR:

Missing argument 4 for makehtml() in /manager/frames/3ldr.php on line 60

Simply change line 51 in manager/frames/3ldr.php

from:
makeHTML($indent,$parent,$expandAll);

to:
makeHTML($indent,$parent,$expandAll,$theme);

and the error will be resolved.

I’ll try to discover and resolve any other issues I find and report back with the results.

--Chris out...

Bummer,
2 new issues:

File does not exist: /manager/media/style/.$theme./images/_tx_.gif
File does not exist: /manager/media/style/MODxBlack/tabs.css

I’ll dig through the code and see what I can find/ fix.

--Chris out...

OK, it’s located in:

manager/actions/static/resources.static.action.php
on line 22 (the call for: tabs.css).

I’m attempting to fix it now.

--Chris out...