[Template Manager] MODxGreen

BINGO! or should I say CRAP!
The problen is on line 19 in manager/actions/static/resources.static.action.php

(media/style/.$theme./images/_tx_.gif)

$theme isn’t being expanded. So it isn’t global, nor a recognised proto/ super.

This is going to be a little more difficult. Unless I find I can simply expand it in place.
I’m just concerned how that will affect any of it’s children.

As Arnold said...

I’ll be back...

Hello,
Great! _tx_.gif issue resolved. All I need is for banzai to produce the
MODxBlack, and the MODxRed ./tabs.css file. Curing the _tx_.gif
issue was a simple matter of changing line 19 of file:

manager/actions/static/resources.static.action.php

from:


<span class="right"><img src="media/style/.$theme./images/_tx_.gif" width="1" height="5">
<?php echo $_lang[’resource_management’]; ?></span>

to:

<span class="right"><img src="media/style/<?php echo $manager_theme ? "$manager_theme/":""; ?>images/_tx_.gif" width="1" height="5">
<?php echo $_lang[’resource_management’]; ?></span>

But tabs.css doesn’t exist in either the Red, or the Black theme. So I can’t make the tabs.css
error go away. The tabs.css file did exist in the v.1.3 of the Green theme. However, unless
I hear otherwise, I can’t assume that it is a suitable replacement. So I’ll await
Bonzai’s replacement file, or the nod that it’s OK for either theme (but I doubt it is).
So till then, I’ll await word form bonzai before continuing.

--Chris out...

P.S. I’ll post a summary shortly, now that I’ve squashed all the bugs. I’ve used the
forum as much for note taking as for a progress report.

Green/ Black, and Red Manager theme resolution:

files affected:
1) manager/includes/interfacecontrol.inc.php (line 15)
2) manager/frames/3ldr.php (line 51)
3) manager/includes/header.inc.php (line 19)
4) manager/actions/static/resources.static.action.php (line 19)

Changes in detail:

manager/includes/interfacecontrol.inc.php
REPLACE line 15 with:

<link rel="stylesheet" type="text/css" href="media/style/<?php echo $manager_theme ? "$manager_theme/":""; ?>style.css<?php echo "?$theme_refresher";?>" />
done

manager/includes/header.inc.php
REPLACE line 19 with:

<link rel="stylesheet" type="text/css" href="media/style/<?php echo $manager_theme ? "$manager_theme/":""; ?>style.css<?php echo "?$theme_refresher";?>" />
done

manager/frames/3ldr.php
REPLACE line 51 with:

makeHTML($indent,$parent,$expandAll,$theme);
done

manager/actions/static/resources.static.action.php
REPLACE line 19 with:

<span class="right"><img src="media/style/<?php echo $manager_theme ? "$manager_theme/":""; ?>images/_tx_.gif" width="1" height="5">
<?php echo $_lang[’resource_management’]; ?></span>
done

th, th, th, that’s all folks!

NOTE banzai will still need to provide $theme/tabs.css to compete
the manager theme(s). Once provided (for all colors) the manager themes can be
considered complete and fully functional.

Are you listening banzai?

--Chris out...

Thanks again for your great tests, help and finds ,
I’ve update again
- ManagerTweak with your fix
- RedManager (to remove call to tabs.gif)


NOTE: the style tabs.css has been removed in all themes (included blue/orange and Green) and included in style.css


..if you will not find any other issue, next step should be a complete cleaning of all ’not needed’ images....

thanks again

Quote from: banzai at May 24, 2006, 04:29 AM

Thanks again for your great tests, help and finds ,

You are very welcome.

Quote from: banzai at May 24, 2006, 04:29 AM

I’ve update again
- ManagerTweak with your fix
- RedManager (to remove call to tabs.gif)

Excellent. I’ll test it as soon as I can.

Quote from: banzai at May 24, 2006, 04:29 AM

NOTE: the style tabs.css has been removed in all themes (included blue/orange and Green) and included in style.css

Does your new update remove all the calls to tabs.css?

Quote from: banzai at May 24, 2006, 04:29 AM

..if you will not find any other issue, next step should be a complete cleaning of all ’not needed’ images....

Sounds good!

Quote from: banzai at May 24, 2006, 04:29 AM

thanks again

You’re welcome again.

Thanks!

--Chris out...

.

yes there is no more call to tabs.ccs
thanks again

OK,
I tried the updates out, and it looks good.
One issue though. In the Manage modules pane there is some css that
needs addressing. Need a no-break on space. I’m attaching a screen
clipping so you can see what I mean. In the mean time, I’ll keep trying
to break it. So we know there’s nothing else wrong.

Thanks for the hard work.

P.S. Same is true for the Red theme (broken css).

One more thing.
There is still the issue of it not refreshing the whole page after
changing the theme and then choosing Save. It should refresh the
entire page after pressing Save. But it only refreshes the one pane.

I’ll try and look into it. But I’ve got some other MODx related
things to finish today, as well as this.

Thanks!

--Chris out...

Ooops, looks like I found another css issue.
Its off Home menu. Look at page impressions in the screen clipping
I’ve attached. So you can see what I mean.

--Chris out...

chris#,

Any chance you want to take a stab at helping us get rid of the frames sooner than we originally intended.