Answered phpThumbsUp not working after update to 2.2.11-pl

I'm using this solution currently. Working great.

Quote from: remek555 at Jan 31, 2014, 06:45 AM

Hi,

In core/components/phpthumbsup/model/phpthumbsup/phpthumbsup.class.php around line 360 comment out the if like below (so it works for all contexts)
I have not tested if it works in 100% scenarios, but working for me.

//if ($this->modx->context->key == 'mgr') {
$options['src'] = '/' . $options['src'];
//}

clean modx cache, browsers cache.
It happens because modPhpthumb treats image path as relative to it's own model path if it's not prepended with /:
/home/remek/www/site/core/model/phpthumb/site/assets/pics/C31645455_1.jpg

Thanks for that - been searching everywhere to find a fix - why didn't this thread show up?

Quote from: remek555 at Jan 31, 2014, 06:45 AM

Hi,

In core/components/phpthumbsup/model/phpthumbsup/phpthumbsup.class.php around line 360 comment out the if like below (so it works for all contexts)
I have not tested if it works in 100% scenarios, but working for me.

//if ($this->modx->context->key == 'mgr') {
$options['src'] = '/' . $options['src'];
//}

clean modx cache, browsers cache.
It happens because modPhpthumb treats image path as relative to it's own model path if it's not prepended with /:
/home/remek/www/site/core/model/phpthumb/site/assets/pics/C31645455_1.jpg

Not Working for me... still waiting for the propper fix...

Googles index isn't instant? .. you did find it though.

Quote from: chrisandy at Feb 11, 2014, 08:41 AM

Thanks for that - been searching everywhere to find a fix - why didn't this thread show up?

I was fooled, this also did not fix for me.

This commit from yesterday may address the issues: https://github.com/modxcms/revolution/commit/2d3b9b1447ce627ff3524974001236bbca6f9ec7

I have not confirmed if the v2.2.12 dev builds announced yesterday (2/14/2014) include this, but I would assume so:

Traditional: http://modx.s3.amazonaws.com/releases/2.2.12/modx-2.2.12-dev-20140214.zip
Advanced: http://modx.s3.amazonaws.com/releases/2.2.12/modx-2.2.12-dev-20140214-advanced.zip

(via https://twitter.com/drumshaman/statuses/434370610806812673)

I updated the /core/model/phpthumb/modphpthumb.php and phpthumb.class.php of the 2.2.11 version with the pre 2.2.12-dev version @pixelchutes mentioned and I can confirm that the images are generated and no errors are mentioned in the error.log.
Finally! Thanks!

Great! Many thanks for the fix all!

I am in 2.2.10 and phpThumbsUp is not working. Is it safe for me to get modphpthumb.php and phpthumb.class.php from that pre 2.2.12 and update my versions.

Another silly question—can I do this through the manager, or do they need to be replace via an ftp application?

You can update this via the manager (first allow php files to be uploaded via site > file settings > allowed file types)

But in you case I do not think it will help, phpThumbsUp worked in 2.2.10.