095 public Release Candidate support

MODX Staff
12,272 Posts

Ryan Thrash Reply #11, 19 years, 10 months ago

Quote from: OncleBen31 at Nov 08, 2006, 04:20 PM

Quote from: rthrash at Nov 08, 2006, 10:37 AM

Quote from: Pont at Nov 08, 2006, 10:06 AM

The 6 files to translate - which ones is it?

We’ll be putting out a translation kit in the immediate future... I just added a couple of strings in 1944 for a register_globals check for instance, so we want to give it one last pass-through, including the README.xx.txt file. The structure for a complete translation looks like the following. If you’d like to get an early start, please base them on the latest SVN trunk, currently at 1944:

README-en.txt ? basic readme/new install instructions

manager/includes/lang/english.inc.php - main language file for manager
manager/includes/lang/country/english_country.inc.php - drop-down list of countries (may have some changes, may not need translations)

assets/snippets/ditto/lang/english.inc.php
assets/snippets/eform/lang/english.inc.php

assets/modules/docmanager/lang/english.inc.php
assets/modules/quick_edit/lang/english.inc.php

Do you notice there is a set with weblogin, websignup, webchangepwd and webeditprofile with internationalization (lang file added).
weblogin, webchangepwd and websignup
webeditprofile snippet

May be this should be added in 0.9.5

Those additions will have to be hacked back into the current versions of weblogin, etc. But hopefully those will be done shortly after the official 095 release and can be added back in as an 0951 release.

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

☆ A M B ☆
1,056 Posts

pixelchutes Reply #12, 19 years, 10 months ago

I think there MIGHT be a vulnerability with ListIndexer v1.0 that comes packaged with MODx 0.9.5 RC 3.

Line 319 in the snippet has a variable declaration referencing variable from the _GET scope.

$validParents = $_GET['LIn_f'];

Line 334 just after it places the variable directly inside a dynamic SQL statement.

// Look everywhere, or just under valid parents
$recentSql .= (($rootFolder == 0) && $seeThruUnpub && ($descendentDepth == 0))? "" : "parent IN ($validParents) AND " ;

Now, it was my understanding that to be safe from SQL-injection attacks (while leveraging the MODx DBAPI) you’d at least want to
run MODx escape:

Change Line 360 from:

// Run statement
$rsRecent = $modx->dbQuery($recentSql);

to

// Run statement, escaping
$rsRecent = $modx->dbQuery( $modx->db->escape( $recentSql ) );

I might be missing something here, but if not, probably wouldn’t want to package the unsafe code with the stable build.

There may be other places within the snippet that actual may need to be secured.

Mike Reid - www.pixelchutes.com
MODx Ambassador / Contributor
[Module] MultiMedia Manager / [Module] SiteSearch / [Snippet] DocPassword / [Plugin] EditArea / We support FoxyCart
________________________________
Where every pixel matters.

502 Posts

ajayre Reply #13, 19 years, 10 months ago

This one seems to have reappeared. I know it was fixed before but in the copy I just obtained from svn it is back:

http://modxcms.com/bugs/task/589

Andy

46 Posts

Aikdo Reply #14, 19 years, 10 months ago

Posted my responce to this in a seporate post by mistake http://modxcms.com/forums/index.php/topic,10021.0.html

i need a resolvation to this ASAP its a production site i wanted to start from scratch deleting the old site first then installing 0.95 from scratch but i got this problem.

228 Posts

identity Reply #15, 19 years, 10 months ago

@INHERIT not working properly?

I brought this up in another thread, but now thinking it isn’t completely related so I wanted to bring it up here, which I believe is a bug, but still trying to establish that as well....

Since upgrading from 0.9.2 to 0.9.5RC3 and now the soft launch, @INHERIT doesn’t appear to be working.

@INHERIT
<h2>About CMS</h2>
{{About}}

<h2>New News</h2>
[!Ditto? &startID=`16` &tpl=`DittoSummarySidebarTpl` &summarize=`1` &displayArchive=`0`!]

I have tried this from the template level and document level, and have also tried replacing the {{About}} chunk with text, but in both cases nothing appears after the "About CMS" heading. After removing the @INHERIT, everything is fine... not really, but at least all of the other content shows up.

So is anyone else experiencing this? Did I some how gets confused and lost in my understanding and am doing something wrong?

Right now this has stopped me from converting a site over, so wrong or right, I really need to either get it fixed or figure out whay I’m doing wrong as I’m dead in the water right now.

cheers

| Identity Developments delivers SEO focused web design and web presence services
- it's not about websites, it's about your identity. |

MODX Staff
10,725 Posts

opengeek Reply #16, 19 years, 10 months ago

I’m confused a little by what you are describing. Your value needs to be either @INHERIT, by it self, or the actual content, not a combination of both. Everything after @INHERIT is ignored, as the @INHERIT binding indicates to the parser that you want content from a level above the current document.

Jason Coward
Chief Architect @ MODX
http://www.jasoncoward.com | http://twitter.com/drumshaman | https://github.com/opengeek

228 Posts

identity Reply #17, 19 years, 10 months ago

Jason,

thanks... maybe I’ve just confused myself... going back and forth between things and working with MODx and then leaving it sit for awhile and upgrading versions.

Looks like I need to revisit the whole @INHERIT thingy.

.... okay, maybe I’m even more confused... after re-reading the docs on @INHERIT, this seems like what I’m trying to do. Setting a default content with an "@INHERIT this is my default content" .... or is that default content limited to one line, which it what seems to be happening.... only the About CMS shows up, although it is technically on a second line.

and then in the appropriate sections, I want to change the TV to new info for that section and expect that child documents of the changed section use the @INHERIT to check if there is no content, and if not display the default.

| Identity Developments delivers SEO focused web design and web presence services
- it's not about websites, it's about your identity. |

MODX Staff
12,272 Posts

Ryan Thrash Reply #18, 19 years, 10 months ago

095 is now out, so if you’ve got a support inquiry for it, please open a new thread. Thanks!

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me