095 public Release Candidate support

MODX Staff
12,272 Posts

Ryan Thrash Reply #1, 19 years, 11 months ago

RC3 is here. Please use this thread and the tracker for bug reports according to the previous guidelines:

If you are confident you’ve found a bug in this RC (or a remaining issue exists from prior RCs), please add an appropriate bug report/feature request to our bug tracker. Make sure to flag the identified version as beta 5. Even better, if you have code that fixes the problem, please include your suggested code changes there; this goes for CSS updates to any of the templates as well.

Feel free to link to forum discussions about specific issues, but we need to see every proposed change to MODx code be accompanied by a Flyspray bug number. Otherwise, it’s likely many of these good catches and great additions to the code will be overlooked at some point, either in this release, or in other branches that are being developed in parallel.

Please try and keep this forum limited to questions or quick informative statements like "Here’s a bug I found in RC3, ...[some details]..., see FS#987 for a suggested fix", and save more detailed error information and suggested code changes for the bug report itself. This will help us tackle some of these issues much more quickly.

After finalizing any remaining language defines with this final RC, we’ll roll out a "translation kit" for non-English languages.

Moderator Note: To keep this thread clean and easy to refer to, we’re being much more aggressive with moderation, including deleting posts if the post is later quoted with a response, and moving discussion out to other threads.

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

1,193 Posts

ScottyDelicious Reply #2, 19 years, 11 months ago

In the manager, under Resources->Manage Files, there is a JavaScript onmouseover effect that changes the background color of the div and helps identify which file’s delete or edit button you are hovering over so you don’t accidentally delete the wrong file.

In Safari, FireFox (1.5 and 2.0), and Opera on Mac OS X, the onmouseover effect does not highlight the div on items that are folders. Is it because this div contains an <a href="example"></a> tag? Can it be changed so that when hovering over an item that is a folder the background changes as it does for files?

-sD-

Husband, Father, Brother, Son, Programmer, Atheist, Nurse, Friend, Lover, Fighter.
All of the above... in no specific order.

I send pointless little messages

3 Posts

dog Reply #3, 19 years, 11 months ago

Hi,

I’ve got 2 problems:

1.
The german language file is saved as UTF-8 but the database server the site is on is mysql4.0 lipsrsealed

so I have to use latin1 as encoding.
MODx won’t convert the language file - resulting in all umlauts being a messed up.
I have to open the language file in a texteditor, save it as latin1 and upload it again everytime I do an update.

2.
I’ve got a Manager Role for Content Editors (they are allowed to create/edit documents,manage webusers,execute modules, use the file manager) however the file manager is the only thing that works.
When they try to execute a Module oder create a New Document they always get a Access Denied message.
Only if they do a right-click on a folder in the document tree and select "Create Document here" it will work.
This problem is there since I startet using Roles (0.9.5b5)
Creating a new Role and new Users won’t help either.
Hope I’m not just overlooking an important setting. grin

73 Posts

Cassiel Reply #4, 19 years, 11 months ago

TinyMCE loses the size of flash objects
http://modxcms.com/bugs/task/676

73 Posts

Cassiel Reply #5, 19 years, 11 months ago

QuickEdit outputs <quickedit:content /> on logout
http://modxcms.com/bugs/task/635

I was able to reproduce this bug in 0.9.5 RC2. See comments for more info.

180 Posts

Pont Reply #6, 19 years, 11 months ago

I think there is an issue with QuickEdit and encoding. Being swedish I naturally use åäöÅÄÖ when appropriate. If I edit a page using QuickEdit and use the Apply button the swedish letters on the page changes to Ã¥Ã¤Ã¶Ã…Ã„Ã– after the refresh. This lasts until I click OK and the refresh restores the correct letters.

UPDATE:
I’m not enough of a coder to solve this on my own, but maybe this can help.
Saving the form with "OK" submits the form to index.php. When submitting a form, javascript uses the specified encoding of the page. However - when using "Apply" the form is saved with an AJAX-call to index.php. Javascript encodes this internally as utf8 and the posted data has to be decoded in the backend to the encoding used on the site (unless it’s utf8) to be saved correctly.

On my site the encoding is ISO-8859-1 so the interim save wrongly encodes the content as utf8. Saving with "OK" corrects this but should I choose to just "Close" the editor window the content remains saved with the wrong encoding. Correcting this for the uninitiated is not a pleasant task...

I’ve come up with a temporary fix for the above issue. Adding the following code to assets/modules/quick_edit/editor.class.inc.php makes it work with sites encoded with iso-8859-1.

274  $value_prep = $modx->db->escape($value);
275
276  /*  ADD THIS  */
277  if (mb_detect_encoding($value_prep,'UTF-8, ISO-8859-1') == 'UTF-8') {
278      $value_prep = utf8_decode($value_prep);
279  }
280
281  if(is_numeric($cv->id)) {

I’m sure there is a better way to do this. And the code should of course work for any encoding, but my coding skills are limited. I still hope this can serve as a beginning of a proper fix.

UPDATE:
Added in bugtracker - FS#685

MODX Staff
12,272 Posts

Ryan Thrash Reply #7, 19 years, 10 months ago

Quote from: Sudrien at Nov 29, 2006, 03:03 PM

Tools > configuration > Interface > tinymce settings > theme

does not seem to have any effect on how tinymce acts - it always has a "full featured’ view.

By chance does your testing user have an override setting specified?

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

1,131 Posts

Bravado Reply #8, 19 years, 10 months ago

Quote from: abbeyroad at Nov 29, 2006, 07:52 PM

2 - TinyMCE works fine with IE7 but does not seem to be fully functional under Firefox2 : all functions which open in a new pop-up browser window just open an empty window with (for example "Edit HTML Source")
{$lang_theme_code_title}
in the Title bar. This is same for Advanced and Full-featured themes.

Check and see if you have the Adblock extension loaded in Firefox. If you do, be sure and disable it for your MODx site. Other than that, I’m unable to duplicate this issue.

Jeff Whitfield

"I like my coffee hot and strong, like I like my women, hot and strong... with a spoon in them."

MODX Staff
12,272 Posts

Ryan Thrash Reply #9, 19 years, 10 months ago

Quote from: madmage at Dec 03, 2006, 06:26 AM

I don’t know if this is a feature of RC3, it is a bug, it is something that nobody has addressed before (I don’t think this is possible)...

If I make a snippet and I make some mistake in it, loading a page with that snippet hangs the server (i.e., subsequent requests are sloooow), and at last it displays a blank page.

Can you provide a repeatable example that demonstrates this behavior, please?

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

MODX Staff
12,272 Posts

Ryan Thrash Reply #10, 19 years, 10 months ago

Quote from: Vait at Nov 10, 2006, 02:40 AM

I am actually using ModxGreen template for the manager and TinyMCE doesn’t even load up...

Update 1: Fully featured doesn’t load up in any of the 3 templates that come with modx, advanced loads up but ad the bottom of the editing space which I think is a bit annoying, should be on top I think..

Hi Vait,

I can’t seem to reproduce this. I am able to readily switch to different editors, including full featured. The positioning of the bars is defined by default with TinyMCE, and not our doing but I think it can be switched with a bit of work. Probably would take a bit of digging on the Tiny support resources though.

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me