Support/Comments for KoopsMailinglistX

☆ A M B ☆
24,524 Posts

sottwell Reply #71, 19 years, 6 months ago

Great work! I’ve updated the Repository to version 1.4 with your excellent mod! Glad to see a "newbie" in the family that can help us make MODx even better grin

Studying MODX in the desert - http://sottwell.com
Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
Join the Slack Community - http://modx.org

144 Posts

andrazk Reply #72, 19 years, 6 months ago

I was looking at functions.php, around line 71, where next code is:

		if(($phpversion > 4)&&($phpversion < 5)){	
			require('Swift/Swift.php');
			require('Swift/Swift/Swift_Sendmail_Connection.php');
		}elseif($phpversion >=5){
			require('Swift/Swift.php');
			require('Swift/Swift/Swift_Sendmail_Connection.php');
		}

Shouldn’t it read like this?

		if(($phpversion > 4)&&($phpversion < 5)){	
			require('Swift/Swift.php');
			require('Swift/Swift/Swift_Sendmail_Connection.php');
		}elseif($phpversion >=5){
			require('Swift5/Swift.php');
			require('Swift5/Swift/Swift_Sendmail_Connection.php');
		}

Mind the Swift5 change.

This list does not support different charset, unless set manually. Maybe a thing to include in config.php or take MODx charset as default.

☆ A M B ☆
24,524 Posts

sottwell Reply #73, 19 years, 6 months ago

Indeed. All of this was taken verbatim from the original Koops Mailinglist, so any non-MODx specific fixes we do here should probably get sent on to him.

Studying MODX in the desert - http://sottwell.com
Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
Join the Slack Community - http://modx.org

144 Posts

andrazk Reply #74, 19 years, 6 months ago

Ok, I’ll send a mail to the author explaining the situation.

160 Posts

ConseilsWeb Reply #75, 19 years, 6 months ago

Quote from: sottwell at Mar 23, 2007, 02:43 AM

Great work! I’ve updated the Repository to version 1.4 with your excellent mod! Glad to see a "newbie" in the family that can help us make MODx even better

Hey! I’m glad I’m helping people out here! I might be a newbie to the family, but I already love MODx and I hope I can contribute even more. I’m still learning a lot right now and everybody seems to be talking about how 0.9.7 will change everything...

As for the list, Koops could probably use some help, but I think he stopped working on the project. It’s a functional list, but for more features, I guess we’ll have to go our own way. To use the modx charset, adding this line before $mail->send() should work, but I haven’t test it, so use at your own risk:

			$mail->setCharset($modx->config['modx_charset']);

Olivier Deland
Montreal, Canada - Web Developer

MODX Staff
12,272 Posts

Ryan Thrash Reply #76, 19 years, 6 months ago

I have a feeling that PoMMo will take off where Koops stopped. wink

Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me

☆ A M B ☆
24,524 Posts

sottwell Reply #77, 19 years, 6 months ago

Yes, this was actually a desperate stop-gap measure for a site that I just had to have a simple, functional mailing list ASAP! It does the job, but a "real" native mailing list app is on my "little list" grin

Studying MODX in the desert - http://sottwell.com
Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
Join the Slack Community - http://modx.org

160 Posts

ConseilsWeb Reply #78, 19 years, 6 months ago

Hey, yeah, that’d be great. Let me know if I can help in any way.

Olivier Deland
Montreal, Canada - Web Developer

160 Posts

ConseilsWeb Reply #79, 19 years, 6 months ago

Ok, I’ve been playing a little bit more with the mailing list and it seems I forgot a little something by using the core functions for using the manager’s RTE. The manager code adds a call to a javascript onChange for the textarea, this is normally used to check if the content has changed and warn you with a pop up when you exit the page. Since the javascript function is not defined, the editor’s pop ups won’t close when clicking on ’Insert’ or ’Update’, at least with Firefox and TinyMCE. So to fix this, I define the function in the module header which simply returns ’true’ since we don’t need to check for content change like a normal document would. I’m not sure I’m making this clear, but if you get the bug, simply edit the module code.

Around line 60, you’ll find the code that outputs the HTML header, simply add this between the <head> tag:

<script type="text/javascript">function setVariableModified(fieldName){
    return true;
}
</script>

Olivier Deland
Montreal, Canada - Web Developer

☆ A M B ☆
24,524 Posts

sottwell Reply #80, 19 years, 6 months ago

Should I add this to the "official" repository version? I certainly didn’t have any trouble with it; sent myself a few test mailings with no problems.

Studying MODX in the desert - http://sottwell.com
Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
Join the Slack Community - http://modx.org