095 Home Stretch

• • 
  • 7,075 Posts
  davidm Reply #121, 19 years, 11 months ago

  After further investigation, it seems QuickEdit is indeed working on some pages, but not on others... even more strange is I have tried to pin down what kind of differences there are between the pages where it works and those who do not work, but no luck so far
  
  While I am here, totally forgot but we forgot to remove the "Log visits" item in the Document settings > Page setting tab
  .: COO - Commerce Guys - Community Driven Innovation :.
  
  

  ---

  MODx est l'outil id
• • 
  • 1,198 Posts
  Nicola (Banzai) Reply #122, 19 years, 11 months ago

  Found a new issue in MODx and MODxGreen themes: tree context menu does not appear in Firefox, I think it’s a latest frames changes / div css position issue, I’ll fix it soon as possible.
  Free MODx Graphic resources and Templates www.tattoocms.it
  -----------------------------------------------------
  
  MODx IT  www.modx.it
  -----------------------------------------------------
  
  bubuna.com - Web & Multimedia Design
• • 
  • 7,075 Posts
  davidm Reply #123, 19 years, 11 months ago

  Again on QuickEdit issue : I am not the only one now, Pont just reported the exact same problem so it’s definitely not just me. And it’s also an upgrade.
  .: COO - Commerce Guys - Community Driven Innovation :.
  
  

  ---

  MODx est l'outil id
• • MODX Staff
  • 1,535 Posts
  Garry Nutting Reply #124, 19 years, 11 months ago

  David - I’ve been getting the same problem on the modx.it site. Been doing a few minor debugs to see what’s going on and, at the point that the QuickEdit links are being constructed (in output.inc.php), echoing the $_lang array is returning the Ditto language strings and not the intended QuickEdit language strings.
  
  Subsequently, the QE language strings are not being inserted, resulting in the blank links. So, all in all, I’m sensing a conflict of language files between Ditto and QuickEdit (may affect other snippets that use language files as well, but I think Ditto is the only one in the default content)
  
  Just thought I’d report my findings, off to do a bit more digging ...
  Garry Nutting
  Senior Developer
  MODX, LLC
  
  Email: [email protected]
  Twitter: @garryn
  Web: modx.com
• • MODX Staff
  • 1,535 Posts
  Garry Nutting Reply #125, 19 years, 11 months ago

  Another update ... managed to reproduce the problem on my local machine with the conditions I described above. I’ve attached a proposed fix to the problems in this post. (files in the zip file need to be copied into the quick_edit module folder)
  
  I went and did a ’format source’ in Eclipse without thinking so doing a diff comparison on the files is probably not going to work, but the changes are:
  
  1. In the constructor for each of the classes, the $_lang strings are pushed into another array - $QE_lang - to prevent any conflicts.
  2. Renamed all occurrences of $_lang to $QE_lang where appropriate.
  
  It has fixed the issue for me, but if somebody who has been experiencing the problem (David ) could test this out as well it’d be great.
  Garry Nutting
  Senior Developer
  MODX, LLC
  
  Email: [email protected]
  Twitter: @garryn
  Web: modx.com
• • ☆ A M B ☆
  • 24,524 Posts
  sottwell Reply #126, 19 years, 11 months ago

  Perhaps some standards should be set on snippet/plugin development, including naming conventions for language and other variables that are likely to conflict? $ditto_lang[’string’], $quickedit_lang[’string’], etc. We’ve also seen problems with conflicting CSS rules that could be avoided with similar naming conventions.
  Studying MODX in the desert - http://sottwell.com
  Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
  Join the Slack Community - http://modx.org
• • 
  • 7,075 Posts
  davidm Reply #127, 19 years, 11 months ago

  I confirm this was a problem occuring only with pages where Ditto was included, Pont just pointed me to it.
  
  Thanks Garry, that’s great, I am downloading and will go straight to testing this !
  
  Edit : Just installed the fix, it works flawlessly now !
  
  .: COO - Commerce Guys - Community Driven Innovation :.
  
  

  ---

  MODx est l'outil id
• • MODX Staff
  • 1,535 Posts
  Garry Nutting Reply #128, 19 years, 11 months ago

  Cool, I’ve submitted my QE fix to my branch in SVN.
  
  

  Perhaps some standards should be set on snippet/plugin development, including naming conventions for language and other variables that are likely to conflict?

  I think that’s a must now. Perhaps post-0.9.5, we could have a collaborative push to get some standards in place - I’m thinking more general coding guidelines like naming conventions etc. as opposed to specific API usage as that’s going through a state of change for 0.9.7 anyway.
  
  
  Garry Nutting
  Senior Developer
  MODX, LLC
  
  Email: [email protected]
  Twitter: @garryn
  Web: modx.com
• • 
  • 7,075 Posts
  davidm Reply #129, 19 years, 11 months ago

  I don’t know if it’s related to the DocManager modifications, but I am now unable to set a new parent for a document (when I click on "Move" I have the usual dialog box but when I try to set the new parent, I just end up on the parent document page and nothing is updated.
  
  Same happens with the "Sort Menu item" with the DocManager Module... (laurentc just reported this -> french post, just for reference)
  
  I thought Garry’s change to DocManager were in Beta5, am I wrong here ?
  
  Edit : While I am here, I have catched another QuickEdit missing translation string. I’ll have a new french file posted together with DocManager translation in a few hours.
  .: COO - Commerce Guys - Community Driven Innovation :.
  
  

  ---

  MODx est l'outil id
• • MODX Staff
  • 1,535 Posts
  Garry Nutting Reply #130, 19 years, 11 months ago

  I thought Garry’s change to DocManager were in Beta5, am I wrong here ?

  The problems is because of the frame changes made recently ... I haven’t had chance to submit an update for that yet, will try and have a look tonight.
  Garry Nutting
  Senior Developer
  MODX, LLC
  
  Email: [email protected]
  Twitter: @garryn
  Web: modx.com

This discussion is closed to further replies. Keep calm and carry on.