We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
MODX Community Forums Archive

TP3.3 internal test build

    • 18397
    • 3,250 Posts
    MARKSVIRTUALDESK Reply #51, 20 years, 11 months ago
    A conversation I had with Ryan (too sleepy to retype):

    [22:17] MARKSVIRTUALDESK: 414s install default site still fails
    [22:18] rethrash: in what way?
    [22:18] MARKSVIRTUALDESK: no default content even though I checked the box
    [22:19] rethrash: LOL
    [22:19] MARKSVIRTUALDESK: and the templates wrong
    [22:19] MARKSVIRTUALDESK: i think its using the old sql
    [22:19] rethrash: huh?
    [22:19] MARKSVIRTUALDESK: it has the old template
    [22:19] MARKSVIRTUALDESK: the one by helder
    [22:19] rethrash: which template?
    [22:19] MARKSVIRTUALDESK: as the default
    [22:19] MARKSVIRTUALDESK: the Etomite default
    [22:20] rethrash: how is that possible... not even part of it!
    [22:20] MARKSVIRTUALDESK: well
    [22:20] MARKSVIRTUALDESK: it happened
    [22:20] rethrash: did you delete everythign from teh folder before uploading?
    [22:21] MARKSVIRTUALDESK: new folder
    [22:21] MARKSVIRTUALDESK: clean install
    [22:21] MARKSVIRTUALDESK: nothing to overwrite
    [22:21] rethrash: i’ll look later then
    [22:21] rethrash: makes no sense
    [22:21] MARKSVIRTUALDESK: weird
      • 25663 MODX Staff
      • 12,272 Posts
      Ryan Thrash Reply #52, 20 years, 11 months ago
      Ahhh.... that’s the default, default site content... working on that now... another good find/catch. smiley
        Ryan Thrash, MODX Co-Founder
        Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
        • 34162
        • 1 Posts
        Zombie Reply #53, 20 years, 11 months ago
        Raymond,

        It is true the "//" does not effect how the apache show the file but when you do disk "I/O" it will fail with "//"
          • 25663 MODX Staff
          • 12,272 Posts
          Ryan Thrash Reply #54, 20 years, 11 months ago
          OK, I’m down to one last major bug that for the life of me I can’t figure out. It involves the installer failing to install the demo data because it’s getting lost in the POST, somehow.

          After you check the "install demo site data" the post values in the session are as follows. This comes as a result of the case statement (6) around line 660 of the install/index.php file. The actual function that builds this page is function buildSummaryScreen()  around line 370 of the same file:
          The value of $_POST['installmode'] is 'upd' 
The value of $_POST['databasename'] is 'modx' 
The value of $_POST['tableprefix'] is 'modx_' 
The value of $_POST['databasehost'] is 'localhost' 
The value of $_POST['databaseloginname'] is '' 
The value of $_POST['databaseloginpassword'] is '' 
The value of $_POST['testbox'] is '' 
The value of $_POST['cmsadmin'] is 'admin' 
The value of $_POST['cmspassword'] is '' 
The value of $_POST['cmspasswordconfirm'] is '' 
The value of $_POST['installdata'] is '1' 
The value of $_POST['chunk'] is 'Array' 
The value of $_POST['module'] is 'Array' 
The value of $_POST['plugin'] is 'Array' 
The value of $_POST['snippet'] is 'Array' 
The value of $_POST['chkagree'] is '1' 
The value of $_POST['syscheck'] is 'on' 
The value of $_SESSION['session_test'] is '1'


          Please note that installdata is set to ’1’ as it should be. However, after pressing the install now button, and going to the next page using case 7, using the actual POST and working through the logic found near line 88 of install/index.php:
          The value of $_POST['installmode'] is 'upd' 
The value of $_POST['databasename'] is 'modx' 
The value of $_POST['tableprefix'] is 'modx_' 
The value of $_POST['databasehost'] is 'localhost' 
The value of $_POST['databaseloginname'] is '' 
The value of $_POST['databaseloginpassword'] is '' 
The value of $_POST['testbox'] is '' 
The value of $_POST['cmsadmin'] is 'admin' 
The value of $_POST['cmspassword'] is '' 
The value of $_POST['cmspasswordconfirm'] is '' 
The value of $_POST['chunk'] is 'Array' 
The value of $_POST['module'] is 'Array' 
The value of $_POST['plugin'] is 'Array' 
The value of $_POST['snippet'] is 'Array' 
The value of $_POST['chkagree'] is '1' 
The value of $_POST['syscheck'] is '' 
The value of $_SESSION['session_test'] is '1' 
Setup will now attempt to setup the database:


          So, as you can see, the $_POST value for installdata simply disappears!!! It’s the only _POST value which does so, and it’s also the only POST variable that I don’t readily see a specific JS function to set it to the session. Everything I’ve tried to do has failed, given that I’m really not a coder ... The JS-setting functions occur near the bottom around line 850 or in the case/swich around line 690.

          FYI, the installdata post value is one half of the key stuff that tells the instprocess.php file near line 125 to install the demo data. If it’s not set, then it just skips that part.

          Any help would be TREMENDOUSLY appreciated... Thanks!


            Ryan Thrash, MODX Co-Founder
            Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
            • 34162
            • 1 Posts
            Zombie Reply #55, 20 years, 11 months ago
            Here is what I found:

            install\index.php:271
            echo "&nbsp;<input type=’checkbox’ name=’installdata’ value=’1’ />Install Demo Site</span> - Please note that this will overwrite existing documents and resources.<hr size=’1’ style=’border:1px dotted silver;’ />";


            install\instprocessor.php:14
            $installData = intval($_POST[’installdata’]);

            The "installdata" in index.php need to assign to the $_POST so that the instprocessor.php have something to pick it up.
              • 25663 MODX Staff
              • 12,272 Posts
              Ryan Thrash Reply #56, 20 years, 11 months ago
              Looks like Raymond nailed it!

              Attaching new rev422 to the first post here. I tested an install without demo site followed by an upgrade including demo site and everything worked wonderfully!
                Ryan Thrash, MODX Co-Founder
                Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
                • 18397
                • 3,250 Posts
                MARKSVIRTUALDESK Reply #57, 20 years, 11 months ago
                I will try this when I get home (can’t access an FTP server from my current location due to I-Gear)
                  • 18397
                  • 3,250 Posts
                  MARKSVIRTUALDESK Reply #58, 20 years, 11 months ago
                  Just finished a clean install of 422 and it looks perfect so far!

                  I’ll post here if I discover anything tommorow.
                    • 18397
                    • 3,250 Posts
                    MARKSVIRTUALDESK Reply #59, 20 years, 11 months ago
                    Awwww. Scratch that perfect score!

                    The quickedit menu is unusable in IE 6 (note a few versions ago it did).

                    Also, we have NewsLister and NewsListing for snippets huh

                    They both seem to be identical (at first quick glance)!
                      • 25663 MODX Staff
                      • 12,272 Posts
                      Ryan Thrash Reply #60, 20 years, 11 months ago
                      Thanks for the catch Mark. We’ll be sticking with Newslisting, the original name.
                        Ryan Thrash, MODX Co-Founder
                        Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me