-
☆ A M B ☆
- 24,524 Posts
The funky QuickEdit page? Yes.
Already done, Ryan! Oh yeah...I just did a test with a fresh install on my test server. Err...looks like the option for installing the default content doesn’t work right. Regardless of whether it’s checked off or not causes the installer to install the default content anyways. Just thought you should know.
Jeff Whitfield
"I like my coffee hot and strong, like I like my women, hot and strong... with a spoon in them."
Just noticed something in the last uploaded update. In /manager/frames/l4mnu.php, the javascript towards the top doesn’t look right:
<script language="JavaScript" type="text/javascript">
function showWin() {
window.open('../');
}
startList = function() }
if (document.all && document.getElementById) }
navRoot = document.getElementById("nav");
for (i=0; i<navRoot.childNodes.length; i++) {
node = navRoot.childNodes[i];
if (node.nodeName=="li") }
node.onmouseover=function() }
this.className+=" over";
}
node.onmouseout=function() }
this.className=this.className.replace
(" over", "");
}
}
}
}
}
function stopIt() }
top.scripter.stopWork();
}
window.onload=startList;
</script>
Shouldn’t it be this?
<script language="JavaScript" type="text/javascript">
function showWin() {
window.open('../');
}
startList = function() {
if (document.all && document.getElementById) {
navRoot = document.getElementById("nav");
for (i=0; i<navRoot.childNodes.length; i++) {
node = navRoot.childNodes[i];
if (node.nodeName=="li") {
node.onmouseover=function() {
this.className+=" over";
}
node.onmouseout=function() {
this.className=this.className.replace (/ over/, '');
}
}
}
}
}
function stopIt() {
top.scripter.stopWork();
}
window.onload=startList;
</script>
Plus I noticed that the arrangement for Users and Settings has changed in this file. Is this correct? Just wanted to make sure...though I don’t think it really matters.
Jeff
Jeff Whitfield
"I like my coffee hot and strong, like I like my women, hot and strong... with a spoon in them."
-
MODX Staff
- 12,272 Posts
I think the arrangement is supposed to be different, but the JS may in fact may be a minor oversight.
Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
-
☆ A M B ☆
- 24,524 Posts
Plus I noticed that the arrangement for Users and Settings has changed in this file. Is this correct?
Yes, it is. This is so the drop-down menu will be able to have the secondary menu immediately beneath its parent link instead of shifted to the far left. The menu with the most secondary links has to be on the left so there will be room for them all.
Bug: Missing "Values" on line 63 in setup.data.sql.
Here is the corrected file.
Here are the 3 instances that I found to produce "double slash"
document.parser.class.inc.php:463: $basepath = $this->config["base_path"]."/assets/cache/";
document.parser.class.inc.php:507: $basepath = $this->config["base_path"]."/assets/cache";
document.parser.class.inc.php:523: $basepath = $this->config["base_path"]."/assets/cache";
Here is my proposal to handle cache file problem for a site that can not allow cache. If the file is not there don’t even try to wrtie to the cache thus will prevent any error to show.
document.parser.class.inc.php
line 526: $fname=$basepath."/docid_".$this->documentIdentifier.".pageCache.php";
line 527: If (file_exists($fname)) {
line 538: }
Please let me know what you think.
