I’m trying to post a couple of enhancements I’ve done; I’m stuck on the "/branches" part; what does it want?
-
- 206 Posts
I was told to put my ’multiple instances’ version in a branch and BobRay created one for me.
But I think it’s not necessary for you to make a new one.
Just svn your files to the trunk...
And I hope that you took my version as a basis for your improvements, otherwise I’m gonna hack yours again;)
Maybe this would be the time to put multiple instances in the trunk too, since there are no bugs reported on it?
Sorry, that all went right over my head. I’ve never figured out how to use svn; all I did was post the fix in a "request for review"; somebody will have to actually make the changes in a version in svn.
Right. It’s the "something like that" that has baffled me in my previous attempts at svn. I’ve got too much else going on to keep fighting this particular battle. If those in charge of a given project want my changes, I’m perfectly happy to clearly set out what was done so they can make the changes themselves. A person’s gotta know his limitations
-
- 386 Posts
Like Susan I have made a few changes to the webloginpe class that may (or may not) interest people. Specifically I have:
* Changed the Registration with email verification behavior to allow the user to specify their own password at registration and activate it using a link sent in an email (since sending the user an auto-generated password by email is inherently insecure).
* Included support for my SSL plugin to manage switching between https and http pages
* Increased the security of the password reset facility
* Cleaned up and improved the custom system events
Would anyone be interested in these changes? And, if so, would someone be prepared to integrate them with the latest version of the snippet? If not I may be able to add them to the latest version assuming we can establish where this is.
I think those would make a lot of sense to get into the Google Code project.
Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
-
- 99 Posts
Good evening,
I’d like to see if I could join the Google project to propose some additions/changes for this snippet. I began using it earlier this week and, while it has a really great foundation, I’ve found some areas coming up short. I’ve been working on those and would like to share these ideas with the group. Among the items I’m looking to add/alter:
- Add option to format forms in a table. (This cannot be currently done because of how the multiple selects are built.)
- Add option for multiple checkbox input handler.
- Shore up validation. Currently, only the registration service attempts to validate (checking for required fields). A user can subsequently delete all the info that was required without error (in edit profile mode), which I’m sure we don’t want.
- Possibly add client-side validation option using jquery. I personally like the jquery-validate plug-in.
[li]Dynamic creation of form elements based on service-based lists in the config file. For example:
$registerFields='username,fullname,email,password,password_confirm';
$profileFields='email,fullname,state,country,phone,password,password_confirm,etc';
...etc...
This would be a major change, but could cut down on maintaining duplicated data across several form templates.[/li]
That’s my laundry list. I’d love to contribute ... let me know.
Cheers,
Jim
------
Server: *nix, ModX Evo 1.0.4, Apache 2.x, PHP 5.x, Mysql 5.x.