Bringing Evo back to life again

• • 
  • 1,098 Posts
  microcipcip Reply #361, 14 years, 4 months ago

  Quote from: leif.langsdorf at May 16, 2012, 08:47 AM

  I like to have two placeholders [*prev*] and [*next*] build right into the core. Pointing to the previous/next document based on the current folder.

  I use this snippet for that: http://modx.com/extras/package/prevjumpnext
  
  Jertix.org -> Web Design & Development, Motion Graphics | Follow me on Twitter | MODx Tutorials (in Italiano) | MODx Snippets (English)
• • ☆ A M B ☆
  • 24,524 Posts
  sottwell Reply #362, 14 years, 4 months ago

  Previous and next according to what criteria? Create date? Publish date? Menuindex? Alphabetical listing? Ascending or descending order? That's why the snippet is a much better solution, as it gives the ability to configure what the items are sorted by as well as a number of other optional properties.
  Studying MODX in the desert - http://sottwell.com
  Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
  Join the Slack Community - http://modx.org
• • 
  • 222 Posts
  Stefanie Reply #363, 14 years, 4 months ago

  I agree with Susan and microcipcip, that is a typical job for a snippet. And it is wonderful. that there is already a solution available.
  
  

  ---

  
  We have the first issue on GitHub, thank you, kp52, for the detailed information including the solution how to solve it.
  
  Please don't ask me, why GitHub made it a nineteen, I really don't know.
  Gone away and found a better place to stay
• • 
  • 928 Posts
  kp52 Reply #364, 14 years, 4 months ago

  why GitHub made it a nineteen

  I think an issue is auto-generated when you send a Pull request. At least, that's what happened just now when I sent one (nice bit of training for me - I came across a simple case-change bug and fixed it).
  :) KP
• • 
  • 222 Posts
  Stefanie Reply #365, 14 years, 4 months ago

  I discussed with yama, that we merge the changes, that I've done into the 1.1.dev.japanese branch, because otherwise we wouldn't get the sources to one source.
  
  The commit done by kp52 is merged into both branches, 1.1.dev.japanese and 1.1.dev.clearing-japanese.
  
  I've asked yama to commit his latest changes to the DocumentParser class again. I will be waiting with my work on that class, until he has done this.
  Gone away and found a better place to stay
• • ☆ A M B ☆
  • 1,231 Posts
  yama Reply #366, 14 years, 4 months ago

  OK, wait one or two days. I re-commit it.
• • ☆ A M B ☆
  • 1,231 Posts
  yama Reply #367, 14 years, 4 months ago

  https://github.com/sjstoelting/evolution/commits/1.1.dev.japanese/
  Completed.
• • 
  • 222 Posts
  Stefanie Reply #368, 14 years, 4 months ago

  I've finished the work on the file manager/includes/document.parser.class.inc.php that contains the classes DocumentParser and SystemEvent.
  
  The branch 1.1.dev.clearing-japanese is not needed any-more and I delete that branch within the next days. The coding standards are met, each method has phpDocumentator tags, and nearly all methods have only one exit with a return instead of multiple exits through the whole method.
  
  The current development branch for yama and me is https://github.com/sjstoelting/evolution/commits/1.1.dev.japanese/.
  
  Next step is to get the changes with constants instead of strings into that branch.
  
  After working so long on that one thing, I thought I would never see the end of the tunnel
  Gone away and found a better place to stay
• • 
  • 486 Posts
  nickf08 Reply #369, 14 years, 4 months ago

  awesome work Stefanie! you are doing a phenomenal job.
  Web design Adelaide
  http://gocreate.com.au
• • 
  • 222 Posts
  Stefanie Reply #370, 14 years, 4 months ago

  The constants are done and available through https://github.com/sjstoelting/evolution/commits/1.1.dev.japanese/. That does mean, with a development environment, that supports phpDocumentator tags and auto-completion, the work is much easier. In addition you can avoid typos by using constants.
  
  Next I will work on the DBAPI again. I'm going through the PDO code of the Japanese fork and compare it to ezSQL. The Japanese PDO class might help in some cases, where with ezSQL rewrites of code have to be done.
  
  
  Gone away and found a better place to stay

This discussion is closed to further replies. Keep calm and carry on.