We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
    • 21101
    • 169 Posts
    hello

    i have the last version, and still the weblink bug sad
      Play no games
      • 25663 MODX Staff
      • 12,272 Posts
      negz, and the weblink bug would be?
        Ryan Thrash, MODX Co-Founder
        Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
        • 21101
        • 169 Posts
        sorry grin

        the blank page with the link undecided
        like that: http://www.c4w.fr/v3/page-nos-services.html

        wink
          Play no games
          • 19888
          • 2 Posts
          i still have the same weblink problem too. :’(
            • 3763
            • 155 Posts
            Some snippets cause an error, for me the Google Analytics snippet:
            http://modxcms.com/forums/index.php/topic,4537.0.html

            Thanks, Boby.
              ...my Photo Gallery on Flickr...
              • 2862
              • 2 Posts
              hi,

              I had the weblink problem too. After downloading the complete modx directory for investigation from my webserver I found an strange statement in
              file: document.parser.class.inc.php
              on
              line: 1071

              I found the following statement.
              // check whether it's a reference      if($this->documentObject['type']=="reference") {          // if it's an internal docid tag, process it
                        if(strpos($this->documentObject['content'],'[~') !== false) {              // generate a url              $this->documentObject['content'] = $this->rewriteUrls($this->documentObject['content']);          }          $this->sendRedirect($this->documentObject['content']);      }


              For me this looks very >>mh<<. Are there really so many comments in one line? I decided to downloaded the modx tar.gz file and looked there if this line is really ok. And ... tata. The line in the original tar.gz file was different. It looks like this:

                    // check whether it's a reference
                    if($this->documentObject['type']=="reference") {
                        // if it's an internal docid tag, process it
                        if(strpos($this->documentObject['content'],'[~') !== false) {
                            // generate a url
                            $this->documentObject['content'] = $this->rewriteUrls($this->documentObject['content']);
                        }
                        $this->sendRedirect($this->documentObject['content']);
                    }


              After changing the lines in the dowloaded file from the my webserver. I uploaded it again and enjoyed the working weblinks.

              I guess that there where some upload problem from an windows machine into an linux server. Perhaps there where some problems with the notorious ’\n’ ’\r\n’ stuff. But I really do not know if this was relaly the problem.

              !!! THIS CHANGES COMES WITHOUT ANY WARANTIES. I AM NOT SHURE IF THERE ARE NO SIDE EFFECTS. USE THIS ON YOUR OWN RISK !!!

              But, perhaps someone of you have the same weblink ploblem. Perhaps it is fixable with this.
              It would be nice if an developer could look check the above code, because it seems not an exotic problem.
                • 22303 MODX Staff
                • 10,725 Posts
                That was indeed a problem we encountered, but this should be resolved in 0.9.2.1 -- I’ll double check the repository and make sure this is definitely addressed in all future versions if it is still an issue in that package, but as you indicated, it does not seem to be an issue with the original file in the download package. I’m thinking perhaps when you upgraded, the FTP of that file may have failed for some reason, and you still had a previous version there, but without knowing more about your situation, I can’t make a better evaluation at this time.
                  • 263
                  • 52 Posts
                  Thanks a million, batailon, very well spotted!

                  It’s quite beyond my competances, but I would guess that unzipping MODx on the remote server somehow corrupted the file, coz when I look at original zips, 0.9.2 and 0.9.2.1, on my machine, all is ok.

                  And welcome to MODx!
                    • 2862
                    • 2 Posts
                    Thanks for the fast reply OpenGeek.

                    OK, this afternoon I tried to figure out what’s the problem with the weblink stuff. So here are my results:

                    First, I started with modx 0.9.2.1. I did not upgrade from any earlier version. My webspace and database was 100% clean and virgin.

                    This afternoon I downloaded new tar.gz and zip files from version 0.9.2.1. Unzipped both and looked at the relevant file. I opened them with notepad.exe under windows. And the problem is still there!

                    So I decided to open the files in an hex editor. Every line in the file has a windowslike newline sign with ’\r\n’ (0x0d,0x0a). But not on the relevant lines starting from line 1071. There was only an ’\r’(0x0d) at the end of a line.

                    After downloading the file from my windows machine with filezilla(in ASCII mode) the magic happens. The ’\r’(0x0d) character is missing in the file on the server. In Binary mode the files was not changed. I do not know if this behavior is an filezilla bug.

                    So please recheck the files, for example use notepad.exe >:( under windows.
                    It would be nice if someone could fix the newline problematic in document.parser.class.inc.php.

                    Oh, before I forget: Thanks to all of the guys working on modx. It’s really cool.
                      • 32241
                      • 1,495 Posts
                      To fix the problem with QuickEdit, when updating TV as described in this post.

                      Look for a file located in assets/modules/quick_edit/editor.class.inc.php
                      Go to line number 309.
                      It suppose to look like this:
                          $modx->db->update(array('editedon'=>$now, 'editedby'=>$time), "{$pre}", "id = '{$doc_id}'");

                      Change the code above with this
                          $modx->db->update(array('editedon'=>$now, 'editedby'=>$time), "{$pre}site_content", "id = '{$doc_id}'");


                      Hope it helps non-programmer user in this forum.

                      Sincerely,
                        Wendy Novianto
                        [font=Verdana]PT DJAMOER Technology Media
                        [font=Verdana]Xituz Media