Strange : Quickedit h1 style conflict (FF 1.5/Win)

I have come accross this strange thing : the h1#QE_Title quickedit style is conflicting with my pages style, but only in Firefox 1.5/Win. It doesn’t appear in Opera nor in IE

here is the capture :



The h1#QE_Title is a contextual style and should not be affected by the h1 style from my pages css, but it does. Probably a bug in Firefox’s engine, I can’t see why this problem should occur... Just thought I would share, see if anyone has come accross this too...

Yes, I noticed the problem too, Quickedit title goes left with an indent rule on h1 in my css.

In the next release I’ll define some more CSS so this sort of thing won’t happen.

There is an easy fix you can apply to your CSS though.
The Toolbar HTML is always inserted right after the <body> tag so if you wrap your template in a div with a unique id (let’s say body_div) and then change your CSS to only apply to h1s within that div then none of your styles should affect the toolbar.



The same thing can be done with other elements.

Thanks for confirming, Xeres.

Adam, thanks for the solution.

I have solved this changing h1 to h6 in
assets\modules\quick_edit\output.class.inc.php on line 245



Your solution is better though, I’ll switch back to it.

Quote from: aNoble at Jan 03, 2006, 12:40 PM

In the next release I’ll define some more CSS so this sort of thing won’t happen...so if you wrap your template in a div with a unique id

So am I correct in thinking that the QE will get the more specific CSS tags in the future? Because forcing the user to put their template in a <div id="something"> tag would be kind of a pain as then all meaningful styles, in order to maintain specificity, would have to be declared with #something in front of it.

I would say QE has pretty specific tags already. h1#QE_Title is pretty specific and the bug I reported has no reason other than faulty interpretation by Firefox (for once, it’s not IE...).

You can still use h1 in your template’s CSS, I guess next FF release will fix that (let’s hope so...).

Quote from: davidm at Jan 04, 2006, 04:27 PM

You can still use h1 in your template’s CSS, I guess next FF release will fix that (let’s hope so...).

Did you report the error to the FF team?

Didn’t have time to do so, but most certainly will !

Quote from: davidm

Dang- did it again. You’re right of course. I’ll have to read the code and forum more carefully next time. I’ve had too many meetings today distracting me from the important stuff!

Try the following CSS file to see if it fixes the strange inheritance problems. I just ran into the same thing on the new MODx template!

It goes in assets/modules/quick_edit/styles/