[0.9.1] Known Issues & Resolutions

sotwell, you made my day! thanks a lot .. missing <?php is it.

Hi there,

I don’t recall seeing this issue in this topic, but I think this is a known issue that should be fixed in the next release. The 404 error page returns the code 200 so it is getting indexed by search engines. Is there a way to fix only this issue?

Thanks.

This is a known issue in the bugtracker and is fixed for the next release.

Can core coders check this for me?

Here is the error that are being reported when somebody using the newsletter snippet. It’s causing that, because he is not using SEF, while I hard coded the ? on the address, but if you guys see this carefully, basically it seems to me that there is a chance of SQL injection.

http://modxcms.com/forums/index.php/topic,2421.msg24218.html#msg24218

I tried to do the same thing without any SEF tunred on, but I didn’t receive any error, while he got this error. If somebody can confirmed it for me, that will be awesome.

Quote from: rthrash at Feb 17, 2006, 09:02 AM

I’ve seen the double media path as well. I’m not sure what’s causing it, but it’d be good to find out. Thanks for the great work on regClient...

From what I can tell, it’s putting the code registered with regStartupScript, regClientStartupHTMLBlock, etc twice... tracing the code I found the scripts being included twice: in outputContent() as well as executeParser(), both in \manager\includes\document.parser.inc.php. I’m not intimately familiar with how the code operates yet but I think that the solution is to comment out lines 380 through 390... not sure if this breaks something else too or not.

Even with the fixed document parser from this post and by applying evan’s fix to it, the regClientCSS or regClientStartupScript still don’t work if calling snippet uncached in an uncached document. Did someone have a fix for this? Sorry if I have just missed it.

The fix for regclientstartupscript is the one located on this thread
http://modxcms.com/forums/index.php/topic,1942.msg18261.html#msg18261

Follow along the code and conversation on that, then you will be able to fix yours

Quote from: Djamoer at Apr 06, 2006, 11:56 AM

Follow along the code and conversation on that, then you will be able to fix yours

Yes, I did that. Kunal Kapoor has all the fixes you posted in his modified document parser what I use. And I also did the changes that evan posted to fix the thing that the scripts were registered twice. Still, If I have [!mySnippet!] in an uncached document, it doesn’t do regClientCSS or regClientStartupScript.

Quote from: doze at Apr 06, 2006, 12:13 PM

...If I have [!mySnippet!] in an uncached document, it doesn’t do regClientCSS or regClientStartupScript.

Good catch doze -- please add to the tracker if you don’t mind. This is a problem because the scripts are only registered before looking for uncached snippets. I’ll have to explore the best way to approach it, but off the top of my head, a plugin would be required to perform the same actions in the OnWebPagePrerender event. In fact, now that I think about it, perhaps these should only be added if a default plugin to do so is enabled. Just a thought...either way, it’s a bug...

Quote from: OpenGeek at Apr 06, 2006, 07:19 PM

Quote from: doze at Apr 06, 2006, 12:13 PM

...If I have [!mySnippet!] in an uncached document, it doesn’t do regClientCSS or regClientStartupScript.

Good catch doze -- please add to the tracker if you don’t mind. This is a problem because the scripts are only registered before looking for uncached snippets. I’ll have to explore the best way to approach it, but off the top of my head, a plugin would be required to perform the same actions in the OnWebPagePrerender event. In fact, now that I think about it, perhaps these should only be added if a default plugin to do so is enabled. Just a thought...either way, it’s a bug...

Ehmm... I think the one that I provided in the previous post and on bug tracker works just fine though.
Anyway, it works on me, but it doesn’t me that it’s the best way to go.
Btw, it needs the fix from Adam’s as well.

Take care.