Support/Comments for Jot

398 Posts

bS Reply #31, 20 years ago

the scrolling would make the page look ugly imho

it’s better to maybe break the "words" up if they exceed a maximum length and put a space between and/or have them be unpublished so a moderator can check it first.

Armand Pondman
MODx Coding Team
:: Jot :: PHx

786 Posts

kjaebker Reply #32, 20 years ago

I agree it would look ugly laugh

Just offering up some other ideas.

Sounds like you have a good plan to solve this though.

518 Posts

yentsun Reply #33, 20 years ago

great snippet. Id like to use it but I see some validation issues like:

- using ’&’ istead of html entity ’&’ in forming links
- this typo

’<script text="type/javascript">’ (should be ’<script type="text/javascript">’)

I managed to fix most of them, but still cannot replace ’&’ in links before ’jv’ parameter

thanks

http://modx.ru - российская поддержка MODx
http://newscup.ru - экспериментальный проект
http://yentsun.com - персональный сайт

398 Posts

bS Reply #34, 20 years ago

Quote from: yentsun at Oct 04, 2006, 08:35 AM

- using ’&’ istead of html entity ’&’ in forming links

I will pas the urls with & in next version. In the mean time you can use the template modifiers to escape the link placeholders:

Change [+jot.link.view+] to [+jot.link.view:esc+]

I haven’t checked the templates yet for validation issues.. I will look into this.

Armand Pondman
MODx Coding Team
:: Jot :: PHx

518 Posts

yentsun Reply #35, 20 years ago

Thanks Armand.
I will recommend Jot on modx.ru as a pro comments app.

http://modx.ru - российская поддержка MODx
http://newscup.ru - экспериментальный проект
http://yentsun.com - персональный сайт

518 Posts

yentsun Reply #36, 20 years ago

Mayabe I’m the first russian who uses jot...and so I found that cyrillic characters are not processed correctly in guestnames (when an unregistered user enters his name). I use utf-8 in MySQL.

http://modx.ru - российская поддержка MODx
http://newscup.ru - экспериментальный проект
http://yentsun.com - персональный сайт

398 Posts

bS Reply #37, 20 years ago

I think the & from the character entity gets escaped one to many times..
Will also fix this in new version. Keep that feedback coming because i’m close to making it out of beta this way.
Thanks for the detailed (screenshots) reports

QuickFix (haven’t had the time to check it but this may solve the problem)

in chunkie.class.inc.php search for:

case "esc":
  $output = htmlspecialchars($output);
  $output = str_replace(array("&#91;","&#93;","&#96;"),array("[","]","`"),$output);
  break;

replace with:

case "esc":
  $output = preg_replace("/&(#[0-9]+|[a-z]+);/i", "&$1;", htmlspecialchars($output));
  break;

Or the problem arrises where the translation from the stored strings (customfields)
in xml occures (xml character encoding problem perhaps).. so Maybe i have to take a deeper look.

Armand Pondman
MODx Coding Team
:: Jot :: PHx

518 Posts

yentsun Reply #38, 20 years ago

Well that didn’t help unfortunately. At least the strings do not look so scary now

http://modx.ru - российская поддержка MODx
http://newscup.ru - экспериментальный проект
http://yentsun.com - персональный сайт

120 Posts

jlivingston Reply #39, 20 years ago

So glad to see Replix upgraded. It had been so long that I stopped checking. Not that I’m complaining; I’m a developer myself, and I know what it takes to put this kind of thing together. Thanks a whole, whole lot.

Anyhow, is there a way to trigger an error when someone does not enter the captcha code correctly? You know, to let them know there’s a problem that they need to correct? My sister tried to leave a long comment on my site a while back. She submitted it; the page refreshed, then she left. She never scrolled down to see her comment, where she would’ve found out that her comment did not go through. Had she been aware there was a problem, she could’ve salvaged her comment, because the form re-populates itself. As it was, she closed the window and went on, and all her work went to the wind.

I feel like I’m just overlooking it. I’ve read much of the documentation, but it’s possible I missed it.

Thanks again.

Commotion

398 Posts

bS Reply #40, 20 years ago

Quote from: yentsun at Oct 05, 2006, 04:38 PM

Well that didn’t help unfortunately. At least the strings do not look so scary now

I confirmed the problem and it has something to do with the XML library involved (the original encoding gets "crippled" when read from the XML node)

Quote from: jlivingston at Oct 05, 2006, 06:43 PM

Anyhow, is there a way to trigger an error when someone does not enter the captcha code correctly? Y
I feel like I’m just overlooking it. I’ve read much of the documentation, but it’s possible I missed it.

Yes there is.. actually it’s the first error possible

There are currently 5 error codes possible

-2: Your comment has been rejected.
-1: Your comment has been saved, it will first be reviewed before it is published.
1: The security code you entered was incorrect.
2: You can only post once each [+jot.postdelay+] seconds.
3: You forgot to enter a comment.

It’s only possible to remove the message display by removing the message from the template.

Armand Pondman
MODx Coding Team
:: Jot :: PHx