We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
    • 4429
    • 429 Posts
    Just noticed that my stats are not working correctly.

    Firstly the views stat only goes up when somone clicks on the ad. Thent he views state jumps by 5 and the clicks goes up by 2. How is it that this is happening?
      • 4429
      • 429 Posts
      Quote from: x0149128 at Nov 05, 2009, 03:49 AM

      Just noticed that my stats are not working correctly.

      Firstly the views stat only goes up when somone clicks on the ad. Thent he views state jumps by 5 and the clicks goes up by 2. How is it that this is happening?

      Has anyone solved this issue? That is the incorrect stats. Its not very handy if you need to report your stats to advertisers
        • 29902
        • 72 Posts
        I noticed the problems with the stats too, and I discovered that the stats for the clicks are multiplying with how many days the ad has been "on". So i looked in the adsmanager.inc.php file and saw the sql that gets the stats, and I think it has something to do with that somewhat complicated sql so I made my own, but I havent gotten around to showing the "views", only the clicks as we use google analytics to do find out how many views a page has gotten.

        I saw in the database that clicks and views are correctly counted.

        The SQL is on line 390 in adsmanager.inc.php. I just commented out this and put this in instead:

        $query = "
        SELECT {$this->db_prefix}ads.id, {$this->db_prefix}ads.tags, {$this->db_prefix}ads.title, COUNT({$this->db_prefix}ads_clicks.id) AS bclick, {$this->db_prefix}ads.id as bshows, {$this->db_prefix}ads.id as ctr
        FROM {$this->db_prefix}ads
        INNER JOIN {$this->db_prefix}ads_clicks ON {$this->db_prefix}ads_clicks.banner = {$this->db_prefix}ads.id
        GROUP BY {$this->db_prefix}ads.id 
        ";


        I hope someone can take my findings and make it even better so we can make the views show the right amount.
          ...I believed it was Friday...
          • 30215
          • 79 Posts
          I must say that althoug the functionality is quite good it really needs to be rewritten.

          Firstly, using <? is really deprecated, a lot of hosting have this short tags disabled. And actually this is causing also the "404" problem mentioned in this thread (took half an hour to find that out).
          Secondly, you can’t use function "goto" anymore in PHP 4.3, it is reserved word now.

          The scripts also behaves very ilogical sometimes. For example I accidently tried to upload very large image and the script said that the "banner" dictionary doesn’t exist or is not writable.

          I’m quite disappointed. I hoped in better ads managment in a such large cms smiley
            -- sorry for my english, bad teacher smiley
            • 16702 ☆ A M B ☆
            • 536 Posts
            wonderful! thank you! smiley

            P.S in system events i get this error:
            Undefined index: manager_lang_attribute

            can you help me?

            //one more question smiley
            can i fix group of banners in one place? and another group in another place - in same document?

            new.

            i thing need little modification on adsmanager.inc.php:

            	var $image_tpl = "<div class='banner'><a href='[+link+]' target='_blank'><img src='[+img+]' alt='[+title+]' width='[+width+]' height='[+height+]'></a></div>\n";
            	var $flash_tpl = "<div class='banner' id='flashcontent[+id+]'>
            
            


            to

            	var $image_tpl = "<div class=\"banner\"><a href=\"[+link+]\" target=\"_blank\"><img src=\"[+img+]\" alt=\"[+title+]\" width=\"[+width+]\" height=\"[+height+]\"></a></div>\n";
            	var $flash_tpl = "<div class=\"banner\" id=\"flashcontent[+id+]\">
            


            I do not know why but Chrome does not show images, after fix everything is fine.
              palma non sine pulvere
              • 29902
              • 72 Posts
              Is this module updated at all after all the feedback we have been given? Could someone comment on this?
                ...I believed it was Friday...
                • 13137
                • 204 Posts
                The buttons don’t work in Firefox, only in IE, so I didnt look at it any further.
                  • 8548
                  • 104 Posts
                  Hi, has anyone got this probleme?
                  Cannot add banner! Check if [/assets/snipplets/adsmanager/banners] exist and if it is writeable!

                  i’ve checked my permission and i’ve put them all 777 for that folder ans I still get this message.

                  help
                    • 20349 ☆ A M B ☆
                    • 453 Posts
                    Just installed it to try it out and the Module (buttons) is not working on Google Chrome...
                      BASE - Web Design Studio
                      MODX Ambassador

                      Website