Discuss: native threaded forum for MODx Revolution

☆ A M B ☆
872 Posts

lossendae Reply #41, 15 years, 9 months ago

@splittingred

1. I agree, the way it’s handled now is quite good.
I was more thinking about html in the resource instead of the development approach where we can load the pages directly from the file system.
For now, there are some default html markup in the resource itself and that would not be easy to override.
Pages should be loaded via chunks while keeping resources approach.

2. I would not like smarty approach.
The actual way of doing thing with modx tags is really good and stays within the modx facilities.
Plus, performance wise, would it be good to allow both modx and smarty parsing ?
Maybe we should poll about that subject ?

3. I’ve made some change to allow theme on git (last commits).
But it only work with the development process which load the pages from chunks instead of using the HTML embedded in resources.
I don’t know if caching is broken with this method.

Maybe it would be interesting to use Formit and Login snippets for the forms used in Discuss since they already have lot of options usable in the Discuss context.
I would like to start working on that only if Shaun agreed with it.

Other thing, anybody have any idea on how to extend the DiscussPost table with an extra field to allow custom post type.
It would allow people to propose custom first post for a thread like Poll, Resource link (to behave like Quip) and whatever we can imagine.

@goldsky
There are some limited front end editing already available, but it would be nice to extend what can be set with Front end like managing categories, move topics, change some settings, etc...

Can i encourage you to join the development actively laugh

?

It would be nice to have a new release "more" stable from here to christmas and Shaun is quite busy with many tasks.

4,149 Posts

splittingred Reply #42, 15 years, 9 months ago

I’d be ok with FormIt usage in Discuss.

As for the pages-as-chunks... I guess that’s fine. Before you do, it’d be a good idea to test the speed, though, since that would affect caching. Make sure it isn’t too deleterious.

shaun mccormick | bigcommerce mgr of software engineering, former modx co-architect | github | splittingred.com

☆ A M B ☆
872 Posts

lossendae Reply #43, 15 years, 9 months ago

Thanks for the quick answer, i’ll use FormIt then.

Concerning pages and cache, if i take Quip as an example, the default chunks are file based. Does it mean that they are not cached ?
If they are, then why would chunk based Pages with Discuss lose this ability ?

4,149 Posts

splittingred Reply #44, 15 years, 9 months ago

They are not cached, correct.

However, the data in the Resource *is*, so you’d lose performance on that by moving it to a chunk. I’m not sure it’d be really enough to matter, though. You’d have to test.

shaun mccormick | bigcommerce mgr of software engineering, former modx co-architect | github | splittingred.com

☆ A M B ☆
3,112 Posts

goldsky Reply #45, 15 years, 9 months ago

Quote from: splittingred at Nov 10, 2010, 10:06 AM

My main concern is URL alias handling and caching.

I believe we can treat this like Vanilla does.
http://vanillaforums.org/discussion/13567/vanilla-2.0.14-released

How could you cache a realtime discussion?
If it’s about the template, we can use the smarty’s chaching, no?
http://www.smarty.net/manual/en/caching.php
But I can see that http://api.modxcms.com/modx/smarty/modSmarty.html options are still limited.

Quote from: lossendae at Nov 10, 2010, 11:47 AM

@goldsky
There are some limited front end editing already available, but it would be nice to extend what can be set with Front end like managing categories, move topics, change some settings, etc...

Can i encourage you to join the development actively ?

It would be nice to have a new release "more" stable from here to christmas and Shaun is quite busy with many tasks.

I’m about to.
I need time to dig deeper with the existing codes.
If you have handled the templating, I’ll look around to see others.

Rico
Genius is one percent inspiration and ninety-nine percent perspiration. Thomas A. Edison
MODx is great, but knowing how to use it well makes it perfect!

www.virtudraft.com

Security, security, security! | Indonesian MODx Forum | MODx Revo's cheatsheets | MODx Evo's cheatsheets

Author of Easy 2 Gallery 1.4.x, PHPTidy, spieFeed, FileDownload R, Upload To Users CMP, Inherit Template TV, LexRating, ExerPlan, Lingua, virtuNewsletter, Grid Class Key, SmartTag, prevNext

Maintainter/contributor of Babel

Because it's hard to follow all topics on the forum, PING ME ON TWITTER @_goldsky if you need my help.

4,149 Posts

splittingred Reply #46, 15 years, 9 months ago

Quote from: goldsky at Nov 10, 2010, 08:30 PM

But I can see that http://api.modxcms.com/modx/smarty/modSmarty.html options are still limited.

Actually, modSmarty just *extends* Smarty, so whatever methods Smarty has, so does modSmarty.

Secondly, loss/goldsky - if you could PM me, I’d like to talk about getting a dev team for Discuss. Meaning repo access. Thanks!

shaun mccormick | bigcommerce mgr of software engineering, former modx co-architect | github | splittingred.com

☆ A M B ☆
3,112 Posts

goldsky Reply #47, 15 years, 9 months ago

shaun,
Did you place the snippet’s tpls under the core/ folder on purpose?
I believe that the core/ folder can be set to be out of the web-root.
I’ll move it to the assets/ folder if you don’t mind.

And what’s the purpose of the connector context?

Rico
Genius is one percent inspiration and ninety-nine percent perspiration. Thomas A. Edison
MODx is great, but knowing how to use it well makes it perfect!

www.virtudraft.com

Security, security, security! | Indonesian MODx Forum | MODx Revo's cheatsheets | MODx Evo's cheatsheets

Author of Easy 2 Gallery 1.4.x, PHPTidy, spieFeed, FileDownload R, Upload To Users CMP, Inherit Template TV, LexRating, ExerPlan, Lingua, virtuNewsletter, Grid Class Key, SmartTag, prevNext

Maintainter/contributor of Babel

Because it's hard to follow all topics on the forum, PING ME ON TWITTER @_goldsky if you need my help.

4,149 Posts

splittingred Reply #48, 15 years, 9 months ago

Quote from: goldsky at Nov 14, 2010, 06:40 PM

shaun,
Did you place the snippet’s tpls under the core/ folder on purpose?

Yes, for better security.

I believe that the core/ folder can be set to be out of the web-root.
I’ll move it to the assets/ folder if you don’t mind.

I do mind; assets/ should only be for JS/CSS/images. Nothing else needs to be web-accessible. The tpl’s should stay in core/ for better security.

And what’s the purpose of the connector context?

What do you mean? The connector.php file? If so, that’s for allowing the mgr 3PC access to Discuss processors.

shaun mccormick | bigcommerce mgr of software engineering, former modx co-architect | github | splittingred.com

☆ A M B ☆
3,112 Posts

goldsky Reply #49, 15 years, 9 months ago

hm... ok.

Rico
Genius is one percent inspiration and ninety-nine percent perspiration. Thomas A. Edison
MODx is great, but knowing how to use it well makes it perfect!

www.virtudraft.com

Security, security, security! | Indonesian MODx Forum | MODx Revo's cheatsheets | MODx Evo's cheatsheets

Author of Easy 2 Gallery 1.4.x, PHPTidy, spieFeed, FileDownload R, Upload To Users CMP, Inherit Template TV, LexRating, ExerPlan, Lingua, virtuNewsletter, Grid Class Key, SmartTag, prevNext

Maintainter/contributor of Babel

Because it's hard to follow all topics on the forum, PING ME ON TWITTER @_goldsky if you need my help.

☆ A M B ☆
536 Posts

Last Of The Romans Reply #50, 15 years, 9 months ago

hallo guys,
today i try discuss and get that error, some ideas?

Fatal error: Call to a member function lexicon() on a non-object in /home/user/public_html/core/components/discuss/model/discuss/dispost.class.php on line 286

thanks

palma non sine pulvere