0.9.5 test builds

Quote from: kylej at Sep 15, 2006, 03:04 PM

I have just commited a way to delete categories, so then you can add a new one with the correct category and delete the old one.

Kyle... how do you access deleting categories? I see the delete category processor and action in the main manager index file, but no way to trigger it from the interface.

I would presume that deleting categories would have to follow somewhat the same model as deleting TVs or templates, with code to at least give a warning for categories that still have items using them?

Also, I see that the permissions check uses "edit" permissions. This would produce the same issue that I ran into with moving items, it allows users with minimal "viewing" permissions to actually delete categories. It should use "save" permissions instead.

Dutch language file can be easaley fixed by removing the 2nd * from the comments at the top

<?php
/**
* Bestandsnaam:

needs to be:

<?php
/*
* Bestandsnaam:

In revision 1531
in the light theme when Hiding the document tree by clicking the hide tree button the logout/messages and revision number line is pusched down behind the menubar.

the document tree in the light theme has scroll bars added in IE in FF no scroll bars (that is good)

lots of images are missing in the old modxtheme (but that wil leave the building I think?)


Schedule is still missing the titles and coment text

but there’s a couple of oddities floating about still...

Okay, I see the problem ....

In both mutate_template.action.php and mutate_htmlsnippet.action.php, lines 35 to 46 need to be wrapped in :


And, line 49 needs to change to:


To correct the array_merge issue in mutate_htmlsnippet.action.php, this needs adding in at line 52:


I haven’t got SVN access at work so I’ll get these committed later (unless someone beats me to it )

EDIT: I have submitted changes to my branch in SVN to correct these problems and a few other ones identified in the public beta 3 thread as well. I’ve placed a patch onto the public beta 3 thread as well temporarily until the main beta package can be updated.

Quote from: rthrash at Sep 26, 2006, 12:42 PM

Anyone opposed to nuking the original MODx theme?

Arguments in favour of nuking:
* Having ran an upgrade to Beta 3, the old theme is broken. No point keeping a broken theme.
* MODxLight is really nice.
* Users can always recreate theme and share it if there’s enough demand for it.

Arguments against nuking:
* All the arguments against are fixable, and would have to be fixed at some point so it may as well be now.

Things That Have To Be Fixed If It Is Nuked:
* Polls Manager module foolishly directly references MODx theme css; there may be other modules that do this. They need fixing.
* Need to make clear to people that old theme is incompatible (an upgrade over the top would probably leave the old theme selectable).
* Need to automatically change people’s preference to MODxLight (if it isn’t MODxGreen) on upgrade.

So I pretty much come down to nuking it. Except that I have a different idea:

Other Idea:
* Instead of upgrading "MODx" template, replace it with a blue & orange version of MODxLight. That way it would vaguely match the old theme without actually being the eto theme. Keep all the new icons and layout, just change the colours in the CSS and the images. This would take far less time to do, presumably, and circumvents many of the issues with dropping a previously default theme.

--

Also, has anyone noticed that the top bar says "Messages ( ? / ? )" regardless of how many messages are in the inbox?

* Polls Manager module foolishly directly references MODx theme css; there may be other modules that do this. They need fixing.

Indeed, how foolish! I have updates cooking for all my modules to address this and some other bug fixes and general tidy-ups, I’m hoping to be able to start rolling them out over the weekend if all goes to plan.

Aside from them, I think there are probably only a handful of other modules by other people that might need updating ... perhaps worth mentioning on the public forum to give them prior notice.

Also, has anyone noticed that the top bar says "Messages ( ? / ? )" regardless of how many messages are in the inbox?

Yes, I’ve noticed that. (I seem to remember a fix going in for this from someone at some point but I may be mistaken, I’ll check the previous commit messages - I may just be imagining that one)

All manager themes and action are not updated in rev 1531.

I’ve updated my previous manager fix for rev1531, using last updated action/ files

Quote from: PaulGregory at Sep 27, 2006, 04:41 AM

.....
Other Idea:
* Instead of upgrading "MODx" template, replace it with a blue & orange version of MODxLight. That way it would vaguely match the old theme without actually being the eto theme. Keep all the new icons and layout, just change the colours in the CSS and the images. This would take far less time to do, presumably, and circumvents many of the issues with dropping a previously default theme.

..

we had the same idea !

take a look here!:

I like that. I’ll definitely use that on my older sites.