MODx 0.9.1 rev 609 (internal testing)

Double post ;-)

I first did a minimal install with all modules/snippets/etc installed, everything is fine.

Then I upgraded, upgraded everything but also installed the demo site.

Now, there are 2 versions of FlexSearchForm but with different descriptions:
- Robust site search with like and partial matching.
- Splits Search and Results Pages

Same for NewsListing, Getstats and so on and so on....

The Snippet calls don’t show up in the RTE (FCKEditor). Very bad usability!
The call is however visible in the source code view of FCKEditor

The Blog page has not so nice syntax in respect of calling the snippet:
[[NewsListing? &startID=`2` &summarize=`2` &total=`20` &commentschunk=`FormBlogComments`]]

Line 178 in NewsListing has undefined variable sortby. Not really harmfull, but it produces an php notice error.
I guess the new NewsListing needs some php error testing ;-)

Thats it for now ;-)

Remon

Quote from: R.S. at Dec 14, 2005, 11:29 AM

The Snippet calls don’t show up in the RTE (FCKEditor). Very bad usability!
The call is however visible in the source code view of FCKEditor

Yeah, this is an unfortunately by-product of the ProtectSource feature of FCKEditor. In order to ensure that ampersands (&) don’t get converted into HTML entities, it was necessary to add snippet calls as a protected source in FCKEditor. Keep in mind that the same applies to the QuickEdit tags. I know it’s a bit of an inconvenience, but it’s alot better than typing in a snippet call only to find out later that none of your parameters work.

Jeff

The parameters work as entities, it’s just very inconvenient to have to look through them when editing in true source mode. This is a major usability faux pas that needs to be reverted.

I believe the fix to restore the original FCK ampersand butchering behavior but making the snippet calls visible again is to go to assets/plugins/fck/custom_config.js and comment out lines 10 and 11:

Quote from: rthrash at Dec 14, 2005, 12:15 PM

I believe the fix to restore the original FCK ampersand butchering behavior but making the snippet calls visible again is to go to assets/plugins/fck/custom_config.js and comment out lines 10 and 11:

FCKConfig.ProtectedSource.Add( /\[\[[\s\S]*?\]\]/gi );
FCKConfig.ProtectedSource.Add( /\[\![\s\S]*?\!\]/gi );

If snippet calls still work even with ampersands as HTML entities then we can just leave out the ProtectedSource lines.

Quote from: Bravado at Dec 14, 2005, 01:07 PM

If snippet calls still work even with ampersands as HTML entities then we can just leave out the ProtectedSource lines.

Ditto.

The "Snap in top menu bar layout" manager layout option doesn’t work right. The options for each menu don’t show up in Firefox. Ugg! And I was really hoping for this one!

Strange...I have it working in three remote installations and three or four local development installations...

I’ll gather up the relevent files in my installations (l4mnu.php and 1.php from /manager/frames) and the css files, and see if I can find where the problems are.

I know in Windows you have to be sure the hover behavior file is included in the l4mnu.php file’s header, and the css needs tweaking, but I thought that got incorporated into this build.

Anyway, I’ll compare and see what I find.

Just commited rev 602 with a new QuickEdit toolbar layout. Should be Scriptaculous 1.5 friendly and I’ve tested it with Firefox 1.5, Opear 8.5 and IE 6. The only known bug is IE does some weird stuff when clicking Show links. If anyone can figure out what the problem is that’d be great. I’m sure I can figure it out but it’s getting late and it’s a fairly minor thing.

I haven’t done any real extensive testing so please run it through the hoops and let’s get 0.9.1 out the door!

(I’m attaching a zip file of the assets/modules/quick_edit folder. You should be able to overwrite your existing rev600 folder to do testing until we get a new rev out)

P.S. Just remembered that I forgot a few multi-lingual things, I’ll fix that tomorrow. For now, I’m going to bed.

This has me totally baffled. I have a site up with the previous revision, and it’s working just fine (once I fixed some coding errors involving the closing of if conditions in the wrong place). I compared the files, didn’t see anything different, so just to be sure actually copied the 1.php, l4mnu.php, and the two l4navbar.css files (one in media and one in media/modx) from the working installation to the rev600 installation, and it still doesn’t show. It’s in the source; looking at the source for the frame shows the lists there, big as life and twice as ugly.