We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
MODX Community Forums Archive

MODx 0.9.1 rev 609 (internal testing)

    • 25663 MODX Staff
    • 12,272 Posts
    Ryan Thrash Reply #151, 20 years, 9 months ago
    The problem with the implementation of the regClient stuff in 0.9.0 was that it inserted everythign at the top of the head section, which means that user-defined stylesheets or JS coudl override the behavior. The majority of devs needed the regClient to work as it does now just before the closing </head tag.
      Ryan Thrash, MODX Co-Founder
      Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
      • 25663 MODX Staff
      • 12,272 Posts
      Ryan Thrash Reply #152, 20 years, 9 months ago
      As a follow up to close this out, looks like the only major omission was the missing install SQL parser file that Susan did, which is pretty big, actually. Does anyone object to a quick 0.9.1b release with this file added back in?
        Ryan Thrash, MODX Co-Founder
        Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
        • 22303 MODX Staff
        • 10,725 Posts
        opengeek Reply #153, 20 years, 9 months ago
        Quote from: xwisdom at Dec 26, 2005, 01:08 AM

        In 0.9.0 base url was only inserted into the page when FAP were turned on.

        I don’t think the <base /> should have been removed in 0.9.1 with the hopes of using [(base_url)] before css and image tags.

        http://modxcms.com/forums/index.php/topic,1942.msg13616.html#msg13616

        IMO the <base /> makes it easier to use relative paths for images, etc when FAP is witched on.

        Make it optional and I’ll agree. I don’t want that tag inserted into my templates automatically when using alias paths. It’s just as easy for me to do this in my template if I need it, and making it optional gives users the flexibility to have it the way they want.
          Jason Coward
          Chief Architect @ MODX
          http://www.jasoncoward.com | http://twitter.com/drumshaman | https://github.com/opengeek
          • 32963
          • 1,732 Posts
          xwisdom Reply #154, 20 years, 9 months ago
          Quote from: OpenGeek at Dec 26, 2005, 03:38 PM

          Make it optional and I’ll agree.  I don’t want that tag inserted into my templates automatically when using alias paths.  It’s just as easy for me to do this in my template if I need it, and making it optional gives users the flexibility to have it the way they want.

          If optional then it should be on by default.
            xWisdom
            www.xwisdomhtml.com
            The fear of the Lord is the beginning of wisdom:
            MODx Co-Founder - Create and do more with less.
            • 32963
            • 1,732 Posts
            xwisdom Reply #155, 20 years, 9 months ago
            Why are we doing things like this:

            if (!empty($src) && array_key_exists($src, $this->loadedjscripts)) {
	if ($this->loadedjscripts[$src]) 
				return '';


            Doesn’t if (isset($this->loadedjscripts[$src])) checks to see if the element exists inside the array?

            Also, didn’t we agree to not process placeholders inside a @SELECT statement as it will not be supported in the upcoming versions? 

            $param = $modx->mergePlaceholderContent($param); 
$rs = $modx->db->query("SELECT $param;");


            CFs will support parameter passing
              xWisdom
              www.xwisdomhtml.com
              The fear of the Lord is the beginning of wisdom:
              MODx Co-Founder - Create and do more with less.
              • 4673
              • 577 Posts
              Carsten Reply #156, 20 years, 9 months ago
              quickeditor strangeness:

              I just noticed some weird behavior.
              If I use WWW.domain.com I can’t see the editor bar. However, if I use domain.com then I can. What gives?

              both in safari and latest FF
                Tangent-Warrior smiley
                • 1764
                • 680 Posts
                aNoble Reply #157, 20 years, 9 months ago
                Quote from: Carsten at Dec 30, 2005, 12:07 PM

                If I use WWW.domain.com I can’t see the editor bar. However, if I use domain.com then I can. What gives?

                Your login is tied to a specific domain. This should affect the manager the same way as QuickEdit. It all depends on how the login cookies are set up and because QuickEdit uses the standard MODx manager login it’s not something that can be changed in QuickEdit.

                It could be changed in the manager but I think it’s probably meant to be the way it is now so that users at site1.hostingcompany.com can’t make edits on site2.hostingcompany.com, for example.
                  Adam Crownoble: obleDesign.com | [email protected] | [email protected] (Google Talk)