MODx 0.9.1 rev 609 (internal testing)

125 Posts

R.S. Reply #131, 20 years, 9 months ago

Another point with QE is that it’s getting called, even when you’re _not_ logged in into the manager.
IMHO, this should be checked _before_ starting to go on and execute QE code.
I think, this will do in the QE plugin code:

// Check if we are a manager user, if not, return immediately
if(!isset($_SESSION['mgrValidated'])) {
       return;
}

// Set configuration variables if not already set
if(!isset($mod_path)) { $mod_path = 'assets/modules/quick_edit'; }

Just before any other code in the plugin

Now, the ouput.class.inc.php.even more has this check to, which is then of course redundant...

Remon

680 Posts

aNoble Reply #132, 20 years, 9 months ago

Quote from: R.S. at Dec 22, 2005, 02:06 PM

QE looks in it’s own lang directory for the current set lang in the manager.

Ah, I put so much work into getting this to work right and then such a stupid bug blew the whole thing up. I just commited a fix and the new version sholuld work fine. QuickEdit will look in both it’s own lang directory and the main lang directory for translations. So you can add your translations in either place.

Quote from: R.S. at Dec 22, 2005, 02:41 PM

Another point with QE is that it’s getting called, even when you’re _not_ logged in into the manager.

Right again. It used to have to run even for a visitor becaus the [*#*] tags had to be turned into [**] tags but Raymond recently added the tag conversion into the core parser so it’s not really necessary anymore so I’ve added the check at the beginning as you suggested.

Thanks for catching this, after all the work I put into getting QE to be multi-lingual I’d of hated to see that bug make it into the release.

P.S. I’m not sure when we’ll get another snapshout out for testing or if we will before the 0.9.1 release. So I’m attaching the updated QE module.

Adam Crownoble: obleDesign.com | [email protected] | [email protected] (Google Talk)

125 Posts

R.S. Reply #133, 20 years, 9 months ago

Yeah, but thats how it goes. I think it has to do with usage patherns or something. Each person tends to repeats the same usage patherns all the time, and so a dev doesn’t catch all the bugs, and someone else just breaks it lags over it haha.

So, here’s another one:

PHP error debug
  Error: 	contentvariable(/home/remon/public_html/test//assets/modules/quick_edit/lang/nederlands.inc.php): failed to open stream: No such file or directory	 
  Error type/ Nr.: 	Warning - 2	 
  File: 	/home/remon/public_html/test/assets/modules/quick_edit/contentVariable.class.inc.php	 
  Line: 	63	 
  Line 63 source: 	include_once($qe_eng_path);

Also note that there are 2 // before assets. It works, but it’s not so nice....

Perhaps, if there are more of these things somewhere..... ;-)

Greetz,

Remon

125 Posts

R.S. Reply #134, 20 years, 9 months ago

Oh well, it’s a copy paste

See attached files

Remon

P.S.
VERY nice work btw, the QE is in Dutch all of a sudden

MODX Staff
12,272 Posts

Ryan Thrash Reply #135, 20 years, 9 months ago

Does anyone object to updating the default install state as follows:

Turn on using access permissions
Remove the "p" from FURL prefixes (but NOT turning on FURLs by default)
Setting use FURL aliases (but NOT alias paths)
Setting default ~~published/~~cached/searchable state to on

Also, if the signup messages come from the language files, why do we have them inserted into the database during install?

(’emailsender’,’[email protected]’),
(’emailsubject’,’Your login details’),
(’signupemail_message’,’Hello [+uid+] \r\n\r\nHere are your login details for [+sname+] Content Manager:\r\n\r\nUsername: [+uid+]\r\nPassword: [+pwd+]\r\n\r\nOnce you log into the Content Manager at [+surl+], you can change your password.\r\n\r\nRegards,\r\nSite Administrator’),
(’websignupemail_message’,’Hello [+uid+] \r\n\r\nHere are your login details for [+sname+]:\r\n\r\nUsername: [+uid+]\r\nPassword: [+pwd+]\r\n\r\nOnce you log into [+sname+] at [+surl+], you can change your password.\r\n\r\nRegards,\r\nSite Administrator’),
(’webpwdreminder_message’,’Hello [+uid+]\r\n\r\nTo active you new password click the following link:\r\n\r\n[+surl+]\r\n\r\nIf successful you can use the following password to login:\r\n\r\nPassword:[+pwd+]\r\n\r\nIf you did not request this email then please ignore it.\r\n\r\nRegards,\r\nSite Administrator’),