MODx 0.9.1 rev 538 (for internal testing only)

Line 279 has it too

Seems to work, and looks good!

hmmm,found a problem with quick edit.

In firefox 1.0.7, apply doesn’t do anything, save works. Is this a known problem?

No, not a typo. Somebody is using PHP 5

Another on quickedit:

Checked publish document (whatever it means)
Checked hide in menu (ehm, what does this one mean? It’s really not very clear to me)

they don’t do anything....

Quote from: sottwell at Nov 28, 2005, 02:23 PM

No, not a typo. Somebody is using PHP 5

Aha -- that explains why I couldn’t see the problem when testing after getting those changes. Good catch Susan.

Well, I would presume Publish Document would publish an unpublished document. If the document is already published, it shouldn’t do anything.

Hide in menu should set the "Show in menu" to be false (or 0 or whatever), the same as clearing the Show in Menu check box.

Quote from: OpenGeek at Nov 28, 2005, 02:33 PM

Aha -- that explains why I couldn’t see the problem when testing after getting those changes. Good catch Susan.

Actually, I got caught with that a little while ago, I tried to use it in my modification of NewsListing (IIRC) and of course since I don’t have PHP 5 it failed spectacularly. I really need to pay more attention!

Actually, with the new QE code, managers can finally preview unpublished documents, so the checkmark definitely has an affect, and can also unpublish a document.

Quote from: sottwell at Nov 28, 2005, 02:23 PM

No, not a typo. Somebody is using PHP 5

Oops, I’ve tried to watch out for that but I guess that one slipped by. I’ll take care of it.

Quote from: R.S. at Nov 28, 2005, 02:23 PM

In firefox 1.0.7, apply doesn’t do anything, save works. Is this a known problem?

Well looks like firefox 1.0.7 doesn’t like the prototype.js AJAX stuff. I’ll try to install it somewhere and do some testing. Are you getting any JS errors or if you refresh manually after clicking apply, publish, hide in menu, does the edit take but the refresh is broken? It’s funny than Firefox is having problems. I tested it with Firefox 1.5, IE, Opera, Safari and no problems at all.

Quote from: rthrash at Nov 28, 2005, 02:46 PM

Actually, with the new QE code, managers can finally preview unpublished documents, so the checkmark definitely has an affect, and can also unpublish a document.

Yes, and this is something else that needs testing. There is a "View unpublished documnets in frontend" checkbox in the role management screen that will allow a user to view an unpublished document.