Pre 3.3 release bug testing files

Hi Everyone,

Please see the attached TP3.3 files for testing before release.

List of changes

* update snippet and plugin to use word wraping on textarea
* update chunks, template to use FCK’s RTE
* BUG #84 - Fixed login captcha bypass (Mark)
* NewsFeed now defaults to &makerss=1
* update NewsListing with news features (Ryan & Greg)
* #msg6246 - update NewsFeed to support valid RSS2.0 tags (Mark)
* add &linktext support to NewsListing snippet
* add &tpl (chunk name) template support to NewsListing snippet. Fields - [+title+],[+summary+],[+author+],[+date+],[+linkurl+]
* load gd2 dynamically when using captcha
* fix cache path bug in cache_sync.class.processor.php
* add &aliastitle to NewsPublisher
* fix:#64 - makeURL is acting up when aliases are on and off.
* prevent duplicate alias when importing html
* fix bug when saving web user
* remove .cgi files from manager\media\browser\mcpuk\connectors\php\Commands\helpers
* fix TV checkbox delimiter bug
* add &groups parameter to WebSignup Snippet
* add Manager Interface Access to to manager user settings
* add Manager Login Startup to manager user settings
* update quickedit module
* update fckeditor

Please remember to test the installer against previous installs (upgrade process)

Good timing. I was just working on some fixes to QuickEdit. I had a really busy week last week and then got sick this weekend (my wife thinks it’s because of lack of sleep ). But I got a chance to thorw together a quick fix today.

It fixes
IE link cursor problem
Richtext editor window sizing
Checkbox/Listbox (multiselect) TV type saving


Raymond, after a quick look it seems that you have fixed the IE cursor probem and invoked some events I missed (oops). I’m working on merging my changes together with yours now. Are there any other changes you made that I need to know about?

I should have you the files in just a few minutes.

Raymond,

One quick long question about the usage of the OnBeforeDocFormSave event in the QuickEdit module. I noticed that you had changed the $value_prep variable to $content, presumeably so that a plugin could manipulate the saved values, which makes sense. However, if a plugin manipulates the $content variable when we’re editing, pagetitle, longtitle or another TV then they might get unsuspected results. It seems to me that if we use the OnBeforeDocFormSave event then we’ll have to duplicate the entire variable structure of the save_content.processor.php file which means using $pagetitle, $longtitle, $content, $intotext, $tmplvars, etc. which could complicate things a good bit.

Anyway, this is my dillema. Am I understanding this correctly? I can duplicate the save_content.processor.php files vairables and save all of the document variables and each of the documents TVs content if that’s what it takes but it seems like there should be a better way.

Do you think it would be acceptable to just deal with the content at hand, that shouldn’t be too hard. In other words, define a $longtitle variable if we’re editing the longtitle or a tmplvars[1]=’tv value’? If someone had a plugin that was meant to manipulate some other content other than what was being edited it wouldn’t have any affect but maybe that’s okay.

What do you think?

Hi Adam,

I don’t recall making any updates to the qe other than the cursor stuff. I’ve downloaded QEv6 and updated the module accordingly.

I noticed that you had changed the $value_prep variable to $content, presumeably so that a plugin could manipulate the saved values, which makes sense. However, if a plugin manipulates the $content variable when we’re editing, pagetitle, longtitle or another TV then they might get unsuspected results. It seems to me that if we use the OnBeforeDocFormSave event then we’ll have to duplicate the entire variable structure of the save_content.processor.php file which means using $pagetitle, $longtitle, $content, $intotext, $tmplvars, etc. which could complicate things a good bit.

Changed $value_prep to $content?? Where??

Not sure I’m following you here.

Quote from: xwisdom at Aug 28, 2005, 04:35 PM

I don’t recall making any updates to the qe other than the cursor stuff.

Hmm, maybe it was me Like I said I haven’t had a lot of sleep lately. Plus I have different versions of MODx and QuickEdit spread all over.

I’m attaching the current version with all of the updates I mentioned below in place. I defined the current "TV"s variable in such a way that plugins should be able to manipulate the saved values for any of the content being edited in QuickEdit.

For TP3, a couple of other minor things to think about including:

• removing border to eliminate the 2px jump on hover in QE for many installs
• Add DropMenu snippet ... some more testing going on as I write this, but this is THE uber-menu snippet with mojo flexibility. It can do just about anything, menu-wise, and it should be highly recommended, especially after we get done documenting some examples and styling.
• Adding FlexSearchForm as the default search form.
• Choose one of Brook’s (webmedic’s) default themes and use that instead of the Eto-ish default theme
• A more thorough "blank-state" install with links to helpful resources and Quick Editor turned on.
• Offering Victor’s (vbrilon) "kickstart" installer, which is a tiny 3KB file you upload to the server and it downloads everything (server to server, so it’s really fast, even on dialup), checks MD5s to make sure they’re not corrupted uncompresses everything, sets permissions properly on the uncompressed files then fires up the installer... needs a bit of logic to handle udpates better, but for new installs, it’s amazing.

Some possible "blank state" content:

• FlexSearchForm with search results page
• a sitemap page
• a contacts page (with download links to Brook’s templates, the support site, etc.)
• a mini-blog, with default first entry being how to turn on comments using the UserComments snippet
• a few content pages, perhaps "who we are" and "what we do" all populated with information about MODx

Quote from: rthrash at Aug 28, 2005, 04:53 PM

• removing border to eliminate the 2px jump on hover in QE for many installs

I’ll play around with some background images that will work. I’m thinking I might redo the look of the QE links a bit so they’re a more generic color which should work with any theme. I’ll also try to shoot for something that doesn’t use borders.

Will grab this one and update nice work

I used the diff files and rerun the installer all looked nice until the last screen from the installer
getting this error:

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /home/httpd/vhosts/kinghosting.nl/subdomains/modx/httpdocs/install/setup.info.php on line 115


Quick edit "No record found for id 0" error came back.

Hi Dimmy,

Thanks for the feedback. I’ve fixed the bug and have updated the first post.

Note: this update does not include QEv7. I’ll be waiting for Adam’s updates to the css links stuff