Pre 3.2 release bug testing files

So, here we go again. Another release.

I took Raymonds advice and went with <quickedit:content /> as opposed to <!-- QuickEditLink:content --> so you may have to clear the cache on your site after upgrading.

I also added a permissions FAQ to the documentaiton since they can be tricky.

The other changes were to permissions stuff. For instance now, the links will not show up if the user is not a member of any of the QuickEdit user groups, if any are assigned.

I also added an exit command to the end of the module to keep the new manager from encroach on my output (thanks Travis).

And thanks for all the great feedback guys. I think it’s looking really solid now but I’ll probably think of some other things to do while I’m in the shower tomorrow

P.S. sorry for missing Raymonds latest 3.2 release by a few minutes. Oh well.

Hi Adam,

I got an error about mergeComments() being undefined

Quote from: xwisdom at Aug 21, 2005, 04:56 PM

I got an error about mergeComments() being undefined

Oops. Forgot to change that name. I renamed the method from mergeComments to mergeTags, since they aren’t comments anymore. I updated the attachment above. Just download it and update the QuickEdit plugin code.

Adman,

The "(" is missing from $outputObject->mergeTags line 65.

I’ve added the fix

Quote from: xwisdom at Aug 21, 2005, 07:15 PM

The "(" is missing from $outputObject->mergeTags line 65.

It’s been a long week. Thanks for catching that, I updated the attachment.

Couple of other quick notes:

I’d like your documentation to appear inside the new manager. It’s close, but there are a couple of changes for it to work...

Your #logo is conflicting because that is what we are using for the MODx logo. If I try really, really hard can I convince you to make these two changes so that I can keep pretty close to your code?

1. Change the name of your #logo CSS element.
2. Change the placement of the exit; so that renderEditorHTML exits but the documentation call does not.

Sorry, I hope I’m not being a pest. I don’t think these affect anything in TP3.2, though, and will help me keep up with your changes easily, as all I have to do is remove a couple of your CSS styles.

Have I mentioned how much I LOVE this?

Quote from: infoclipper at Aug 21, 2005, 07:47 PM

Your #logo is conflicting because that is what we are using for the MODx logo. 

Travis,

Why not use a prefix for modx class or ids? For example, mgrLogo.

Quote from: infoclipper at Aug 21, 2005, 07:47 PM

1. Change the name of your #logo CSS element.
2. Change the placement of the exit; so that renderEditorHTML exits but the documentation call does not.

Done. I prefixed all of the ids and classes with qe_ so that we won’t run into this in the future.

Quote from: infoclipper at Aug 21, 2005, 07:47 PM

Have I mentioned how much I LOVE this?

That’s okay, I don’t mind hearing it again

I just updated the attachment above. I don’t want to flood this thread with updates.

Raymond, wouldn’t it be easier to change one small file (or set thereof) than the entire rewrite of the manager throughout? Or am I confused?

Quote from: xwisdom at Aug 21, 2005, 03:42 PM

New installs will use [*#longtitle*] and [*#content*]. The cool thing is that even if the QuickEdit module is disabled or removed the pages will still be rendered as if it contained [*longtitle*] and [*content*].

One quick note. If we are going to have the content editable by default it would be good to throw a div around it. That way when you hover over the link it will only highligt the content area instead of the content area and the longtitle area.

A little nitpicky maybe but it’s so simple I figure it would be worth mentioning. Plus, since the documentation I wrote suggests that I figured it would be good to practice what you preach.