-
MODX Staff
- 12,272 Posts
Sorry, I meant where are they set in the code that assigns them in the first place (not the stylesheets).
Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
-
MODX Staff
- 12,272 Posts
Very nice work Adam! Looks great and behaves properly! I made some minor tweaks to the CSS to prevent jumping of the menu items and to put a "hover zone" around the menu for errant mousing. This messes up the dropdowns a bit though. Let’s get that straightened out or remove the dropdowns grows ... or move the effect to the top hover ... or somehting... lol.
What do you think about toning down the pulsate effect – maybe swapping with highlight would work – on show / hide links?
Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
Question:
Why are we using assets/js and not manager/media/scripts?
I think the scriptaculous libs should be stored inside the system (manager) folders. It’s going to be part of the core
-
MODX Staff
- 12,272 Posts
The way I see it, Scriptaculous will be frequently updated and used on individual sites. The version we might or might not distribute might or might not work with a particular sites’ needs. This will keep site-specific things inside the assets folder making upgrades much easier IMHO.
Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
-
MODX Staff
- 12,272 Posts
Then again, this will all change in the very near future with TP4... right now nothing in the manager uses scriptaculous. If it did, then the logic would be different.
Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
The way I see it, Scriptaculous will be frequently updated and used on individual sites. The version we might or might not distribute might or might not work with a particular sites’ needs.
I don’t think we should allow users to update code that will be made a part of the core in TP4. The other think is that we might even need to distribute a modified version of the lib in order to get it to do specific stuff.
-
MODX Staff
- 12,272 Posts
Are we talking about TP3.3 or TP4? That’s two totally different beasts in my mind.
Ryan Thrash, MODX Co-Founder
Follow me on Twitter at @rthrash or catch my occasional unofficial thoughts at thrash.me
For most users TP4 will be an upgrade from TP3.3