[Module] QuickEdit

Here are some new QuickEdit files. We didn’t have a QuickEdit topic in the Modules, Snippets & Plugins forum and it was getting difficult to find the mest recent version (even for me), so here we go with a fresh thread.

Changes:
Broke the toolbar off into a smaller, dragable, expandable toolbar.
Added links to edit any content in on the page whether visible in the template or not.
Organized the quick_edit directory files into folders
Some other bug fixes that I’m probably forgetting

To-do:
Add publish/unpublish support
Make changes to manager sessions for TP4 support

Requirements:
You’ll need to put the files in assets-javascript.zip (attached) in an /assets/js/ folder (these files will be included in 3.3.

I haven’t had a lot of time to test this release, so please let me know if you have any problems.

Update:
Changed javascript include path from /assets/javascript to /assets/js/.
Fixed a =/== issue that was wreaking havoc on site styles
Added menutitle and introtext edit links
Added a widened the expand triggering area
Added description edit link
Applied move cursor to title bar
Added QE_TV and QE_BuiltIn classes to toolbar edit links
Various sundry styling issuess.
Show/hide links was going back to home page... no mas.
Added TV edit link styles from Ryan

Just to note, planning on using assets/js/ for the Javascript directory, FWIW. Assuming that’s the scriptaculous stuff, right?

Quick report:

Doesn’t seem to work in FF or Safari completely. Can’t edit any of the fields. Installed at Pixelhick, btw, so you can test and play. "Original" links still work for editing though (just not the "hidden/listed" ones).

Pane is not dragable either.

I take that back, regular links don’t seem to save the changes, and the site tries to reload for a long time.

Quote from: rthrash at Oct 05, 2005, 02:45 AM

Just to note, planning on using assets/js/ for the Javascript directory, FWIW. Assuming that’s the scriptaculous stuff, right?

I thought QuickEdit was a module, and all its stuff went into assets/modules/quickedit?

Yes, but scriptaculous is being reference as a "library" of sorts in assets/js/ (for javascript) ... it’s useful in many instances and can be updated easily in that location.

Quote from: rthrash at Oct 05, 2005, 02:45 AM

Just to note, planning on using assets/js/ for the Javascript directory, FWIW. Assuming that’s the scriptaculous stuff, right?

Alright, I’ll make that change and reupload it. Thanks.

Quote from: rthrash at Oct 05, 2005, 03:03 AM

Doesn’t seem to work in FF or Safari completely. Can’t edit any of the fields. Installed at Pixelhick, btw, so you can test and play. "Original" links still work for editing though (just not the "hidden/listed" ones).

Pane is not dragable either.

Really? It all seems to work on my install. I’ll take a look at Pixel Hick and see what I can figure out.

Quote from: rthrash at Oct 05, 2005, 03:03 AM

Doesn’t seem to work in FF or Safari completely. Can’t edit any of the fields. Installed at Pixelhick, btw, so you can test and play. "Original" links still work for editing though (just not the "hidden/listed" ones).

Pane is not dragable either.

I took a look at pixelhick and there was an existing link to prototype.js and scriptaculous.js that was broken (ponting to /assets/site/). I changed it to /assets/js/ and everything seems to be working fine now.

I did notice a couple of bugs though. The editor frame resizing doesn’t seem to be working. I’ll try to find out why. And the draggable toolbar gets messed up if you drag it too quickly. I’ll see if I can get these fixed but it might not be until tonight.

Also, dragging the toolbar on pixelhick seems to move the footer image in Firefox. Not a big deal but since this will be the default theme it might be worth looking into. And in IE the links dissapear after the toolbar expands, this seems to be an issue that is limited to the pixelhick template though. I’ll probably have to get very specific about the styles and use a lot of !importants, to avoid conflicts with site stylesheets.

Okay, I think everyting is looking pretty good now. The editor resizing was just my Firefox Javascript settings. Doh!

There are a couple of issues that seem to be limited to the default 3.3 theme (pixelhick.com). But if they are probably going to be an issue in any CSS heavy site, so they need to be fixed. They are...

PixelHick / QE Issues
Links dissapear after toolbar expand (IE only)
Toolbar get’s jumbled if moved too quickly
Header flickers on toolbar expand (IE only)

I’ll see what I can do to fix these, hopefully it won’t take too much work. Since this is the default theme I think we need to get it working smoothly.

Adam, where are the CSS attributes assigned and written for the various pieces? I’ll take a peek at it too.