MODX Revolution 2.4.3 — A Variety of Bug Fixes and Enhancements

• • 
  • 212 Posts
  lettis Reply #11, 8 years, 1 month ago

  Hi Susan,
  
  the echo is an example I created to illustrate the problem.
  
  Thanks a lot for caring!
• • ☆ A M B ☆
  • 24,524 Posts
  sottwell Reply #12, 8 years, 1 month ago

  I poked at it a bit, and here's what I got.
  
  Chunk cached -> placeholder cached, OK.
  Chunk cached -> placeholder uncached (!), goes to default value.
  Chunk uncached (!) -> placeholder cached, OK.
  Chunk uncached (!) -> placeholder uncached (!), OK
  
  This was with 2.4.2, 2.4.3, and 2.5.0.
  
  
  
  Studying MODX in the desert - http://sottwell.com
  Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
  Join the Slack Community - http://modx.org
• • ☆ A M B ☆
  • 24,524 Posts
  sottwell Reply #13, 8 years, 1 month ago

  The changes in the 2.4.3 changelog refer to when you have nested tags, such as
  

  [[pdoMenu? &parents=`[[!somesnippet]]`...]]

  
  I don't think it has any effect on placeholders.
  Studying MODX in the desert - http://sottwell.com
  Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
  Join the Slack Community - http://modx.org
• • 
  • 212 Posts
  lettis Reply #14, 8 years, 1 month ago

  Susan,
  
  that´s really strange. Especially I don´t understand the different behavior between our two MODx-Installations. One works as before. The other one only when calling the chunk uncached and when using uncached placeholders in the chunk for the passed properties.
  
  Do you think there could be a system setting responsible for this behavior?
• • 
  • 212 Posts
  lettis Reply #15, 8 years, 1 month ago

  I did the following test to exactly show the problem:
  
  Resource-Content (template empty):
  

  [[$testchunk]]

  
  
  Chunk:
  

  [[+value:default=`hello`]]

  
  
  Output in Revo 2.4.2:
  

  hello

  
  
  Output in Revo 2.4.3:
  

  no output/nothing/empty/-

  
  
  ++++
  
  When adding ! for uncached in Revo 2.4.3 in the placeholder of the chunk like this:
  

  [[!+value:default=`hello`]]

  
  
  Output:
  

  hello

  
  
  
  
  So what do you think could be the reason for this? And can anybody test this code and confirm this new behavior of MODx 2.4.3? [ed. note: lettis last edited this post 8 years, 1 month ago.]
• • ☆ A M B ☆
  • 24,524 Posts
  sottwell Reply #16, 8 years, 1 month ago

  I was mistaken, what I thought was a 2.4.2 installation was actually 2.5.0 - will install 2.4.2 and see what I get.
  Studying MODX in the desert - http://sottwell.com
  Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
  Join the Slack Community - http://modx.org
• • 
  • 212 Posts
  lettis Reply #17, 8 years, 1 month ago

  Quote from: sottwell at Feb 23, 2016, 03:25 AM

  I was mistaken, what I thought was a 2.4.2 installation was actually 2.5.0 - will install 2.4.2 and see what I get.

  
  Thanks a lot. Please test it in 2.4.3 and not in 2.4.2. In 2.4.2 everything works fine, but not in 2.4.3
  
  Thanks a lot again!!!
• • ☆ A M B ☆
  • 24,524 Posts
  sottwell Reply #18, 8 years, 1 month ago

  With 2.4.3 and 2.5.0, it is as you said with the code you posted last. With both cached, there is no output.
  Studying MODX in the desert - http://sottwell.com
  Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
  Join the Slack Community - http://modx.org
• • 
  • 109 Posts
  clareoconsulting Reply #19, 8 years, 1 month ago

  Quote from: lettis at Feb 23, 2016, 12:03 AM

  can anybody test this code and confirm this new behavior of MODx 2.4.3?

  
  Using @lettis test case, I can confirm that the behavior did change between 2.4.2 and 2.4.3. Note: It seems only to relate to the use of the default filter for the placeholder. If the chunk call actually contains the placeholder value (i.e. [[$testchunk? value=`goodbye`]]) it works as expected on both MODX versions.
  
  I'm 99% certain that it's caused by the change Bob and Susan mentioned (Prevent uncacheable elements from being cached in cacheable elements). Here's why:
  

  
  
  • The commit that made that change (https://github.com/modxcms/revolution/commit/7158bd929fec20f9ba2f6fe744896ddfe08d714e) added a new system setting, "parser_recurse_uncacheable".
  • Changing that setting on the 2.4.3 installation made @lattis test case work as it did in 2.4.2

  
  This seems like a significant enough regression that it would probably be good to:
  

  
  
  1. Continue this discussion, if needed, in another thread outside of Announcements
  2. Open a Github issue (https://github.com/modxcms/revolution/issues)
  3. Edit: I should have looked in Github first. There's already an issue open about this: https://github.com/modxcms/revolution/issues/12906

  [ed. note: clareoconsulting last edited this post 8 years, 1 month ago.]

This discussion is closed to further replies. Keep calm and carry on.