modxTalks

58 Posts

Krischel Reply #1, 9 years ago

Hi, I like modxTalks.
Unfortunately the latest version 1.0.4 isn't without errors. Maybe someone can help or has any idea about this?

My system: MODX 2.4.1 | modxTalks 1.0.4 | PHP 5.6.10

1) Error Log:

Table 'modx.modx_modxtalks_mails' doesn't exist

-> solution link

2) Error Log (after solution 1):

(WARN @ /www/htdocs/xxxxxx/modx/core/components/modxtalks/mailer.php) `114` was requested but no alias was located.
(INFO @ /www/htdocs/xxxxxx/modx/core/components/modxtalks/mailer.php) Removed modxTalksMails instance with primary key 10

-> so far no solution found (my russian is not well)

3) MODXTalksPlugin:
It seems the plugin missing the Event "OnModxTalksCommentAfterRemove"?

[ed. note: krischel last edited this post 9 years ago.]

☆ A M B ☆
24,524 Posts

sottwell Reply #2, 9 years ago

Unfortunately there doesn't seem to be any active maintenance for MODXTalks. I like it a lot myself, but I'm not sure that it's actually usable in its current state.

Studying MODX in the desert - http://sottwell.com
Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
Join the Slack Community - http://modx.org

58 Posts

Krischel Reply #3, 9 years ago

Hi Susan, Thanks for your statement.

I've saw your efforts on the github page and it is a pity that this nice tool doesn't really supported.

btw: I've translated the lexicon in German (ca 80%) and if modxTalks run without errors, I would like to make it available to the community. However, I just don't know how?

For those people who are interested the German file - you can try my attachment 'modxtalks104-de.zip' ;-)

☆ A M B ☆
24,524 Posts

sottwell Reply #4, 9 years ago

In the plugin code, on line 101 it should be

    case 'OnModxTalksCommentBeforeRemove':

It adds two events, OnModxTalksCommentAfterAdd and OnModxTalksCommentBeforeRemove to the system_eventnames table. I am presuming that the actions should occur before actually removing the comment.

In the code there are actually four events, before and after for each of the two actions. But only those two were added to the system_eventnames table.

Studying MODX in the desert - http://sottwell.com
Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
Join the Slack Community - http://modx.org

☆ A M B ☆
24,524 Posts

sottwell Reply #5, 9 years ago

I've fixed the installation problems, I need to push my changes to my github fork and make a pull request. Hopefully my fork will be updated and available for download with a pre-built package by the end of the day (GMT +2).

Studying MODX in the desert - http://sottwell.com
Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
Join the Slack Community - http://modx.org

☆ A M B ☆
24,524 Posts

sottwell Reply #6, 9 years ago

Ok, have pushed my changes to my repository and made a pull request. You can get the built transport package at https://github.com/sottwell/modxTalks from the _packages folder.

To install, download the transport package to your computer. Use the "Upload a package" option from the dropdown on the right of the Download Extras button to upload it to your site's core/packages folder. It will now be available in the list of packages to install.

Studying MODX in the desert - http://sottwell.com
Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
Join the Slack Community - http://modx.org

58 Posts

Krischel Reply #7, 9 years ago

Hi Susan, great job!

I found a small blemish in (isn't from you ; )
/core/components/modxtalks/model/modxtalks/modxtalks.class

"fixed" => "<a href='javascript:BBCode.fixed(\"$id\");void(0)' title='" . $this->modx->lexicon('modxtalks.image') . "' class='bbcode-fixed'><span>" . $this->modx->lexicon('modxtalks.fixed') . "</span></a>",

I changed it:

"fixed" => "<a href='javascript:BBCode.fixed(\"$id\");void(0)' title='" . $this->modx->lexicon('modxtalks.fixed') . "' class='bbcode-fixed'><span>" . $this->modx->lexicon('modxtalks.fixed') . "</span></a>",

Maybe you can change this?

Two error messages I still have, after a new entry:

(WARN @ /www/htdocs/xxxxxx/modx/core/components/modxtalks/mailer.php) `114` was requested but no alias was located.
(INFO @ /www/htdocs/xxxxxx/modx/core/components/modxtalks/mailer.php) Removed modxTalksMails instance with primary key 5

and after delete entry:

(ERROR @ /assets/components/modxtalks/connectors/connector.php) [modxTalks web/comment/remove] Error recalculate comments indexes 2

☆ A M B ☆
24,524 Posts

sottwell Reply #8, 9 years ago

Ok, I've added the fix to the lexicon reference, updated the transport package in https://github.com/sottwell/modxTalks/tree/master/_packages and made another pull request.

As far as the other errors, I can read MODX _build files well enough to understand and fix them, but I don't know that much about ModxTalks core code.

Studying MODX in the desert - http://sottwell.com
Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
Join the Slack Community - http://modx.org

58 Posts

Krischel Reply #9, 6 years, 9 months ago

Hi, do anyone use this modxTalks?
It's a pity that too much stuff broken.

Although there are some errors reported, there aren't done anything there for years.

Which alternative do you use as commenting (instead of modxTalks or Quip)?

932 Posts

LK Reply #10, 6 years, 9 months ago

Disqus is good

■ email: [email protected] | ■ website: https://alienbuild.uk

The greatest compliment you can give back to us, is to spend a few seconds leaving a rating at our trustpilot: https://uk.trustpilot.com/review/alienbuild.uk about the service we provided. We always drop mention of services offered by businesses we've worked with in the past to those of interest.