the upload bug in javascript

2 Posts

augustheart Reply #1, 11 years, 7 months ago

MODX version: MODX Revolution 2.3.3-pl (traditional)
Version codename: Revolution

assets\modext\util\multiuploaddialog.js

var permittedFileTypes = MODx.config['upload_files'].toLowerCase().split(',');

should be

var permittedFileTypes = MODx.config['upload_files'].toLowerCase().split(',');
    var flashtypes = MODx.config['upload_flash'].toLowerCase().split(',');
    var imagetypes = MODx.config['upload_images'].toLowerCase().split(',');
    var mediatypes = MODx.config['upload_media'].toLowerCase().split(',');
    permittedFileTypes =permittedFileTypes.concat(flashtypes,imagetypes,mediatypes);

or you will cant upload any image.
I cant reach svn.modx.com,so I dont know if this had been fixed.

☆ A M B ☆
24,524 Posts

sottwell Reply #2, 11 years, 7 months ago

MODX is on GitHub now, has been for some years.

Have you looked at the list of filetypes in the upload_files setting? It has almost all of the file types that are in the other two settings.

txt,html,htm,xml,js,css,zip,gz,rar,z,tgz,tar,htaccess,mp3,mp4,aac,wav,au,wmv,avi,mpg,mpeg,pdf,doc,docx,xls,xlsx,ppt,pptx,jpg,jpeg,png,gif,psd,ico,bmp,odt,ods,odp,odb,odg,odf

Studying MODX in the desert - http://sottwell.com
Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
Join the Slack Community - http://modx.org

2 Posts

augustheart Reply #3, 11 years, 7 months ago

I am a new hand.I install modx only two week.
I download modx from http://modx.com/download/, and not chang any thing in System Setting -> File System.
there are value in File System:

upload_files :txt,html,htm,xml,js,css,zip,gz,rar,z,tgz,tar,htaccess,mp3,mp4,aac,wav,au,wmv,avi,mpg,mpeg,pdf,doc,xls,txt
upload_flash : swf,fla
upload_images : jpg,jpeg,png,gif,psd,ico,bmp
upload_maxsize : 1048576
upload_media : mp3,wav,au,wmv,avi,mpg,mpeg