Redesign how deleted things are handled.

In last few days I've started to throw "issues" against the modx github repository. Tiny things I believe are broken or could be improved:

Please change click behavior for nested elements in the tree
https://github.com/modxcms/revolution/issues/756

Please fix the layout of multi-select TVs
https://github.com/modxcms/revolution/issues/755

Please add content type pdf to default content types.
https://github.com/modxcms/revolution/issues/758

In hindsight, the forum would have been better place to start the discussion, collect some input and then either turn them into a well written issue or even a pull request. As of now I'll try it this way around.

Today I'll start with a topic that has been nagging me for a long time.

Redesign how deleted things are handled.

I know there are extensions that make it easier to handle deleted things (VersionX, etc), but I think that some aspects of this topic have to be handled on a lower level.

1. Add permanent deletion of resources on an individual level.
I think it should be possible to pick a single resource and delete it permanently from the database. Right now its all or nothing and I don't think this is good solution. If I had individual permanent deletion, I would remove the trash can completely far all users.

2. Change how the trash can works.
I'd like to have a list of all deleted resources in a neat grid instead of a button asking me to send a number of anonymous things to the netherealms.

3. Add delete and undelete to elements (snippets, chunks, plugins, etc).
Even people that don't practice wild west programming delete the wrong things from time to time. It wold be nice to have a second line of defense.

4. Enhance the delete modal.
The modal shouldn't just ask "Are you sure you want to remove this file/resource?". Instead it should ask: "Are you sure you want to remove Contact Details (9)?" Especially on the elements tab, where deletion is permanent, this would be a very important imporvement.

5. Remove the delete button from already deleted resources.
Thats only a cosmetic feature. Deleted resources still have a "delete" button next to the "duplicate" and the "view" button. Its redundant and has absolutely no meaning or function.

If you have further ideas how to improve how MODX handles deletion, please share your thoughts. If you have a solution for one of those issues, create a pull request or contact me and I'll create a pull request for you.

Regards,

pepebe [ed. note: pepebe last edited this post 12 years, 9 months ago.]

3. Add delete and undelete to elements (snippets, chunks, plugins, etc).
Even people that don't practice wild west programming delete the wrong things from time to time. It wold be nice to have a second line of defense.

I like the idea, but I think it would mean a new field for each element's table, which would be a major change.

4. Enhance the delete modal.
The modal shouldn't just ask "Are you sure you want to remove this file/resource?". Instead it should ask: "Are you sure you want to remove Contact Details (9)?" Especially on the elements tab, where deletion is permanent, this would be a very important imporvement.

+1 It doesn't seem like this should be that difficult to implement.

5. Remove the delete button from already deleted resources.
Thats only a cosmetic feature. Deleted resources still have a "delete" button next to the "duplicate" and the "view" button. Its redundant and has absolutely no meaning or function.

It would make sense if it said "delete permanently" for already-deleted resources and then acted accordingly.

Quote from: BobRay at Dec 21, 2013, 09:49 AM

3. Add delete and undelete to elements (snippets, chunks, plugins, etc).
Even people that don't practice wild west programming delete the wrong things from time to time. It wold be nice to have a second line of defense.

I like the idea, but I think it would mean a new field for each element's table, which would be a major change.

Will it cause so much trouble adding a single row to each element's table? The default for deleted is empty/0/no, so I believe updating from an old modx version would not be a problem.

Quote from: BobRay at Dec 21, 2013, 09:49 AM

4. Enhance the delete modal.
The modal shouldn't just ask "Are you sure you want to remove this file/resource?". Instead it should ask: "Are you sure you want to remove Contact Details (9)?" Especially on the elements tab, where deletion is permanent, this would be a very important imporvement.

+1 It doesn't seem like this should be that difficult to implement.

This would really be a good idea. Don't know how often I deleted the wrong element.

Quote from: BobRay at Dec 21, 2013, 09:49 AM

5. Remove the delete button from already deleted resources.
Thats only a cosmetic feature. Deleted resources still have a "delete" button next to the "duplicate" and the "view" button. Its redundant and has absolutely no meaning or function.

It would make sense if it said "delete permanently" for already-deleted resources and then acted accordingly.

Yeah, that would be a much better button.

Thanks for sharing your thoughts...

P.S. I'm still waiting for the pizza recipe you promised at the bottom of this post: http://bobsguides.com/bread.html . IS there any chance you will finally share it?

Re: Pizza recipe

I'll add that to my to-do list, but fair warning, the list is about 500 items long.

Someone sent me another great bread recipe that I've also promised to put up "real soon now."

Ah, the guilt.