Minify Cache not working

49 Posts

janein Reply #1, 12 years, 9 months ago

Hi,

I'm optimizing the performance of my Modx-Manager.
And now i just discovered, that the minified js-files are not being cached.
The path is set to my core/cache/mgr/min directory, but no cache-files were created.

SO I checkd some other installations of modx - and none of them has cachefiles from the minify-compontent!

Is there any setting I have to set (I already set compress_js,compress_css, ... in the system-settings)?
Has anyone got this working on his/her install?

This question has been answered by opengeek. See the first response.

MODX Staff
10,725 Posts

opengeek Reply #2, 12 years, 9 months ago

That would not be an appropriate place to cache the minified responses; the core/ (and especially the core/cache/) directory should never be web accessible.

I believe minify sends caching headers to the browser...no physical cache file is produced.

Jason Coward
Chief Architect @ MODX
http://www.jasoncoward.com | http://twitter.com/drumshaman | https://github.com/opengeek

49 Posts

janein Reply #3, 12 years, 9 months ago

But in manager/min/README.txt it says:

RECOMMENDED

It's recommended to edit config.php to set $min_cachePath to a writeable
(by PHP) directory on your system. This will improve performance.

And in the index.php it is set to this path:

$min_cachePath = $modx->cacheManager->getCachePath() . 'mgr/min/';

And there is also no cache-header sent (takes over 1s to load!)

MODX Staff
10,725 Posts

opengeek Reply #4, 12 years, 9 months ago

Sounds like someone needs to fix that!

Jason Coward
Chief Architect @ MODX
http://www.jasoncoward.com | http://twitter.com/drumshaman | https://github.com/opengeek

49 Posts

janein Reply #5, 12 years, 9 months ago

So... this thing never actually worked and nobody noticed it?^^

I also tried to set another path outside the core but doesn't work anyway. Guess I should get theheaders to work correctly?

Just checked them and even If they are set (for example to tomorrow) the file still gets rebuild at every call...
Any idea how to fix this, so that I can finally cache at least all the static javascript?

discuss.answer

MODX Staff
10,725 Posts

opengeek Reply #6, 12 years, 9 months ago

Remove minify? To be honest, switching to using it has been one of the worst decisions we made in the Revolution manager.

Jason Coward
Chief Architect @ MODX
http://www.jasoncoward.com | http://twitter.com/drumshaman | https://github.com/opengeek

49 Posts

janein Reply #7, 12 years, 9 months ago

shame on me!
while thinking "reduce requets!!" I totally didnÄt think of just setting "compress_js" to 0 again and caching the all the single files in the browser... -.-

thanks for the hint! ;-)

Answered Minify Cache not working