The setup directory is not removed in a rare corner-case installation. I already found the reason and a (possible) fix.
In ‘modx-2.2.10-pl/setup/includes/modinstall.class.php‘:
/** @var modCacheManager $cacheManager */
$cacheManager = $modx->getCacheManager();
if ($cacheManager) {
- $setupPath = $modx->getOption('base_path').'setup/';
+ $setupPath = MODX_SETUP_PATH;
if (!$cacheManager->deleteTree($setupPath,true,false,false)) {
$modx->log(modX::LOG_LEVEL_ERROR,$this->lexicon('setup_err_remove'));
}
‘base_path’ is the path to the web context that does not need to be part of the setup path. AFAICS, MODX_SETUP_PATH is correct in any case.
I’d like to open an issue, however, I’m unsure about the proper priority: The installation guide strongly recommends that the directory is to be removed – on the other hand, rare corner case…
