1.0.13 Release Candidate

589 Posts

Eoler Reply #1, 12 years, 10 months ago

What's the status? Can we test it this weekend?
Template variables are not editable at the moment, CodeMirror acts strange on Create/edit Plugin field header...

https://github.com/dmi3yy/evolution/commits/master

☆ A M B ☆
1,031 Posts

Jako Reply #2, 12 years, 10 months ago

I have no issue in editing Template Variables.

- The date TV had a display bug.
- The Create/edit Plugin field header was strange.
- Checkboxes in MODxRE were moved down 2px.

All fixed with my last commit.

At the moment there is only one issue left in tracker – but no answer in forum for that. So feel free to test.
[ed. note: Jako last edited this post 12 years, 10 months ago.]

589 Posts

Eoler Reply #3, 12 years, 10 months ago

Quote from: Jako at Nov 08, 2013, 10:43 AM

I have no issue in editing Template Variables.

#tabInfo pane is missing (or JavaScript tab creating call is redundant, can't guess intention).

- The date TV had a display bug.
- The Create/edit Plugin field header was strange.
- Checkboxes in MODxRE were moved down 2px.
All fixed with my last commit.
At the moment there is only one issue left in tracker – but no answer in forum for that. So feel free to test.

Great, onward to upgrading test/development site with ~4000 resources to 1.0.13RC, will probably be back... wink

☆ A M B ☆
1,031 Posts

Jako Reply #4, 12 years, 10 months ago

Quote at Nov 09, 2013, 03:26 AM

#tabInfo pane is missing (or JavaScript tab creating call is redundant, can't guess intention).

Not on my test page. Maybe a plugin is causing your issue?

589 Posts

Eoler Reply #5, 12 years, 10 months ago

Quote from: Jako at Nov 09, 2013, 07:08 AM

Quote at Nov 09, 2013, 03:26 AM

#tabInfo pane is missing (or JavaScript tab creating call is redundant, can't guess intention).
Not on my test page. Maybe a plugin is causing your issue?

Line https://github.com/dmi3yy/evolution/blob/master/manager/actions/mutate_tmplvars.dynamic.php#L407
still throws exception because Dmytro removed tab wrapper div (div#tabInfo.tab-page) on Oct 15th:

Uncaught TypeError: Cannot read property 'tabPage' of null

☆ A M B ☆
1,031 Posts

Jako Reply #6, 12 years, 10 months ago

Sorry, my test page was out of sync and so I did not see the removed tab.

Fixed here: https://github.com/Jako/evolution/commit/58ba142863a1b6179bf01b1c502881cae42eb837

589 Posts

Eoler Reply #7, 12 years, 10 months ago

Quote from: Jako at Nov 11, 2013, 05:36 AM

Sorry, my test page was out of sync and so I did not see the removed tab.
Fixed here: https://github.com/Jako/evolution/commit/58ba142863a1b6179bf01b1c502881cae42eb837

Works great, thanks.
SMTP Password growth in config file also cured itself (it was around ~200 characters after tinkering with FileBrowser parameters).

Now to the next batch of observations:

* Create/edit Plugin field header has the same visual glitch Plugin had

* Manager/Web Permisssions are strange - td.width=100%/input(size=200) don't work that well

☆ A M B ☆
1,031 Posts

Jako Reply #8, 12 years, 10 months ago

Snippet field header was fixed before (https://github.com/dmi3yy/evolution/pull/166).

Manager/Web Permissions should look better now.

589 Posts

Eoler Reply #9, 12 years, 10 months ago

Quote from: Jako at Nov 11, 2013, 09:34 AM

Snippet field header was fixed before (https://github.com/dmi3yy/evolution/pull/166).

Sorry, there was c/p error in my previous post - problem is in the Create/edit Module field header.

Manager/Web Permissions should look better now.

Much better, thanks.

☆ A M B ☆
1,031 Posts

Jako Reply #10, 12 years, 10 months ago

Fixed too. Together with a few invalid HTML tags.