We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
    • 21417
    • 486 Posts
    Hello,

    I am using Ditto in an Evo 1.0.12 site to create an xml site map.

    I am currently sorting like so: &orderBy=`menuindex ASC, pagetitle ASC`.

    Everything works fine, but I am just wondering if it is possible to sort the list to match the order shown in the lhs MODX resource tree.

    Is there a custom sort extender floating around that would match the order of the resource tree?

    Say you have a resource tree with this order:
    Home
    Page 1
    Parent 1
    * * Child 1
    * * Child 2
    Parent 2
    * * Child 3
    * * Child 4
    Page 2
    Page 3

    I currently get a ditto order like so (just a bit random looking):
    Home
    * * Child 1
    * * Child 2
    Parent 1
    * * Child 3
    Page 1
    Parent 2
    Page 2
    * * Child 4
    Page 3

    I have used this extender before that I found in the forums to sort by ID in the ditto call but not sure how to change it to reflect the order of the MODX resource tree.

    <?php
     
    if (!function_exists('customsort'))
    {
    function customsort($a, $b)
    {
    $pos_a=array_search($a['id'],$GLOBALS['documents']);
    $pos_b=array_search($b['id'],$GLOBALS['documents']);
     
    if ($pos_a == $pos_b)
    {
    return 0;
    }
    return ($pos_a < $pos_b)?-1:1;
    }
    }
     
    $GLOBALS['documents']=explode(',',$documents);
    $orderBy["custom"][] = array ("id", "customsort");
    $ditto->advSort = true;
     
    ?>
    


    Any ideas?

    Not a major issue but would be nice if possible.

    Thanks in advance for any help.
      Web design Adelaide
      http://gocreate.com.au
      • 28042 ☆ A M B ☆
      • 24,524 Posts
      &orderBy=`menuindex ASC` should do the trick.
        Studying MODX in the desert - http://sottwell.com
        Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
        Join the Slack Community - http://modx.org
        • 9995
        • 1,613 Posts
        fourroses666 Reply #3, 13 years ago
        for sitemap.xml I always use a snippet:

        Resource with cache off and type txt/xml
        [!SiteMap? &format=`sp`!]


        Snippet SiteMap:

        <?php
        //<?php
        /**
         * sitemap
         * 
         * Outputs a machine readable site map for search engines and robots
         *
         * @category 	snippet
         * @version 	1.0.9
         * @license 	LGPL
         * @author	Grzegorz Adamiak [grad], ncrossland
         * @internal	@modx_category Navigation
         */
         
         
        /*
        ==================================================
        	sitemap
        ==================================================
        
        Outputs a machine readable site map for search
        engines and robots. Supports the following
        formats:
        
        - Sitemap Protocol used by Google Sitemaps
          (http://www.google.com/webmasters/sitemaps/)
        
        - URL list in text format
          (e.g. Yahoo! submission)
        
        
        History:
        # 1.0.9
        - update metadata format for use in ModX 1.0.x installer
        # 1.0.8
        - excludeTemplates can now also be specified as a template ID instead of template name. 
          Useful if you change the names of your templates frequently. (ncrossland)
          e.g. &excludeTemplates=`myTemplateName,3,4`
        # 1.0.7
        - Unpublished and deleted documents were showing up in the sitemap. Even though they could not be viewed, 
          they were showing up as broken links to search engines. (ncrossland)
        # 1.0.6
        - Add optional parameter (excludeWeblinks) to exclude weblinks from the sitemap, since they often point to external
          sites (which don't belong on your sitemap), or redirecting to other internal pages (which are already
          in the sitemap). Google Webmaster Tools generates warnings for excessive redirects.	
          Default is false - e.g. default behaviour remains unchanged. (ncrossland)
        # 1.0.5
        - Modification about non searchable documents, as suggested by forum user JayBee
          (http://modxcms.com/forums/index.php/topic,5754.msg99895.html#msg99895)
        # 1.0.4 (By Bert Catsburg, [email protected])
        - Added display option 'ulli'. 
          An <ul><li> list of all published documents.
        # 1.0.3
        - Added ability to specify the XSL URL - you don't always need one and it 
          seems to create a lot of support confusion!
          It is now a parameter (&xsl=``) which can take either an alias or a doc ID (ncrossland)
        - Modifications suggested by forum users Grad and Picachu incorporated
          (http://modxcms.com/forums/index.php/topic,5754.60.html)
        # 1.0.2
        - Reworked fetching of template variable value to
          get INHERITED value.
        # 1.0.1
        - Reworked fetching of template variable value,
          now it gets computed value instead of nominal;
          however, still not the inherited value.
        # 1.0
        - First public release.
        
        TODO:
        - provide output for ROR
        --------------------------------------------------
        */
        
        /* Parameters
        ----------------------------------------------- */
        
        # $startid [ int ]
        # Id of the 'root' document from which the sitemap
        # starts.
        # Default: 0
        
        $startid = (isset($startid)) ? $startid : 0;
        
        # $format [ sp | txt | ror ]
        # Which format of sitemap to use:
        # - sp <- Sitemap Protocol used by Google
        # - txt <- text file with list of URLs
        # TODO - ror <- Resource Of Resources
        # Default: sp
        
        $format = (isset($format) && ($format != 'ror')) ? $format : 'sp';
        
        # $priority [ str ]
        # Name of TV which sets the relative priority of
        # the document. If there is no such TV, this
        # parameter will not be used.
        # Default: sitemap_priority
        
        $priority = (isset($priority)) ? $priority : 'sitemap_priority';
        
        # $changefreq [ str ]
        # Name of TV which sets the change frequency. If
        # there is no such TV this parameter will not be
        # used.
        # Default: sitemap_changefreq
        
        $changefreq = (isset($changefreq)) ? $changefreq : 'sitemap_changefreq';
        
        # $excludeTemplates [ str ]
        # Documents based on which templates should not be
        # included in the sitemap. Comma separated list
        # with names of templates.
        # Default: empty
        
        $excludeTemplates = (isset($excludeTemplates)) ? $excludeTemplates : array();
        
        # $excludeTV [ str ]
        # Name of TV (boolean type) which sets document
        # exclusion form sitemap. If there is no such TV
        # this parameter will not be used.
        # Default: 'sitemap_exclude'
        
        $excludeTV = (isset($excludeTV)) ? $excludeTV : 'sitemap_exclude';
        
        # $xsl [ str ] 
        # URL to the XSL style sheet
        # or
        # $xsl [ int ]
        # doc ID of the XSL style sheet
        
        $xsl = (isset($xsl)) ? $xsl : '';
        if (is_numeric($xsl)) { $xsl = $modx->makeUrl($xsl); }
        
        
        # $excludeWeblinks [ bool ]
        # Should weblinks be excluded?
        # You may not want to include links to external sites in your sitemap,
        # and Google gives warnings about multiple redirects to pages 
        # within your site.
        # Default: false
        $excludeWeblinks = (isset($excludeWeblinks)) ? $excludeWeblinks : false;
        
        
        /* End parameters
        ----------------------------------------------- */
        
        # get list of documents
        # ---------------------------------------------
        $docs = getDocs($modx,$startid,$priority,$changefreq,$excludeTV);
        
        
        # filter out documents by template or TV
        # ---------------------------------------------
        // get all templates
        $select = $modx->db->select("id, templatename", $modx->getFullTableName('site_templates'));
        while ($query = $modx->db->getRow($select)) {
        	$allTemplates[$query['id']] = $query['templatename'];
        }
        
        $remainingTemplates = $allTemplates;
        
        // get templates to exclude, and remove them from the all templates list
        if (!empty ($excludeTemplates)) {
        	
        	$excludeTemplates = explode(",", $excludeTemplates);	
        	
        	// Loop through each template we want to exclude
        	foreach ($excludeTemplates as $template) {
        		$template = trim($template);
        		
        		// If it's numeric, assume it's an ID, and remove directly from the $allTemplates array
        		if (is_numeric($template) && isset($remainingTemplates[$template])) {
        			unset($remainingTemplates[$template]);
        		} else if (trim($template) && in_array($template, $remainingTemplates)) { // If it's text, and not empty, assume it's a template name
        			unset($remainingTemplates[array_search($template, $remainingTemplates)]);			
        		}
        	} // end foreach
        }
        
        $output= array();
        // filter out documents which shouldn't be included
        foreach ($docs as $doc)
        {
        	if (isset($remainingTemplates[$doc['template']]) && !$doc[$excludeTV] && $doc['published'] && $doc['template']!=0 && $doc['searchable']) {
        		if (!$excludeWeblinks || ($excludeWeblinks && $doc['type'] != 'reference')) {
        			$output[] = $doc;		
        		}
        	}
        }
        $docs = $output;
        unset ($output, $allTemplates, $excludeTemplates);
        
        
        # build sitemap in specified format
        # ---------------------------------------------
        
        switch ($format)
        {
        	// Next case added in version 1.0.4
        	case 'ulli': // UL List
        		$output .= "<ul class=\"sitemap\">\n";
        		// TODO: Sort the array on Menu Index
        		// TODO: Make a nested ul-li based on the levels in the document tree.
        		foreach ($docs as $doc)
        		{
        			$s  = "  <li class=\"sitemap\">";
        			$s .= "<a href=\"[(site_url)][~" . $doc['id'] . "~]\" class=\"sitemap\">" . $doc['pagetitle'] . "</a>";
        			$s .= "</li>\n";
        			$output .= $s;
        		} // end foreach
        		$output .= "</ul>\n";
        		break;
        		
        	case 'txt': // plain text list of URLs
        
        		foreach ($docs as $doc)
        		{
        			$url = '[(site_url)][~'.$doc['id'].'~]';
        
        			$output .= $url."\n";
        		} // end foreach
        		break;
        
        	case 'ror': // TODO
        	default: // Sitemap Protocol
        
        	
        	$output = '<?xml version="1.0" encoding="UTF-8"?>'."\n";
        	if ($xsl != '') {
        		$output .='<?xml-stylesheet type="text/xsl" href="'.$xsl.'"?>'."\n";
        	}
        	$output .='<urlset xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.sitemaps.org/schemas/sitemap/0.9 http://www.sitemaps.org/schemas/sitemap/0.9/sitemap.xsd" xmlns="http://www.sitemaps.org/schemas/sitemap/0.9">'."\n";
        	
        	
        	foreach ($docs as $doc)	{
        		$url = '[(site_url)][~'.$doc['id'].'~]';
        		$date = $doc['editedon'];
        		$date = date("Y-m-d", $date);
        		$docPriority = ($doc[$priority]) ? $doc[$priority] : 0; // false if TV doesn't exist
        		$docChangefreq = ($doc[$changefreq]) ? $doc[$changefreq] : 0; // false if TV doesn't exist
        
        		$output .= "\t".'<url>'."\n";
        		$output .= "\t\t".'<loc>'.$url.'</loc>'."\n";
        		$output .= "\t\t".'<lastmod>'.$date.'</lastmod>'."\n";
        		$output .= ($docPriority) ? ("\t\t".'<priority>'.$docPriority.'</priority>'."\n") : ''; // don't output anything if TV doesn't exist
        		$output .= ($docChangefreq) ? ("\t\t".'<changefreq>'.$docChangefreq.'</changefreq>'."\n") : ''; // don't output anything if TV doesn't exist
        		$output .= "\t".'</url>'."\n";
        	} // end foreach
        	$output .= '</urlset>';
        
        } // end switch
        
        return $output;
        
        # functions
        # ---------------------------------------------
        
        # gets (inherited) value of template variable
        function getTV($modx,$docid,$doctv)
        {
        /* apparently in 0.9.2.1 the getTemplateVarOutput function doesn't work as expected and doesn't return INHERITED value; this is probably to be fixed for next release; see http://modxcms.com/bugs/task/464
        	$output = $modx->getTemplateVarOutput($tv,$docid);
        	return $output[$tv];
        */
        	
        	while ($pid = $modx->getDocument($docid,'parent'))
        	{
        		$tv = $modx->getTemplateVar($doctv,'*',$docid);
        		if (($tv['value'] && substr($tv['value'],0,8) != '@INHERIT') or !$tv['value']) // tv default value is overriden (including empty)
        		{
        			$output = $tv['value'];
        			break;
        		}
        		else // there is no parent with default value overriden 
        		{
        			$output = trim(substr($tv['value'],8));
        		}
        		$docid = $pid['parent']; // move up one document in document tree
        	} // end while
        	
        	return $output;
        }
        
        # gets list of published documents with properties
        function getDocs($modx,$startid,$priority,$changefreq,$excludeTV)
        {
        	// get children documents
        	$docs = $modx->getActiveChildren($startid,'menuindex','asc','id,editedon,template,published,searchable,pagetitle,type'); 
        	// add sub-children to the list
        	foreach ($docs as $key => $doc)
        	{
        		$id = $doc['id'];
        		$docs[$key][$priority] = getTV($modx,$id,$priority); // add priority property
        		$docs[$key][$changefreq] = getTV($modx,$id,$changefreq); // add changefreq property
        		$docs[$key][$excludeTV] = getTV($modx,$id,$excludeTV); // add excludeTV property
        		
        		if ($modx->getActiveChildren($id))
        			$docs = array_merge($docs, getDocs($modx,$id,$priority,$changefreq,$excludeTV));
        	} // end foreach
        	return $docs;
        }
        ?>
        


          Evolution user, I like the back-end speed and simplicity smiley
          • 21417
          • 486 Posts
          Quote from: sottwell at Oct 08, 2013, 06:03 AM
          &orderBy=`menuindex ASC` should do the trick.
          Thanks for the suggestion Sottwell. I tried that but that doesn't reflect the resource tree / work how I want it because multiple resources (including children of parents) have the same menu index of 0, 1, 2 etc) and because Ditto is not hierachical. Basically, I want to sort the xml sitemap how wayfinder would sort an html sitemap. I think only an extender could do this?

          for sitemap.xml I always use a snippet: Resource with cache off and type txt/xml
          That's what I usually use for an xml sitemap but I am trying Ditto because the filtering is much better. Thanks though.
            Web design Adelaide
            http://gocreate.com.au