-
☆ A M B ☆
- 91 Posts
Quote from: opengeek at Aug 06, 2013, 08:46 AMThis looks like a bug to me. Do we have an issue in the tracker? Pull request maybe? 
Posted
https://github.com/modxcms/revolution/pull/553
Thanks!
It looks like there are some potential E_NOTICE problems, but most of them were there to begin with.
-
☆ A M B ☆
- 91 Posts
Quote from: BobRay at Aug 06, 2013, 02:34 PMThanks!
It looks like there are some potential E_NOTICE problems, but most of them were there to begin with.
Where notices? empty() end isset() not generate notices. isset() just check variable (not check value). empty() - soft checking value (without notices when variable not declared).
-
☆ A M B ☆
- 91 Posts
If you about this:
$scriptProperties['publishedby'] = $scriptProperties['published'] ? !empty($scriptProperties['publishedby']) ? $scriptProperties['publishedby'] : $this->modx->user->get('id') : 0;
$scriptProperties['published'] already checked
5 lines above.
Sorry, you are correct. The checks didn't show up in the diff at GitHub.
-
☆ A M B ☆
- 91 Posts
Quote from: BobRay at Aug 06, 2013, 04:54 PMSorry, you are correct. The checks didn't show up in the diff at GitHub.
That`s OK
