How do I contribute a core code patch?

☆ A M B ☆
450 Posts

jrotering Reply #1, 13 years, 3 months ago

I found a bug dealing with importing HTML and/or static resources when the "parent document" is in a context other than 'web'. I filed the bug report this morning.

http://tracker.modx.com/issues/9964

But I've already written a simple fix, in the files

/core/model/modx/processors/system/import/html.php
/core/model/modx/processors/system/import/index.php

How do I contribute this code fix? Is it a standard github pull request, or is there some other process?

75 Posts

sladdals Reply #2, 13 years, 3 months ago

Here it is https://github.com/modxcms/revolution

MODX Staff
10,725 Posts

opengeek Reply #3, 13 years, 3 months ago

We do use GitHub pull requests. Start here and let us know what other questions you might have; we're working on improving the contributor documentation...

Jason Coward
Chief Architect @ MODX
http://www.jasoncoward.com | http://twitter.com/drumshaman | https://github.com/opengeek

☆ A M B ☆
450 Posts

jrotering Reply #4, 13 years, 3 months ago

Thanks. This is going to force me to learn a little more git than I have needed to thus far. That is a Good Thing.

☆ A M B ☆
450 Posts

jrotering Reply #5, 13 years, 3 months ago

I read through the documentation, particularly the "Bug Branches" section, and I've attempted the pull request. I still don't have the whole "using git on my local machine" part down yet, so I just forked, made a new branch for the bug, made the edits to the 2 files, and submitted the pull request with the bug # in the name. Hope I did it right.