We launched new forums in March 2019—join us there. In a hurry for help with your website? Get Help Now!
    • 14372
    • 49 Posts
    To put it simply ... I'm working on an extra with the S3 SDK bundled in ... this is where I realized that the SDK is included into MODx several times and this sometimes results in conflicts like this https://github.com/splittingred/phpThumbOf/issues/42

    The AWS SDK is integrated into phpThumbOf, the MODx core itself and in my case my own extra.

    Is there a way we could avoid future conflicts and can this be consideration for future MODx releases? Sort of a documentation guiding devs on how to integrate into the aws-sdk in the core as opposed to adding their own sdk?

    I hope we can have a discussion about this and agree on a good way forward. Once we do, I could even commit some of the changes to the MODx Core on github.
      • 22303 MODX Staff
      • 10,725 Posts
      King'ori — thanks for the detailed information. We will be working towards externalizing all 3rd party dependencies in MODX for the 3.x releases, especially the S3 SDK.

      If you have ideas on the best way to handle this until that point (i.e. for further 2.x releases), I'd love to hear your ideas.
        • 14372
        • 49 Posts
        @opengeek - Honestly, I dunno because everything I've tried has failed. Eventually I build my own version of phpThumbOf that doesn't have its own sdk ... considering that my own extra had the sdk included I knew phpThumbOf would still have access to the sdk classes and methods.

        I was going to mention about externalising 3rd party code but you beat me to it. For now ... we'll/I'll just have to wait for 3.x

        Ps: I tried to do it ... forked the MODx core to play around but failed miserably. Was hoping this would be my first contribution :-(