Problem with Image-type TV and 2.4.2

MIGx 2.4.2 beta3 appears to have a problem embedding imgage-type TVs. Simple copy/paste from the rtfm example like I've done a hundred times before with previous versions, but the imgageTV field is just a text field. Putting in the same path that is used for a plain old image type TV works (./image.jpg); it even has the thumbnail in the grid. Doesn't matter if the image TV is assigned a media source or not.

Ok, it's not a problem with the image TV, it's a problem with the field being too wide so that the arrow for opening the image browser isn't displayed.

Maybe somebody can figure out why the image field is built like this

I've done a little poking around, but what with Smarty and ExtJS I can't figure out where that style and width is coming from.

strange. I have:



its on revo 2.2.5 here, on firefox, MIGx 2.4.2 beta3

This just happened in 2.2.7, it was not a problem in previous versions.

maybe it has todo with this mod:
https://github.com/modxcms/revolution/commit/dbd36390a4070f29319db81186fe8f66155fdb60

Hm. I really, really don't like scripts that insert inline styling. That should all be left to the CSS. But then I've never liked either Smarty or ExtJS.

I just updated a MIGX-heavy (2.4.2b3) site to 2.2.7 and I'm not sure at all if I'm understanding the topic of this post right, but my imageTVs show up as they should (with the little arrow on the right), no matter if it's a normal MIGX TV or a MIGXDB Grid (in resources or as CMP)...maybe you could add some screenshot?

This only occurs when it's in its own tab (exactly like the sample in the rtfm). If the image field is in the main tab, it's very wide, but Ok.

ok ok =)...got ya! It was my chrome cache preventing me from seeing that uglyness^^...tried FF and IE9 and voila there it is, cleared the cache and now I also have it in chrome (damn =D)...that's actually quite bad, will digg into this in a moment and if necessary restore the old file from the commit, rather have the small tvs than break the usability more or less...

Edit: tracked it down more or less but don't know how to really fix...

problem 1. file tvs (width 921px, and some more stuff wrong there, couldn't fix it manually)


problem 2. image tvs (would be fixed if that 97% would be 100%, but can by all means not find some 97 in the extjs)


i fixed it the bad way by just replacing the new manager/assets/modext/widgets/element/modx.panel.tv.renders.js with the old one from here: https://github.com/modxcms/revolution/blob/abd0e6bd0b322858869ac3888255cfba9d008738/manager/assets/modext/widgets/element/modx.panel.tv.renders.js

seems like just that one file has to be reverted to make it work "the old way" again...too bad, it's just a nightmare to debug that extjs markup mess...man

Added to the tracker here: http://tracker.modx.com/issues/9825 [ed. note: exside last edited this post 13 years, 5 months ago.]