[bug] modCacheManager::generateContext() broke JSON-formatted context settings

Part of code:
This replace all matches with {}
By this reason can`t save ExtensionPackages for same context: [{"pack":{"path":"[[++core_path]]components/pack/model/"}}]

Quote from: Fi1osof at Jan 05, 2013, 05:19 AM

Part of code:

if (preg_match_all('~\{(.*?)\}~', $v, $matches, PREG_SET_ORDER)) {
    foreach ($matches as $match) {
        if (array_key_exists("{$match[1]}", $contextConfig)) {
            $matchValue= $contextConfig["{$match[1]}"];
        } else {
            $matchValue= '';
        }
        $v= str_replace($match[0], $matchValue, $v);
    }
}

This replace all matches with {}
By this reason can`t save ExtensionPackages for same context: [{"pack":{"path":"[[++core_path]]components/pack/model/"}}]

Nice catch; we should not replace the matchValue if the array_key does not exist in the contextConfig...any chance you want to submit a PR for this?

.any chance you want to submit a PR for this?

Sorry, what is PR?

Quote from: Fi1osof at Jan 05, 2013, 07:44 AM

.any chance you want to submit a PR for this?

Sorry, what is PR?

Pull Request

Quote from: markh at Jan 05, 2013, 08:49 AM

Pull Request

Ow. OK:)

Posted: https://github.com/Fi1osof/revolution/commit/111556798b8afa8fbd8444a55753d251083d0315