Bringing Evo back to life again

☆ A M B ☆
24,524 Posts

sottwell Reply #281, 14 years, 5 months ago

It's because the MODx parser runs plugins before it processes any placeholders in the template, and the PHx plugin will eat all the placeholders in the document when it cleans up after itself. PHx used internally by Jot and Ditto isn't applied to the whole page, it only acts on the Jot or Ditto tpl. The plugin should only eat its own leftover unused placeholders, but for some reason it's removing them all. I've considered removing the garbage collection function from the plugin altogether, since the parser should remove any unused placeholder tags itself later.

Studying MODX in the desert - http://sottwell.com
Tips and Tricks from the MODX Forums and Slack Channels - http://modxcookbook.com
Join the Slack Community - http://modx.org

☆ A M B ☆
1,031 Posts

Jako Reply #282, 14 years, 5 months ago

For custom TVs the following patch would be great: http://tracker.modx.com/issues/1107

The PHx placeholder garbage collection problem is not only a plugin problem. If you use the chunkie class on any template chunk i.e. on eForm chunks all placeholders are missing on those chunks after, so the form chunk can't be processed by PHx - which would be great in eFormOnBeforeFormParse. For the report chunks I have a (at the moment) working event function solution.

A solution for PHx could be maybe a similar thing as in Revo: uncached placeholders (that are not processed by PHx but by the document parser).

222 Posts

Stefanie Reply #283, 14 years, 5 months ago

Status update

The development process goes on. yama submitted a lot of changes in the name of the Japanese community. All this changes are in the branch 1.1.dev.japanese, code reviews are welcome.

I extended ezSQL with a recordset object, to get the same behaviour as with MySQL results. The ezSQL_recordset class implements Iteration, you can go through a query result with foreach, next, and previous. ezSQL_fetch_assoc behaves like mysql_fetch_assoc, ezSQL_fetch_row like mysql_fetch_row, and ezSQL_fetch_object like mysql_fetch_object.
AS the original row of ezSQL is of stdClass, use ezSQL_fetch_object, because it is a tick faster, the other result methods are calculated with the object result. The sources of ezSQL are available at https://github.com/sjstoelting/ezSQL.

The development process on the DocumentParser class goes on. Every function gets PHPDoc tags with text. Where available, I use the documentation from http://rtfm.modx.com/display/Evo1/, but not all API functions are documented there by now.
I declared some functions private, because they where not used outside the DocumentParser class and should not be used from outside the class. It may happen, that one or the other function that is now private, is used by a snippet or module. In such cases we need to make them public again. This does not affect any API functions, they are all declared as public.

(Corrected a typo) [ed. note: Stefanie last edited this post 14 years, 5 months ago.]

Gone away and found a better place to stay

1,098 Posts

microcipcip Reply #284, 14 years, 5 months ago

I am trying to install 1.1.dev.japanese. I have these errors during the setup:

Checking if /assets/cache and /assets/cache/rss directories exist: FAILED!
Checking if /assets/cache/sitePublishing.idx.php file is writable: FAILED!

In my "assets/cache" directory I don't have "sitePublishing.idx.php" and I don't have the "rss" folder.

Environment: Windows 7, XAMPP LITE 1.7.7

Jertix.org -> Web Design & Development, Motion Graphics | Follow me on Twitter | MODx Tutorials (in Italiano) | MODx Snippets (English)

928 Posts

kp52 Reply #285, 14 years, 5 months ago

I had this too (on my first expedition into GitHub). I just created the empty folder and file named in the list (and I think siteCache.idx.php as well), and installation proceeded normally after that. (Windows 7, Apache 2.2.11, PHP 5.3.1)
:) KP

1,098 Posts

microcipcip Reply #286, 14 years, 5 months ago

Thanks, KP52, with your fix I can install it. These are the issues I have seen during installation:

1. Missing files

Checking if /assets/cache and /assets/cache/rss directories exist: FAILED!
Checking if /assets/cache/sitePublishing.idx.php file is writable: FAILED!

2. I choose English Installation but it actually install in Japanese.

3. Some issues with the demo website:
-- Logo is messed up
-- sidebar missing
-- missing css styles for eForm and blog
-- wrong padding in the content area

Jertix.org -> Web Design & Development, Motion Graphics | Follow me on Twitter | MODx Tutorials (in Italiano) | MODx Snippets (English)

☆ A M B ☆
1,231 Posts

yama Reply #287, 14 years, 5 months ago

222 Posts

Stefanie Reply #288, 14 years, 5 months ago

I didn't know, that the commits are not working by now. Now as this is clear, I only ask for code review, not for testing.

We integrate the changes of the Japanese community, when they say, they are ready, by then, the 1.1.dev.japanese branch is a working branch.

This does make it clear, that this is a fork, that I want to be reintegrated in Evo, as I've said in my comments on the blog at [urlhttp://modx.com/blog/2012/04/19/bringing-evolution-development-back-to-life/]http://modx.com/blog/2012/04/19/bringing-evolution-development-back-to-life/[/url].

Gone away and found a better place to stay

☆ A M B ☆
1,231 Posts

yama Reply #289, 14 years, 5 months ago

OK, Stefanie. I want you to wait for a while.
(We also waited for the reply from Ryan and others for two years. I do my best.)

222 Posts

Stefanie Reply #290, 14 years, 5 months ago

I've found an integration of Etomite_dbFunctions.php into the DocumentParser class.

Does someone know, if these functions are used at all?

getIntTableRows
putIntTableRow
updIntTableRow
getExtTableRows
putExtTableRow
updExtTableRow
dbExtConnect
getFormVars

The options to go on with these methods are:

Include them, writing unit tests and PHPDoc tags
Include them and mark them deprecated
Include them and define them private

I prefer the third option.

Gone away and found a better place to stay